04 Jan, 2006
4 commits
-
Currently all network protocols need to call dev_ioctl as the default
fallback in their ioctl implementations. This patch adds a fallback
to dev_ioctl to sock_ioctl if the protocol returned -ENOIOCTLCMD.
This way all the procotol ioctl handlers can be simplified and we don't
need to export dev_ioctl.Signed-off-by: Christoph Hellwig
Signed-off-by: David S. Miller -
Mid-term I plan to restructure the file_operations so that we don't need
to have all these duplicate aio and vectored versions. This patch is
a small step in that direction but also a worthwile cleanup on it's own:(1) introduce a alloc_sock_iocb helper that encapsulates allocating a
proper sock_iocb
(2) add do_sock_read and do_sock_write helpers for common read/write
codeSigned-off-by: Christoph Hellwig
Signed-off-by: David S. Miller -
It needs to return zero now that it is an initcall.
Also, net/nonet.c no longer needs a dummy sock_init().
Signed-off-by: David S. Miller
-
sock_init can be done as a core_initcall instead of calling
it directly in init/main.cAlso I removed an out of date #ifdef.
Signed-off-by: Andi Kleen
Signed-off-by: David S. Miller
28 Sep, 2005
1 commit
-
I have been experimenting with loadable protocol modules, and ran into
several issues with module reference counting.The first issue was that __module_get failed at the BUG_ON check at
the top of the routine (checking that my module reference count was
not zero) when I created the first socket. When sk_alloc() is called,
my module reference count was still 0. When I looked at why sctp
didn't have this problem, I discovered that sctp creates a control
socket during module init (when the module ref count is not 0), which
keeps the reference count non-zero. This section has been updated to
address the point Stephen raised about checking the return value of
try_module_get().The next problem arose when my socket init routine returned an error.
This resulted in my module reference count being decremented below 0.
My socket ops->release routine was also being called. The issue here
is that sock_release() calls the ops->release routine and decrements
the ref count if sock->ops is not NULL. Since the socket probably
didn't get correctly initialized, this should not be done, so we will
set sock->ops to NULL because we will not call try_module_get().While searching for another bug, I also noticed that sys_accept() has
a possibility of doing a module_put() when it did not do an
__module_get so I re-ordered the call to security_socket_accept().Signed-off-by: Frank Filz
Signed-off-by: David S. Miller
27 Sep, 2005
1 commit
-
It's on the stack and declared as "unsigned char[]", but pointers
and similar can be in here thus we need to give it an explicit
alignment attribute.Signed-off-by: Alex Williamson
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller
17 Sep, 2005
1 commit
-
Noticed by Sridhar Samudrala.
Signed-off-by: David S. Miller
08 Sep, 2005
1 commit
-
When we copy 32bit ->msg_control contents to kernel, we walk the same
userland data twice without sanity checks on the second pass.Second version of this patch: the original broke with 64-bit arches
running 32-bit-compat-mode executables doing sendmsg() syscalls with
unaligned CMSG data areasAnother thing is that we use kmalloc() to allocate and sock_kfree_s()
to free afterwards; less serious, but also needs fixing.Signed-off-by: Al Viro
Signed-off-by: David Woodhouse
Signed-off-by: Chris Wright
Signed-off-by: Linus Torvalds
07 Sep, 2005
1 commit
-
Avoid touching file->f_dentry on sockets, since file->private_data
directly gives us the socket pointer.Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
30 Aug, 2005
3 commits
-
This patch puts mostly read only data in the right section
(read_mostly), to help sharing of these data between CPUS without
memory ping pongs.On one of my production machine, tcp_statistics was sitting in a
heavily modified cache line, so *every* SNMP update had to force a
reload.Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
Of this type, mostly:
CHECK net/ipv6/netfilter.c
net/ipv6/netfilter.c:96:12: warning: symbol 'ipv6_netfilter_init' was not declared. Should it be static?
net/ipv6/netfilter.c:101:6: warning: symbol 'ipv6_netfilter_fini' was not declared. Should it be static?Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
Please consider the patch below which makes use of file->private_data to
store the pointer to the socket, which avoids touching several unused
cachelines in the dentry and inode in sockfd_lookup.Signed-off-by: Benjamin LaHaise
Signed-off-by: David S. Miller
23 Jun, 2005
1 commit
-
Small patch to save an unecessary call to strlen() : sprintf() gave us
the length, just trust it.Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
02 Jun, 2005
1 commit
-
I cunningly put the audit call immediately after the
copy_from_user().... but used the _userspace_ copy of the args still.
Let's not do that.Signed-off-by: David Woodhouse
17 May, 2005
1 commit
-
Signed-off-by: David Woodhouse
06 May, 2005
1 commit
-
Ross moved. Remove the bad email address so people will find the correct
one in ./CREDITS.Signed-off-by: Jesper Juhl
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
