09 Apr, 2013

1 commit

  • Silences the following warnings:
    drivers/pinctrl/pinctrl-ab8540.c:302:28: warning:
    symbol 'ab8540_alternate_functions' was not declared. Should it be static?
    drivers/pinctrl/pinctrl-ab8540.c:379:32: warning:
    symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static?

    Signed-off-by: Sachin Kamat
    Acked-by: Patrice Chotard
    Signed-off-by: Linus Walleij

    Sachin Kamat
     

10 Feb, 2013

2 commits

  • Make it harder to do mistakes by introducing the actual
    defined ABx500 IRQ number into the IRQ cluster definitions.
    Deduct cluster offset from the GPIO offset to make each
    cluster coherent.

    Signed-off-by: Linus Walleij

    Linus Walleij
     
  • The ABx500 GPIO controller used to provide a set of virtual contiguous
    IRQs for use by sub-devices, but they have been removed after a request
    from Mainline Maintainers. Now the AB8500 core driver deals with almost
    all IRQ related issues instead.

    The ABx500 GPIO driver is now only used to convert between GPIO and IRQ
    numbers which is actually quite difficult, as the ABx500 GPIO's
    associated IRQs are clustered together throughout the interrupt number
    space at irregular intervals. To solve this quandary, we have placed the
    read-in values into the existing cluster information table to use during
    conversion.

    Signed-off-by: Lee Jones
    [Moved irq_base removal into this patch]
    Signed-off-by: Linus Walleij

    Lee Jones
     

07 Feb, 2013

1 commit

  • Not quite sure how this ever worked. In ab8500_gpio_to_irq() the
    GPIO for conversion is passed through as the second argument. If
    GPIO13, which is a valid GPIO for IRQ functionality, was received;
    it would be rejected by the following guard:

    GPIO_IRQ_CLUSTER(5, 12, 0); /* GPIO numbers start from 1 */

    if (offset >= cluster->start && offset end)
    /* Valid GPIO for IRQ use */

    Signed-off-by: Lee Jones
    [Augmented to account for off-by-one problem]
    Signed-off-by: Linus Walleij

    Lee Jones
     

05 Feb, 2013

1 commit

  • Add AB8540 sub driver to the ABx500 family, pins, pin groups and
    gpio range.

    As the pin controller (also the ABx500 controllers) is an
    inherent part of the SoC and will prevent boot if not
    available, select this from the Ux500 SoC Kconfig.

    Acked-by: Olof Johansson
    Signed-off-by: Patrice Chotard
    Signed-off-by: Linus Walleij

    Patrice Chotard