Eric Lee / smarc-fsl-linux-kernel

30 Apr, 2013

1 commit

04 Jan, 2013

1 commit

  • 5a167f454   Drivers: rtc: remove __dev* attributes. ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
    markings need to be removed.

    This change removes the use of __devinit, __devexit_p, __devinitdata,
    __devinitconst, and __devexit from these drivers.

    Based on patches originally written by Bill Pemberton, but redone by me
    in order to handle some of the coding style issues better, by hand.

    Cc: Bill Pemberton
    Cc: Alessandro Zummo
    Cc: Srinidhi Kasagar
    Cc: Linus Walleij
    Cc: Mike Frysinger
    Cc: Wan ZongShun
    Cc: Guan Xuetao
    Cc: Mark Brown
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

30 May, 2012

1 commit

11 Aug, 2011

1 commit

  • bf6ed027b   rtc: ep93xx: Fix 'rtc' may be used uninitialized warning ... Browse Code »

    commit 92d921c5d "rtc: ep93xx: Initialize drvdata before registering device"
    ensures the drvdata is initialized prior to registering the rtc device.
    But it set the drvdata to an uninitialized pointer.
    Thus calling platform_get_drvdata in ep93xx_rtc_remove does not get correct address.

    This patch fixes below warning by adding struct rtc_device *rtc to struct ep93xx_rtc.
    Then set platform drvdata to ep93xx_rtc instead of rtc.

    CC drivers/rtc/rtc-ep93xx.o
    drivers/rtc/rtc-ep93xx.c: In function 'ep93xx_rtc_probe':
    drivers/rtc/rtc-ep93xx.c:154: warning: 'rtc' may be used uninitialized in this function

    Signed-off-by: Axel Lin
    Signed-off-by: John Stultz

    Axel Lin
     

07 May, 2011

1 commit

  • 92d921c5d   rtc: ep93xx: Initialize drvdata before registering device ... Browse Code »

    Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
    an issue in a number of RTC drivers, where the drivers call
    rtc_device_register before initializing the device or platform drvdata.

    This frequently results in null pointer dereferences when the
    rtc_device_register immediately makes use of the rtc device, calling
    rtc_read_alarm.

    The solution is to ensure the drvdata is initialized prior to registering
    the rtc device.

    CC: Alessandro Zummo
    CC: Thomas Gleixner
    CC: rtc-linux@googlegroups.com
    Signed-off-by: Wolfram Sang
    [Fixed up commit log -jstultz]
    Signed-off-by: John Stultz

    Wolfram Sang
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

07 Mar, 2010

1 commit

  • b4877d2b3   rtc-ep93xx.c: cleanup probe/remove routines ... Browse Code »

    Fix issue with rtc device not getting unregistered in probe error path.

    Use the devres managed resource functions in the probe routine to cleanup
    the error path.

    Use sysfs_{create/remove}_group to add/remove the sysfs files.

    Reduces the text size by 132 bytes, increases data by 12 bytes:
    text data bss dec hex filename
    - 937 124 0 1061 425 rtc-ep93xx.o
    + 805 136 0 941 3ad rtc-ep93xx.o

    Signed-off-by: H Hartley Sweeten
    Acked-by: Alessandro Zummo
    Cc: Paul Gortmaker
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    H Hartley Sweeten
     

23 Sep, 2009

1 commit

  • 971370cc1   drivers/rtc: introduce missing kfree ... Browse Code »

    Error handling code following a kzalloc should free the allocated data.

    The semantic match that finds the problem is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @r exists@
    local idexpression x;
    statement S;
    expression E;
    identifier f,f1,l;
    position p1,p2;
    expression *ptr != NULL;
    @@

    x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
    ...
    if (x == NULL) S
    }
    (
    x->f1 = E
    |
    (x->f1 == NULL || ...)
    |
    f(...,x->f1,...)
    )
    ...>
    (
    return \(0\|\|ptr\);
    |
    return@p2 ...;
    )

    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@

    print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
    //

    Signed-off-by: Julia Lawall
    Cc: David Brownell
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Julia Lawall
     

26 Apr, 2009

1 commit

  • 38f7b009a   [ARM] 5452/1: ep93x: rtc: use ioremap'ed addresses ... Browse Code »

    Update the rtc-ep93xx driver to use ioremap'ed addresses.

    This removes the dependency on and properly
    reports the memory addresses used by the driver in /proc/iomem.

    In addition, ep93xx_rtc_init() is updated to use
    platform_driver_probe() instead of platform_driver_register().

    Also, the device_create_file() calls are now properly checked for
    error conditions. The created sysfs files are also now removed
    when the driver is removed.

    The version number for the driver has been bumped at the request
    of Alessandro Zummo.

    Signed-off-by: H Hartley Sweeten
    Acked-by: Alessandro Zummo
    Signed-off-by: Russell King

    Hartley Sweeten
     

07 Jan, 2009

1 commit

  • bbccf83f6   rtc: use set_mmss when set_time is not available ... Browse Code »

    Drivers should only need to implement either set_mmss (counter based RTCs)
    or set_time (most RTCs). The RTC subsystem will handle them
    appropriately.

    Signed-off-by: Alessandro Zummo
    Cc: Kumar Gala
    Cc: David Brownell
    Cc: Lennert Buytenhek
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alessandro Zummo
     

07 Aug, 2008

2 commits

11 Apr, 2008

1 commit

  • ad28a07bc   rtc: fix platform driver hotplug/coldplug ... Browse Code »

    Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is
    prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable RTC
    platform drivers, to re-enable module auto loading.

    [dbrownell@users.sourceforge.net: more drivers, minor fix]
    Signed-off-by: Kay Sievers
    Signed-off-by: David Brownell
    Cc: Greg KH
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kay Sievers
     

01 Oct, 2006

1 commit

11 Apr, 2006

2 commits

28 Mar, 2006

1 commit