17 Nov, 2016

1 commit

  • Dan Carpenter reports that we're passing a pointer to a pointer
    here when we should just be passing a pointer. Pass the right
    pointer so that the of_clk_hw_onecell_get() sees the appropriate
    data pointer on its end.

    Reported-by: Dan Carpenter
    Cc: Stephen Boyd
    Cc: Uwe Kleine-König
    Fixes: 9337631f52a8 ("clk: efm32gg: Migrate to clk_hw based OF and registration APIs")
    Signed-off-by: Stephen Boyd

    Stephen Boyd
     

25 Aug, 2016

1 commit


03 Mar, 2016

1 commit


21 Jul, 2015

1 commit


10 Sep, 2014

1 commit

  • Since commit 54196ccbe0ba (of: consolidate linker section OF match table
    declarations) which went into 3.16-rc1 the following compiler warning is
    generated:

    In file included from drivers/clk/clk-efm32gg.c:12:0: include/linux/of.h:772:20:
    warning: comparison of distinct pointer types lacks a cast [enabled by default]
    .data = (fn == (fn_type)NULL) ? fn : fn }
    ^
    include/linux/of.h:785:3: note: in expansion of macro '_OF_DECLARE'
    _OF_DECLARE(table, name, compat, fn, of_init_fn_1)
    ^
    include/linux/clk-provider.h:545:42: note: in expansion of macro 'OF_DECLARE_1'
    #define CLK_OF_DECLARE(name, compat, fn) OF_DECLARE_1(clk, name, compat, fn)
    ^
    drivers/clk/clk-efm32gg.c:81:1: note: in expansion of macro 'CLK_OF_DECLARE'
    CLK_OF_DECLARE(efm32ggcmu, "efm32gg,cmu", efm32gg_cmu_init);
    ^

    Fix it by making efm32gg_cmu_init return void.

    Cc: Rob Herring
    Reported-by: Bryan Hundven
    Reviewed-by: Arnd Bergmann
    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Mike Turquette

    Uwe Kleine-König
     

05 Nov, 2013

1 commit