06 Nov, 2015
1 commit
-
There is a chip connected to i2c bus on Intel Galileo Gen2 board. Enable it via
ACPI ID INT3492.Cc: Thierry Reding
Signed-off-by: Andy Shevchenko
Signed-off-by: Thierry Reding
17 Aug, 2015
3 commits
-
Previously, period_ns and duty_ns were only used to determine the
ratio of ON and OFF time, the default frequency of 200 Hz was never
changed.
The PCA9685 however is capable of changing the PWM output frequency,
which is expected when changing the period.This patch configures the prescaler accordingly, using the formula
and notes provided in the PCA9685 datasheet.
Bounds checking for the minimum and maximum frequencies, last updated
in revision v.4 of said datasheet, is also added.The prescaler is only touched if the period changed, because we have to
put the chip into sleep mode to unlock the prescale register.
If it is changed, the PWM output frequency changes for all outputs,
because there is one prescaler per chip. This is documented in the
PCA9685 datasheet and in the comments.If the duty cycle is not changed at the same time as the period, then
we restart the PWM output using the duty cycle to period ratio from
before the period change.
When using LEDs for example, previously set brightness levels stay the
same when the frequency changes.Cc: Thierry Reding
Cc: Steffen Trumtrar
Signed-off-by: Clemens Gruber
Signed-off-by: Thierry Reding -
Problems:
- When duty_ns == period_ns, the full OFF bit was not cleared and the
PWM output of the PCA9685 stayed off.
- When duty_ns == period_ns and the catch-all channel was used, the
ALL_LED_OFF_L register was not cleared.
- The full ON bit was not cleared when setting the OFF time, therefore
the exact OFF time was ignored when setting a duty_ns < period_nsSolution: Clear both OFF registers when setting full ON and clear the
full ON bit when changing the OFF registers.Cc: Thierry Reding
Cc: Steffen Trumtrar
Signed-off-by: Clemens Gruber
Signed-off-by: Thierry Reding -
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Thierry Reding
11 Mar, 2015
1 commit
-
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Thierry Reding
27 Jun, 2013
1 commit
-
Current code actually does not set MODE1_SLEEP bit because the new value for
bitmask (0x1) is wrong. To set MODE1_SLEEP bit, we should pass MODE1_SLEEP
as the new value for bitmask.Signed-off-by: Axel Lin
Reviewed-by: Steffen Trumtrar
Signed-off-by: Thierry Reding
12 Jun, 2013
2 commits
-
Some drivers don't set the .owner fields of the struct device_driver or
struct pwm_ops, which causes the module usage count to become wrong.Signed-off-by: Thierry Reding
-
Add pwm driver for the NXP pca9685 16 channel pwm-led controller.
The driver is really barebones at this stage. E.g. the OE' pin and
therefore the corresponding registers are not supported.
The driver was tested on a HW where this pin is tied to GND.Signed-off-by: Steffen Trumtrar
[thierry.reding@gmail.com: style and whitespace cleanups]
Signed-off-by: Thierry Reding
