03 May, 2016
1 commit
-
Currently the PWM core mixes the current PWM state with the per-platform
reference config (specified through the PWM lookup table, DT definition
or directly hardcoded in PWM drivers).Create a struct pwm_args to store this reference configuration, so that
PWM users can differentiate between the current and reference
configurations.Patch all places where pwm->args should be initialized. We keep the
pwm_set_polarity/period() calls until all PWM users are patched to use
pwm_args instead of pwm_get_period/polarity().Signed-off-by: Boris Brezillon
[thierry.reding@gmail.com: reword kerneldoc comments]
Signed-off-by: Thierry Reding
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
28 Apr, 2014
1 commit
-
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.Signed-off-by: Jingoo Han
Signed-off-by: Thierry Reding
01 Apr, 2014
3 commits
-
The table is never modified and all OF functions that use it take a
const struct of_device_id *.Signed-off-by: Thierry Reding
-
Being an abbreviation, PWM should always be capitalized in prose.
Signed-off-by: Thierry Reding
-
This reverts commit 8468949cddcdbb1b1b1bc552aefceb252078ceb1.
The OF match table dummy for non-OF configurations cannot be removed
because it is still used by the pxa_pwm_get_id_dt() function.Signed-off-by: Thierry Reding
26 Feb, 2014
1 commit
-
Use of_match_ptr(), because of_match_ptr() returns NULL pointer
when CONFIG_OF is disabled.Signed-off-by: Jingoo Han
Signed-off-by: Thierry Reding
20 Dec, 2013
1 commit
-
Remove unnecessary space before tabs in order to fix the following
checkpatch warning.WARNING: please, no space before tabs
Signed-off-by: Jingoo Han
Signed-off-by: Thierry Reding
04 Dec, 2013
1 commit
-
This patch adds device tree support to the PXA's PWM driver. Nothing
needs to be extracted from the device tree node by the PWM device.
Client devices need only specify the period; the per-chip index is
implicitly zero because one device node must be present for each PWM
output in use. This approach is more convenient due to the wide
variability in the number of PWM channels present across the various PXA
variants, and is made possible by the fact that the register sets for
each PWM channel are segregated from each other. An of_xlate() method
is added to parse this single-cell node. The existing ID table is
reused for the match table data.Tested on a Palm Treo 680 (both platform data and DT cases).
Signed-off-by: Mike Dunn
Signed-off-by: Thierry Reding
03 Sep, 2013
1 commit
-
Commit 76abbdde2d95a3807d0dc6bf9f84d03d0dbd4f3d
pwm: Add sysfs interface
causes a kernel oops due to a null pointer dereference on PXA platforms.
This happens because the class added by the patch is registered in a
subsys_initcall (initcall4), but the pxa pwm driver is registered in
arch_initcall (initcall3). If the class is not registered before the
driver probe function runs, the oops occurs in device_add() when the
uninitialized pointers in struct class are dereferenced. I don't see a
reason that the driver must be an arch_initcall, so this patch makes it
a regular module_platform_driver (initcall6), preventing the oops.Signed-off-by: Mike Dunn
Acked-by: Robert Jarzmik
Acked-by: Marek Vasut
Signed-off-by: Thierry Reding
18 May, 2013
1 commit
-
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.Signed-off-by: Wolfram Sang
Acked-by: Stephen Warren
02 Apr, 2013
2 commits
-
PWM_ID_BASE() is not used after convert to PWM framework, remove it.
Also update driver_data field of struct platform_device_id accordingly.Signed-off-by: Axel Lin
Acked-by: Eric Miao
Signed-off-by: Thierry Reding -
clk_enable/clk_disable maintain an enable_count, clk_prepare and clk_unprepare
also maintain a prepare_count. These APIs will do prepare/enable when the first
user calling these APIs, and do disable/unprepare when the corresponding counter
reach 0. Thus We don't need to maintain a clk_enabled counter here.Signed-off-by: Axel Lin
Acked-by: Eric Miao
Signed-off-by: Thierry Reding
23 Jan, 2013
1 commit
-
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.Signed-off-by: Thierry Reding
Acked-by: Viresh Kumar
Signed-off-by: Greg Kroah-Hartman
29 Nov, 2012
3 commits
-
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.Signed-off-by: Bill Pemberton
Acked-by: Thierry Reding
Signed-off-by: Greg Kroah-Hartman -
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.Signed-off-by: Bill Pemberton
Acked-by: Thierry Reding
Signed-off-by: Greg Kroah-Hartman -
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.Signed-off-by: Bill Pemberton
Acked-by: Thierry Reding
Signed-off-by: Greg Kroah-Hartman
06 Oct, 2012
1 commit
-
Make sure the duty-cycle and period passed in are not negative. This
should eventually be made implicit by making them unsigned. While at
it, the drivers' .config() implementations can have the equivalent
checks removed.Signed-off-by: Thierry Reding
Cc: Shawn Guo
Cc: Mark Brown
Cc: Arnd Bergmann
Cc: Sachin Kamat
Cc: Axel Lin
Cc: Kukjin Kim
Cc: Jingoo Han
Cc: Jonghwan Choi
Cc: Sascha Hauer
Cc: "Philip, Avinash"
Cc: Vaibhav Bedia
Acked-by: Jingoo Han
23 Jul, 2012
2 commits
-
If the pwmchip_remove() call fails, propagate the error to the driver's
remove callback. This is required to prevent the module from being
unloaded if a PWM provided by the driver is still in use.Signed-off-by: Thierry Reding
-
Signed-off-by: Axel Lin
Signed-off-by: Thierry Reding
03 Jul, 2012
1 commit
-
This commit moves the PXA PWM driver to the drivers/pwm subdirectory and
converts it to use the new PWM framework.Signed-off-by: Thierry Reding