29 Nov, 2016
1 commit
-
Make sure to drop the reference to the parent device taken by
class_find_device() after "unexporting" any children when deregistering
a PWM chip.Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal")
Signed-off-by: Johan Hovold
Signed-off-by: Thierry Reding
05 Sep, 2016
1 commit
-
Exported pwm channels aren't removed before the pwmchip and are
leaked. This results in invalid sysfs files. This fix removes
all exported pwm channels before chip removal.Signed-off-by: David Hsu
Fixes: 76abbdde2d95 ("pwm: Add sysfs interface")
Signed-off-by: Thierry Reding
25 Jul, 2016
1 commit
10 Jun, 2016
2 commits
-
Allow a user to read PWM capture results from sysfs. To start a capture
and read the result, simply read the file:$ cat $PWMCHIP/capture
The output format is " ".
Signed-off-by: Lee Jones
Signed-off-by: Thierry Reding -
This patch adds to check the return value from pwm_apply_state()
used in enable_store(). The error of enable_store() doesn't work
if the return value doesn't received.Signed-off-by: Ryo Kodama
Signed-off-by: Yoshihiro Shimoda
Fixes: 39100ceea79f ("pwm: Switch to the atomic API")
Signed-off-by: Thierry Reding
17 May, 2016
2 commits
-
Replace legacy pwm_get/set_xxx() and pwm_config/enable/disable() calls
by pwm_get/apply_state().Signed-off-by: Boris Brezillon
Signed-off-by: Thierry Reding -
PWM devices are not protected against concurrent accesses. The lock in
struct pwm_device might let PWM users think it is, but it's actually
only protecting the enabled state.Removing this lock should be fine as long as all PWM users are aware
that accesses to the PWM device have to be serialized, which seems to be
the case for all of them except the sysfs interface. Patch the sysfs
code by adding a lock to the pwm_export struct and making sure it's
taken for all relevant accesses to the exported PWM device.Signed-off-by: Boris Brezillon
Signed-off-by: Thierry Reding
10 Nov, 2015
2 commits
-
For the npwm property the PWM sysfs interface already made use of the
DEVICE_ATTR_RO macro. This patch expands this to the other sysfs
properties so that the code base is concise and makes use of this
helpful macro.This has the advantage of slightly reducing the code size, improving
readability and no longer using magic values for permissions.Signed-off-by: Olliver Schinagl
Signed-off-by: Thierry Reding -
Use the result of pwm_is_enabled() directly instead of storing it in a
temporary variable.Signed-off-by: Olliver Schinagl
Signed-off-by: Thierry Reding
27 Jul, 2015
2 commits
-
Padding initializers so that assignment operators align is bound to lead
to inconsistencies or churn. Single spaces around the assignment is just
fine.Signed-off-by: Thierry Reding
-
The current code will check for polarity in a boolean way. While it is
correct that polarity is either normal or inversed, make it more obvious
that it's an enumeration by using a switch statement and explicit
matches on the enumeration values.Signed-off-by: Thierry Reding
20 Jul, 2015
2 commits
-
Use the pwm_get_xxx() helpers instead of directly accessing the fields
in struct pwm_device. This will allow us to smoothly move to the atomic
update approach.Signed-off-by: Boris Brezillon
Signed-off-by: Thierry Reding -
Some PWM drivers are testing the PWMF_ENABLED flag. Create a helper
function to hide the logic behind enabled test. This will allow us to
smoothly move from the current approach to an atomic PWM update
approach.Signed-off-by: Boris Brezillon
Signed-off-by: Thierry Reding
04 Dec, 2013
1 commit
-
Use new ATTRIBUTE_GROUPS macro to reduce the number of lines of code.
Signed-off-by: Axel Lin
Signed-off-by: Thierry Reding
29 Jul, 2013
1 commit
-
The dev_attrs field of struct class is going away soon, dev_groups
should be used instead. This converts the PWM class code to use the
correct field.Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Thierry Reding
21 Jun, 2013
1 commit
-
Add a simple sysfs interface to the generic PWM framework.
/sys/class/pwm/
`-- pwmchipN/ for each PWM chip
|-- export (w/o) ask the kernel to export a PWM channel
|-- npwm (r/o) number of PWM channels in this PWM chip
|-- pwmX/ for each exported PWM channel
| |-- duty_cycle (r/w) duty cycle (in nanoseconds)
| |-- enable (r/w) enable/disable PWM
| |-- period (r/w) period (in nanoseconds)
| `-- polarity (r/w) polarity of PWM (normal/inversed)
`-- unexport (w/o) return a PWM channel to the kernelBased on work by Lars Poeschel.
Signed-off-by: H Hartley Sweeten
Cc: Thierry Reding
Cc: Lars Poeschel
Cc: Ryan Mallon
Cc: Rob Landley
Signed-off-by: Thierry Reding
