24 Mar, 2015
1 commit
-
Replace duplicated const keyword for 'sampleclock_sources' with proper
array of const pointers to const strings.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Takashi Iwai
29 Jan, 2015
1 commit
-
Signed-off-by: Takashi Iwai
19 Jan, 2015
1 commit
-
No functional change, refactoring with the standard helpers.
Signed-off-by: Takashi Iwai
04 Jan, 2015
1 commit
-
The iounmap() function performs also input parameter validation.
Thus the test around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Takashi Iwai
02 Jan, 2015
1 commit
-
snd_asihpi_hpi_new() takes a pointer to a pointer of a hwdep where if this
parameter is provided the newly allocated hwdep is stored. All callers pass
NULL though, so remove the parameter. This makes the code a bit cleaner and
shorter.Signed-off-by: Lars-Peter Clausen
Signed-off-by: Takashi Iwai
31 Dec, 2014
1 commit
-
Add missing limits to keep copied data within allocated buffer.
Reported-by: Dan Carpenter
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai
18 Dec, 2014
3 commits
-
This corresponds with updated asihpi firmware in alsa-firmware repo
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Increase size allocated for PAD (programme associated data) control.
This is used by newer tuner products.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Some products firmware is no longer being updated
e.g. dsp5000, dsp8700 but it should continue to work
with updated HPI versions.
Avoid regression by allowing this firmware to be loaded as
long as major version is the same.
Warn about mismatching versions, as matching versions are
preferred.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai
03 Dec, 2014
1 commit
-
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Takashi Iwai
23 Nov, 2014
10 commits
-
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Only determining if low latency mode is enabled. Failure
indicates adapter has no modesSigned-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Prevents spewing of useless messages if app keeps trying to
access the card.Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Some cards have a so-called low-latency mode, in which they present
a single multichannel stream with no mixing or samplerate conversion.
In this mode the card can generate an interrupt per internal processing
block (typically 32 or 64 frames)Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Audio cards wth have AVB or BLU Link IO.
Tuner card with DAB receiverSigned-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai -
Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai
10 Nov, 2014
1 commit
-
Add a new helper function snd_pcm_stop_xrun() to the standard sequnce
lock/snd_pcm_stop(XRUN)/unlock by a single call, and replace the
existing open codes with this helper.The function checks the PCM running state to prevent setting the wrong
state, too, for more safety.Signed-off-by: Takashi Iwai
21 Oct, 2014
1 commit
-
... and reduce the open codes.
Signed-off-by: Takashi Iwai
13 Aug, 2014
1 commit
-
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines. This issue was reported by checkpatch.A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/)://
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;//
[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine
Signed-off-by: Bjorn Helgaas
31 Mar, 2014
1 commit
-
This used to be a part of a condition until f3d145aac913 ('ALSA: asihpi:
MMAP for non-busmaster cards') but now it's not and we can remove an
indent level.Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai
12 Feb, 2014
1 commit
-
Also remove superfluous snd_card_set_dev() calls.
Signed-off-by: Takashi Iwai
13 Sep, 2013
1 commit
-
These ->put() functions are called from snd_ctl_elem_write() with user
supplied data. snd_asihpi_tuner_band_put() is missing a limit check and
the check in snd_asihpi_clksrc_put() can underflow.Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai
16 Jul, 2013
1 commit
-
snd_pcm_stop() must be called in the PCM substream lock context.
Cc:
Signed-off-by: Takashi Iwai
28 Jun, 2013
1 commit
-
The char arrays with size 44 are for the name string of
snd_ctl_elem_id. Define the constant and replace the raw numbers with
it for clarifying better.Signed-off-by: Takashi Iwai
29 May, 2013
1 commit
-
As drvdata is cleared to NULL at probe failure or at removal by the
driver core, we don't have to call pci_set_drvdata(pci, NULL) any
longer in each driver.The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
hda_intel.c. Since this function itself releases the card instance,
we need to clear drvdata here as well, so that it won't be released
doubly in the remove callback.Signed-off-by: Takashi Iwai
29 Apr, 2013
2 commits
-
Some Asihpi formats are not supported or invalid, and their mapping to
ALSA format is set to -1.
Before performing the format conversion into ALSA bitwise formats,
add a consistency check for the requested format, as done in
snd_card_asihpi_playback_formats().Compile tested only.
Signed-off-by: Eldad Zack
Signed-off-by: Takashi Iwai -
Add a function to handle conversion from snd_pcm_format_t
to bitwise with proper typing.Change such conversions to use this function and silence sparse
warnings.Signed-off-by: Eldad Zack
Signed-off-by: Takashi Iwai
12 Mar, 2013
1 commit
-
The dereference should be moved below the NULL test.
Signed-off-by: Wei Yongjun
Signed-off-by: Takashi Iwai
07 Dec, 2012
1 commit
-
CONFIG_HOTPLUG is going away as an option. As result the __dev*
markings will be going away.Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.Signed-off-by: Bill Pemberton
Signed-off-by: Takashi Iwai
28 Oct, 2012
1 commit
-
dev_ calls take less code than dev_printk(KERN_
and reducing object size is good.
Coalesce multiline formats for easier grep.
Coalesce segmented single line formats too.Signed-off-by: Joe Perches
Signed-off-by: Takashi Iwai
06 Oct, 2012
1 commit
-
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)//
@r1@
statement S;
position p,p1;
@@
S@p1;@p@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
//Signed-off-by: Peter Senna Tschudin
Signed-off-by: Takashi Iwai
15 Aug, 2012
1 commit
-
Otherwise we may get compile warnings due to unused functions.
Signed-off-by: Takashi Iwai
07 Apr, 2012
1 commit
-
ASoC: fixes for 3.4
A bunch of driver-specific fixes and one generic fix for the new support
for platform DAPM contexts - we were picking the wrong default for the
idle_bias_off setting which was meaning we weren't actually achieving
any useful runtime PM on platform devices.
31 Mar, 2012
1 commit
-
Pull sound fixes from Takashi Iwai:
"A collection of small fixes for 3.4-rc1, including
- mic-recording regression fix for Realtek codec
- clean-up of dmaengine parameter mess
- WM8894 calibration tweak
- minor fixes for asihpi and some bool module parms"* tag 'sound-3.4' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound:
ALSA: fix isa/opti9xx module param type
sound: fix oss/msnd_pinnacle module param type
ALSA: asihpi - fix return type of hpios_locked_mem_alloc()
ASoC: dmaengine_pcm: use dmaengine cyclic wrapper
ASoC: Add extra parameter to device_prep_dma_cyclic
ALSA: hda/realtek - Fix ADC assignment with a shared HP/Mic pin
ASoC: wm8994: Update WM8994 DCS calibration
30 Mar, 2012
1 commit
-
Make this function consistent with others in this module by
returning 1 for error, instead of -ENOMEM
(reverts function signature change from a938fb1e)Signed-off-by: Eliot Blennerhassett
Signed-off-by: Takashi Iwai
29 Mar, 2012
1 commit
-
Remove all #inclusions of asm/system.h preparatory to splitting and killing
it. Performed with the following command:perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *`
Signed-off-by: David Howells
