Eric Lee / smarc-fsl-linux-kernel

11 Jan, 2015

1 commit

09 Jan, 2015

1 commit

  • 7247aabd5   ALSA: ctxfi: Simplify PM callbacks ... Browse Code »

    This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801:
    PCI core handles power state for us].

    Since pci_set_power_state(), pci_save_state() and pci_restore_state()
    are already done in the PCI core side, so we don't need to it doubly.

    Also, pci_enable_device(), pci_disable_device() and pci_set_master()
    calls in PM callbacks are superfluous nowadays, too, so get rid of
    them as well.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

04 Jan, 2015

1 commit

04 Dec, 2014

1 commit

  • 5395103dc   ALSA: ctxfi: Neaten get_daio_rsc ... Browse Code »

    Move the pointer declarations into the blocks that use them.
    Neaten the kfree calls when the _init functions fail.

    Trivially reduces object size (defconfig x86-64)

    $ size sound/pci/ctxfi/ctdaio.o.*
    text data bss dec hex filename
    5287 224 0 5511 1587 sound/pci/ctxfi/ctdaio.o.new
    5319 224 0 5543 15a7 sound/pci/ctxfi/ctdaio.o.old

    Signed-off-by: Joe Perches
    Noticed-by: Markus Elfring
    Signed-off-by: Takashi Iwai

    Joe Perches
     

29 Oct, 2014

1 commit

21 Oct, 2014

1 commit

  • cf6814f2b   ALSA: ctxfi: remove unused variable ... Browse Code »

    As of now the pointer to struct dai is not being used anywhere in the
    function. So it is safe to remove the variable.
    If we are ever doing anything with the container_of(daio, struct dai, daio),
    then at that time we can again add the variable.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     

30 Sep, 2014

6 commits

  • 0cae90a96   ALSA: ctxfi: pr_* replaced with dev_* ... Browse Code »

    pr_* macros replaced with dev_* as they are more preffered over pr_*.
    each file which had pr_* was reviewed manually and replaced with dev_*.
    here we have actually used the various snd_card which was added to some
    structures of ctxfi via a previous patch of this series.

    in the ctvmem.c file we have passed a reference of ct_atc as an
    argument to get_vm_block function so that it can be used from
    dev_*.

    since dev_* will print the device information , so the prefix of
    "ctxfi" from the various pr_* were also removed.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     
  • a45c4d514   ALSA: ctxfi: ctatc: added reference to snd_card ... Browse Code »

    added reference of the card in the convert_format function
    so that we can know which card has called the function.
    this reference of the snd_card will actually be used in a later patch
    to convert the pr_* macro to dev_*.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     
  • e5347f9ab   ALSA: ctxfi: initialized snd_card ... Browse Code »

    initialized the reference of snd_card which was added to the various
    structures through the previous patch of the series.
    these references of snd_card will be used in a later patch to convert
    the pr_* macros to dev_*

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     
  • 3d0fdc86e   ALSA: ctxfi: added reference of snd_card ... Browse Code »

    added a pointer of snd_card in some of the structures to get a
    reference of the card from other functions.
    these references of snd_card will be initialised in the next patch
    of this series and as of now these snd_card will be used to print the
    the device information when we convert the pr_* macros to dev_* in a
    later patch of this series.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     
  • b6bfe86fd   ALSA: ctxfi: removed typecast to (struct hw *) ... Browse Code »

    the previous patch of the series has converted the void * to
    struct hw * . Now this patch removes the typecasting to (struct hw *)
    which is not needed any more.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     
  • 66640898e   ALSA: ctxfi: changed void * to struct hw * ... Browse Code »

    in the code we have void *hw and while using we are always typecasting
    it to (struct hw *). it is better to use void type of pointer when we
    store different types of pointer , but in this code we are only having
    struct hw.
    So changed all the relevant reference of void *hw to struct hw *hw,
    without any modification of the existing code logic.
    the next patch of the series will remove the typecasting which is
    not required now.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     

23 Sep, 2014

1 commit

  • 7a7686bd0   ALSA: ctxfi: sparse warning ... Browse Code »

    fixed sparse warning of incorrect type (different address spaces) in
    cthw20k1.c and cthw20k2.c which was being actually caused as mem_base
    was of the type unsigned long.

    Again as mem_base was previously unsigned long , so it required many
    typecasts in the code to convert interger to pointer.

    Now after giving the correct type of mem_base as void __iomem *
    we can also remove those typecasts maintaining the same functionality
    and logic of the code.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     

11 Sep, 2014

1 commit

29 Aug, 2014

1 commit

  • 521bd5e4d   Merge tag 'sound-3.17-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound ... Browse Code »

    Pull sound fixes from Takashi Iwai:
    "Here contains not many exciting changes but just a few minor ones: An
    off-by-one proc write fix, a couple of trivial incldue guard fixes,
    Acer laptop pinconfig fix, and a fix for DSD formats that are still
    rarely used"

    * tag 'sound-3.17-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound:
    ALSA: hda - Set up initial pins for Acer Aspire V5
    ALSA: pcm: Fix the silence data for DSD formats
    ALSA: ctxfi: ct20k1reg: Fix typo in include guard
    ALSA: hda: ca0132_regs.h: Fix typo in include guard
    ALSA: core: fix buffer overflow in snd_info_get_line()

    Linus Torvalds
     

26 Aug, 2014

2 commits

  • 62afa853c   ALSA: ctxfi: fix broken user-visible string ... Browse Code »

    as broken user-visible strings breaks the ability to grep for them , so this patch fixes the broken user-visible strings

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     
  • e720b8202   ALSA: ctxfi: prink replacement ... Browse Code »

    as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_err and pr_alert
    this patch will generate a warning from checkpatch for an unnecessary space before new line and has not been fixed as this patch is only for printk replacement.

    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     

25 Aug, 2014

1 commit

22 Aug, 2014

1 commit

13 Aug, 2014

1 commit

  • 9baa3c34a   PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use ... Browse Code »

    We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
    meet kernel coding style guidelines. This issue was reported by checkpatch.

    A simplified version of the semantic patch that makes this change is as
    follows (http://coccinelle.lip6.fr/):

    //

    @@
    identifier i;
    declarer name DEFINE_PCI_DEVICE_TABLE;
    initializer z;
    @@

    - DEFINE_PCI_DEVICE_TABLE(i)
    + const struct pci_device_id i[]
    = z;

    //

    [bhelgaas: add semantic patch]
    Signed-off-by: Benoit Taine
    Signed-off-by: Bjorn Helgaas

    Benoit Taine
     

12 Feb, 2014

1 commit

10 Jan, 2014

1 commit

  • e240a4696   ALSA: ctxfi - Work around emu20k1 glitch to prevent buffered sound data loss ... Browse Code »

    Occasionally, on playback stream ringbuffer wraparound, the EMU20K1
    hardware will momentarily return 0 instead of the proper current(loop)
    address. This patch handles that case, fixing the problem of playback
    position corruption and subsequent loss of buffered sound data, that
    occurs with some common buffering layout patterns(e.g. multiple
    simultaneous output streams with differently-sized or
    non-power-of-2-sized buffers).

    An alternate means of fixing the problem would be to read the ca
    register continuously, until two sequential reads return the same
    value; however, that would be a more invasive change, has performance
    implications, and isn't necessary unless there are also issues with the
    value not being updated atomically in regards to individual bits or
    something similar(which I have not encountered through light testing).

    I have no EMU20K2 hardware to confirm if the issue is present there,
    but even if it's not, this change shouldn't break anything that's not
    already broken.

    Signed-off-by: Sarah Bessmer
    Signed-off-by: Takashi Iwai

    Sarah Bessmer
     

06 Nov, 2013

1 commit

13 Sep, 2013

1 commit

29 May, 2013

1 commit

  • 20a24225d   ALSA: PCI: Remove superfluous pci_set_drvdata(pci, NULL) at remove ... Browse Code »

    As drvdata is cleared to NULL at probe failure or at removal by the
    driver core, we don't have to call pci_set_drvdata(pci, NULL) any
    longer in each driver.

    The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
    hda_intel.c. Since this function itself releases the card instance,
    we need to clear drvdata here as well, so that it won't be released
    doubly in the remove callback.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

07 Dec, 2012

1 commit

  • e23e7a143   ALSA: pci: remove __dev* attributes ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Signed-off-by: Bill Pemberton
    Signed-off-by: Takashi Iwai

    Bill Pemberton
     

13 Sep, 2012

1 commit

  • 7b31d0095   ALSA: Define more channel map positions ... Browse Code »

    For following the standard, define more channel map positions and
    shuffle the items a bit:

    - As both PulseAudio and gstreamer define MONO channel position
    explicitly, we should follow that, too. The mono streams point to
    this channel position unless they are explicitly assigned to certain
    channel positions.

    - Top-front-* and Top-rear-* positions are added, carried from
    PulseAudio's definitions.

    - Move NA and MONO definitions at the top of table right after
    UNKNOWN, since these are more abstract in comparison with other
    practical positions.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

12 Sep, 2012

1 commit

07 Sep, 2012

1 commit

21 Aug, 2012

1 commit

20 Aug, 2012

1 commit

  • 4d8ce1c99   ALSA: sound/pci/ctxfi/ctatc.c: fix error return code ... Browse Code »

    Initialize err before returning on failure, as done elsewhere in the
    function.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    (
    if@p1 (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret@p1 = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }

    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai

    Julia Lawall
     

15 Aug, 2012

1 commit

03 Jul, 2012

1 commit

24 Apr, 2012

1 commit

24 Feb, 2012

1 commit

19 Dec, 2011

1 commit

  • a67ff6a54   ALSA: module_param: make bool parameters really bool ... Browse Code »

    module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

06 Dec, 2011

1 commit

  • 1d5d37f40   ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array ... Browse Code »

    The advantage of kcalloc is, that will prevent integer overflows which could
    result from the multiplication of number of elements and size and it is also
    a bit nicer to read.

    The semantic patch that makes this change is available
    in https://lkml.org/lkml/2011/11/25/107

    Signed-off-by: Thomas Meyer
    Signed-off-by: Takashi Iwai

    Thomas Meyer
     

01 Nov, 2011

1 commit

24 Aug, 2011

1 commit

  • 391e69143   ALSA: ctxfi: Bump playback substreams to 256 ... Browse Code »

    There are references in the code to 256 sources, so I tested it with 256 aplays,
    of which the first and last with real data and the rest playing /dev/zero .

    Also increase amount of page tables, so the default aplay size works.

    Signed-off-by: Maarten Lankhorst
    Signed-off-by: Takashi Iwai

    Maarten Lankhorst
     

16 Jun, 2011

1 commit