04 Jan, 2015
1 commit
-
The iounmap() function performs also input parameter validation.
Thus the test around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Takashi Iwai
10 Dec, 2014
1 commit
-
"card" is NULL if snd_card_new() fails.
Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai
17 Nov, 2014
1 commit
-
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Takashi Iwai
13 Aug, 2014
1 commit
-
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines. This issue was reported by checkpatch.A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/)://
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;//
[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine
Signed-off-by: Bjorn Helgaas
21 May, 2014
1 commit
-
Signed-off-by: Toralf Förster
Signed-off-by: Takashi Iwai
05 Mar, 2014
1 commit
-
"chip" is NULL here. We don't need a printk here because kmalloc() has
it built in.Signed-off-by: Dan Carpenter
Signed-off-by: Takashi Iwai
26 Feb, 2014
1 commit
-
Convert with dev_err() and co from snd_printk(), etc.
Signed-off-by: Takashi Iwai
12 Feb, 2014
1 commit
-
Also remove superfluous snd_card_set_dev() calls.
Signed-off-by: Takashi Iwai
29 Oct, 2013
1 commit
-
The FUNCTION_TYPE parameter isn't associated with any NID, thus
showing the uninitialized nid in the error message is simply
nonsense.Spotted by coverity CID 145068.
Signed-off-by: Takashi Iwai
29 May, 2013
1 commit
-
As drvdata is cleared to NULL at probe failure or at removal by the
driver core, we don't have to call pci_set_drvdata(pci, NULL) any
longer in each driver.The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
hda_intel.c. Since this function itself releases the card instance,
we need to clear drvdata here as well, so that it won't be released
doubly in the remove callback.Signed-off-by: Takashi Iwai
07 Dec, 2012
1 commit
-
CONFIG_HOTPLUG is going away as an option. As result the __dev*
markings will be going away.Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.Signed-off-by: Bill Pemberton
Signed-off-by: Takashi Iwai
24 Apr, 2012
1 commit
-
Signed-off-by: Takashi Iwai
19 Dec, 2011
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Signed-off-by: Rusty Russell
Signed-off-by: Takashi Iwai
01 Nov, 2011
1 commit
-
The implicit presence of module.h lured several users into
incorrectly thinking that they only needed/used modparam.h
but once we clean up the module.h presence, these will show
up as build failures, so fix 'em now.Signed-off-by: Paul Gortmaker
24 Jun, 2011
1 commit
-
- add/fix comments and debug messages
- fix incomplete matrix init
- comment out creation of buggy lola_dest_gain_mixer controls
- minor optimisationsSigned-off-by: Markus Bollinger
Signed-off-by: Takashi Iwai
17 Jun, 2011
1 commit
15 Jun, 2011
1 commit
-
Add missing __devinit.
Signed-off-by: Takashi Iwai
10 Jun, 2011
2 commits
-
The name argument of request_irq() appears in /proc/interrupts, and
it's quite ugly when the name entry contains a space or special letters.
In general, it's simpler and more readable when the module name appears
there, so let's replace all entries with KBUILD_MODNAME.Signed-off-by: Takashi Iwai
-
The convention for pci_driver.name entry in kernel drivers seem to be
the module name or equivalent ones. But, so far, almost all PCI sound
drivers use more verbose name like "ABC Xyz (12)", and these are fairly
confusing when appearing as a file name.This patch converts the all pci_driver.name entries in sound/pci/* to
use KBUILD_MODNAME for more unified appearance.Signed-off-by: Takashi Iwai
05 May, 2011
1 commit
-
sound/pci/lola/Makefile was trying to build lola modules even
when PCI and SND_LOLA were not enabled, causing build errors:ERROR: "snd_pcm_hw_constraint_step" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_period_elapsed" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_dma_alloc_pages" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_hw_constraint_integer" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_sgbuf_ops_page" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_set_ops" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_lib_free_pages" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_lib_ioctl" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_lib_malloc_pages" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_sgbuf_get_chunk_size" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_dma_free_pages" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_lib_preallocate_pages_for_all" [sound/pci/lola/snd-lola.ko] undefined!
ERROR: "snd_pcm_new" [sound/pci/lola/snd-lola.ko] undefined!Fix the Makefile to build only when CONFIG_SND_LOLA is enabled.
Signed-off-by: Randy Dunlap
Signed-off-by: Takashi Iwai
04 May, 2011
2 commits
-
Signed-off-by: Takashi Iwai
-
Signed-off-by: Takashi Iwai
03 May, 2011
13 commits
-
Also protect the call of lola_update_rirb() with spinlock.
Signed-off-by: Takashi Iwai
-
Renamed to Digial SRC Capture Switch for more correct representation.
Also fixed analog volume control on Lola161611 and lola881.Signed-off-by: Takashi Iwai
-
For assuring the synchronized state with the pause operation,
loop over the all linked streams and waits until all get ready
in a loop.Signed-off-by: Takashi Iwai
-
Added the refcounting for the exclusive SRC control.
Also, fixed the possible stall after PCM pause operations.Signed-off-by: Takashi Iwai
-
Add some sanity checks.
Change PCM parameters appropriately per granularity.Signed-off-by: Takashi Iwai
-
Completely switch to SG-buffer now, as it's working stably.
Signed-off-by: Takashi Iwai
-
Added granularity and sample_rate_min module options.
The former controls the h/w access granularity. As default, it's set
to the max value 32.The latter controls the minimum sample rate in Hz, as default 16000.
Signed-off-by: Takashi Iwai
-
Signed-off-by: Takashi Iwai
-
Use a single BDL for both buffers instead of allocating for each.
Also a few tune-up to avoid the stream stalls in the PCM code and
the prelimianry work for SG-buffer support are added, too.Signed-off-by: Takashi Iwai
-
Use snd_printdd() for less important debug messages.
Signed-off-by: Takashi Iwai
-
The codec proc file becomes a read only that shows the codec widgets
in a text form. A new proc file, codec_rw, is introduced instead for
accessing the Lola verb directly by reading and writing to it.Also, regs proc file shows the contents of DSD, too.
Signed-off-by: Takashi Iwai
-
Make lola_sample_rate_convert() global so that it can be accessed from
other files.Signed-off-by: Takashi Iwai
-
Added a new driver for supporting Digigram Lola PCI-e boards.
Lola has a similar h/w design like HD-audio but with extended verbs.
Thus the driver is written similarly like HD-audio driver in the bus
part. The codec part is rather written in a fixed way specific to the
Lola board because of the verb incompatibility.The driver provides basic PCM, supporting multi-streams and mixing.
Signed-off-by: Takashi Iwai