17 Aug, 2015
1 commit
-
commit 412efa73dcd3bd03c1838c91e094533a95529039 upstream.
The usage_count variable was read before it was set to the correct
value, due to which the firmware load was failing. Because of this
IPC messages sent to the firmware were timing out causing a delay
of about 1 second while playing audio from the internal speakers.With this patch the usage_count is read after the function call
pm_runtime_get_sync which will increment the usage_count variable
and the firmware load is successful and all the IPC messages are
processed correctly.Signed-off-by: Shilpa Sreeramalu
Signed-off-by: Fang, Yang A
Signed-off-by: Mark Brown
Signed-off-by: Greg Kroah-Hartman
23 Apr, 2015
1 commit
-
The tom code should be using SND_SST_MFLD_PLATFORM and not the baytrail one.
So fix it nowSigned-off-by: Vinod Koul
Signed-off-by: Mark Brown
17 Apr, 2015
1 commit
-
It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.Signed-off-by: Wei Yongjun
Acked-by: Jarkko Nikula
Signed-off-by: Mark Brown
16 Apr, 2015
1 commit
-
kbuild robot reports following warning:
"sound/soc/intel/haswell/sst-haswell-ipc.c:2204:1-6:
WARNING: invalid free of devm_ allocated data"As julia explains to me, the memory allocated with devm_kalloc
is freed automatically on failure of a probe function. So this
kfree should be removed otherwise the double free will be got in
error handler path.Signed-off-by: Jin Yao
Signed-off-by: Mark Brown
13 Apr, 2015
4 commits
-
ASoC: Changes for v4.1
A selection of changes for v4.1 so far. The main things are:
- Move of jack registration to the card where it belongs.
- Support for DAPM routes specified by both the machine driver and DT.# gpg: Signature made Thu 05 Mar 2015 01:10:27 GMT using RSA key ID 5D5487D0
# gpg: WARNING: digest algorithm MD5 is deprecated
# gpg: please see https://gnupg.org/faq/weak-digest-algos.html for more information
# gpg: Oops: keyid_from_fingerprint: no pubkey
# gpg: Good signature from "Mark Brown "
# gpg: aka "Mark Brown "
# gpg: aka "Mark Brown "
# gpg: aka "Mark Brown "
# gpg: aka "Mark Brown "
# gpg: aka "Mark Brown " -
sound/soc/intel/haswell/sst-haswell-ipc.c:646:28-29: WARNING: Use ARRAY_SIZE
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element
Semantic patch information:
This makes an effort to find cases where ARRAY_SIZE can be used such as
where there is a division of sizeof the array by the sizeof its first
element or by any indexed element or the element type. It replaces the
division of the two sizeofs by ARRAY_SIZE.Generated by: scripts/coccinelle/misc/array_size.cocci
CC: Jie Yang
Signed-off-by: Fengguang Wu
Signed-off-by: Mark Brown
11 Apr, 2015
3 commits
-
Use the generic IPC/mailbox APIs to replace the original processing
code for Broadwell platform.Signed-off-by: Jin Yao
Acked-by: Jie Yang
Signed-off-by: Mark Brown -
Use the generic IPC/mailbox APIs to replace the original processing
code for Baytrail platform.Signed-off-by: Jin Yao
Acked-by: Jie Yang
Signed-off-by: Mark Brown -
Currently in Intel SST driver, some similar IPC/mailbox processing
code are used in different platforms (e.g. in baytrail/broadwell).This patch extracts the common code and creates new files
(sst-ipc.c/sst-ipc.h) to contain the common code and provide the generic
APIs for IPC/mailbox processing.Signed-off-by: Jin Yao
Acked-by: Jie Yang
Signed-off-by: Mark Brown
09 Apr, 2015
2 commits
-
My static checker complains about these because it looks like the
multiply can overflow and then we cast to a larger data type. I don't
think this is a problem, but it's also harmless to do the cast earlier
so let's silence the static checker warning.Signed-off-by: Dan Carpenter
Signed-off-by: Mark Brown -
these functions were never called by anyone.
Signed-off-by: Sudip Mukherjee
Signed-off-by: Mark Brown
08 Apr, 2015
1 commit
-
0day robot reported a buffer overflow issue:
...
sound/soc/intel/haswell/sst-haswell-pcm.c:1107 hsw_pcm_probe() error: buffer\
overflow 'hsw_dais' 4
Signed-off-by: Mark Brown
07 Apr, 2015
6 commits
-
Signed-off-by: Fengguang Wu
Signed-off-by: Mark Brown -
Restructure the sound/soc/intel/ directory: create atom folder, and move
sst atom platform files here.Signed-off-by: Jie Yang
Acked-by: Vinod Koul
Signed-off-by: Mark Brown -
Restructure the sound/soc/intel/ directory: create baytrail folder, and move
sst baytrail platform files here.Signed-off-by: Jie Yang
Acked-by: Jarkko Nikula
Tested-by: Jarkko Nikula
Signed-off-by: Mark Brown -
Restructure the sound/soc/intel/ directory: create boards folder, and move
sst boards files here.Signed-off-by: Jie Yang
Acked-by: Vinod Koul
Acked-by: Jarkko Nikula
Tested-by: Jarkko Nikula
Signed-off-by: Mark Brown -
Restructure the sound/soc/intel/ directory: create haswell folder, and
move haswell platform files here.Signed-off-by: Jie Yang
Reviewed-by: Liam Girdwood
Signed-off-by: Mark Brown -
Restructure the sound/soc/intel/ directory: create common folder, and move
sst common files here.Signed-off-by: Jie Yang
Acked-by: Jarkko Nikula
Tested-by: Jarkko Nikula
Signed-off-by: Mark Brown
28 Mar, 2015
1 commit
-
The smatch tool report warning:
...
CHECK sound/soc/intel/sst-haswell-pcm.c
sound/soc/intel/sst-haswell-pcm.c:1110 hsw_pcm_probe() error: buffer overflow\
'hsw_dais' 4
Acked-by: Jie Yang
Signed-off-by: Mark Brown
23 Mar, 2015
1 commit
-
During probe, the Baytrail audio driver reports errors such as:
[44.172040] baytrail-pcm-audio baytrail-pcm-audio: error: invalid DMA engine 0
[44.172137] baytrail-pcm-audio baytrail-pcm-audio: sst_dma_new failedThose error messages are misleading, there is no error since the DMA
is explicitly not configured for Baytrail.
Add a test to remove DMA error checks when DMA is not configured
and return silently.Acked-by: Liam Girdwood
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Mark Brown
19 Mar, 2015
2 commits
-
Fix the sst_acpi_probe memory allocation error path by setting right error
code and initiating the cleanup insteadof just returningReported-by: Dan Carpenter
Signed-off-by: Vinod Koul
Signed-off-by: Mark Brown -
Check waves state before set parameter through ipc to prevent unexpected
operation. Also remove redundant check.Signed-off-by: Lu, Han
Signed-off-by: Mark Brown
18 Mar, 2015
2 commits
-
Intel MID DMA driver is going to be removed, commit should be a few lines
down near to dmaengine_slave_config() call in order to not confuse and at
quick look Synopsys DesignWare does seem to use some of the slave config
structure fields (see drivers/dma/dw/core.c: dwc_config()).Signed-off-by: Jarkko Nikula
Signed-off-by: Mark Brown -
Intel MID DMA driver is going to be removed by the coming commit
36111da7838e ("dmaengine: intel-mid-dma: remove the driver") in spi.git
tree. Since there are no users for SST_DMA_TYPE_MID type the support for it
can be removed from here in advance.Signed-off-by: Jarkko Nikula
Signed-off-by: Mark Brown
17 Mar, 2015
3 commits
-
The jack creation code was in rt5670 codec driver before due to the
jack resources (gpio/irq) were defined under the node of codec device
in ACPI on Braswell. We used the snd_soc_jack_new() to create a jack
instance.But now snd_soc_jack_new() is removed from upstream and we can't
use snd_soc_card_jack_new() in codec driver, so we move the jack
creation code to machine driver and pass the jack instance to codec
driver for further processing.Signed-off-by: Bard Liao
Signed-off-by: Jin Yao
Signed-off-by: Mark Brown -
On Braswell, we need to add some machine specific setting before suspend
and after resume. For example, disable/enable jack detection in codec so
use snd_soc_card suspend_pre and resume_post ops for this purpose.Signed-off-by: Jin Yao
Signed-off-by: Mark Brown -
…ie/sound into asoc-intel
16 Mar, 2015
1 commit
13 Mar, 2015
3 commits
-
Each kcontrol command includes a line of parameters up to 128 bytes.
kcontrol command to set param:
cset "name='Waves Set Param' "
or
cset-bin-file "name='Waves Set Param' "The parameter lines are stored in a buffer array, so can be read back from
buffer rather than from DSP, and be relaunched to DSP when resume from RTD3.
The buffer size is 160 parameter lines.
kcontrol command to reset the buffer:
cset "name='Waves Set Param' 0xff"alsa-lib v1.0.29 or commit 6ea14c36 and f47480af are required to support the
kcontrol commands.Signed-off-by: Lu, Han
Signed-off-by: Mark Brown -
Add function to set parameters to module waves. The parameters can be set
only when module is enabled, and parameter size is limited to 500 Bytes.Signed-off-by: Lu, Han
Signed-off-by: Mark Brown -
Add kcontrol to enable/disable module waves. IPC is valid only when module
is loaded. Also track module state over suspend so it's state can be restored
on resume.Signed-off-by: Lu, Han
Signed-off-by: Mark Brown
11 Mar, 2015
6 commits
-
Signed-off-by: Lu, Han
Signed-off-by: Mark Brown -
Try to load module waves and allocate runtime blocks for it if the firmware
image of module waves exists.Signed-off-by: Lu, Han
Signed-off-by: Mark Brown -
Add a general method to load firmware image, and apply to base firmware
image loading. With the method, the driver will support loading multiple
different modules in order to support different features.Signed-off-by: Lu, Han
Signed-off-by: Mark Brown -
…e/sound into asoc-intel
-
Linux 4.0-rc3
-
A playback noise happens after suspend/resume on Braswell. The issue is due to
the codec PLL and codec ASRC are not enabled correctly due to the incorrect
sysclk setting after resume. This patch resets the sysclk source setting in
platform clock control widget handler.Signed-off-by: Bard Liao
Signed-off-by: Jin Yao
Signed-off-by: Mark Brown
07 Mar, 2015
1 commit
-
Details:
1. Unload all modules on fw_list of dsp when suspend, and reload all
modules on fw_list when resume.
2. A DSP expects only one scratch, but hsw_parse_fw_image() allocates
scratch blocks for each firmware image it parses. Move the allocate function
sst_block_alloc_scratch() out of hsw_parse_fw_image() to make sure a scratch
be allocated only after all firmware images be parsed.Signed-off-by: Lu, Han
Signed-off-by: Mark Brown