22 Jan, 2015

1 commit

  • No logic changes, just to be consistent.

    Cc: Adrian Hunter
    Cc: Borislav Petkov
    Cc: David Ahern
    Cc: Don Zickus
    Cc: Frederic Weisbecker
    Cc: Jiri Olsa
    Cc: Mike Galbraith
    Cc: Namhyung Kim
    Cc: Peter Zijlstra
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/n/tip-f7n5y0mvk6gew5185h6fg316@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Arnaldo Carvalho de Melo
     

23 Dec, 2014

1 commit

  • Sometimes it takes a long time to resort hist entries for output in case
    of a large data file. Show a progress bar window and inform user.

    Signed-off-by: Namhyung Kim
    Cc: Adrian Hunter
    Cc: David Ahern
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Peter Zijlstra
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/r/1419223455-4362-3-git-send-email-namhyung@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Namhyung Kim
     

10 Oct, 2014

1 commit

  • Not all tools need a hists instance per perf_evsel, so lets pave the way
    to remove evsel->hists while leaving a way to access the hists from a
    specially allocated evsel, one that comes with space at the end where
    lives the evsel.

    Cc: Adrian Hunter
    Cc: Borislav Petkov
    Cc: David Ahern
    Cc: Don Zickus
    Cc: Frederic Weisbecker
    Cc: Jean Pihet
    Cc: Jiri Olsa
    Cc: Mike Galbraith
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/n/tip-qlktkhe31w4mgtbd84035sr2@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Arnaldo Carvalho de Melo
     

01 Jun, 2014

3 commits

  • In various histogram test cases, fake symbols are used as raw numbers.
    Define macros for each pid, map, symbols so that it can increase
    readability somewhat.

    Signed-off-by: Namhyung Kim
    Cc: Arun Sharma
    Cc: Frederic Weisbecker
    Link: http://lkml.kernel.org/r/1401335910-16832-27-git-send-email-namhyung@kernel.org
    Signed-off-by: Jiri Olsa

    Namhyung Kim
     
  • The new ->add_entry_cb() will be called after an entry was added to
    the histogram. It's used for code sharing between perf report and
    perf top. Note that ops->add_*_entry() should set iter->he properly
    in order to call the ->add_entry_cb.

    Also pass @arg to the callback function. It'll be used by perf top
    later.

    Signed-off-by: Namhyung Kim
    Tested-by: Arun Sharma
    Tested-by: Rodrigo Campos
    Cc: Frederic Weisbecker
    Link: http://lkml.kernel.org/r/87k393g999.fsf@sejong.aot.lge.com
    Signed-off-by: Jiri Olsa

    Namhyung Kim
     
  • There're some duplicate code when adding hist entries. They are
    different in that some have branch info or mem info but generally do
    same thing. So introduce new struct hist_entry_iter and add callbacks
    to customize each case in general way.

    The new perf_evsel__add_entry() function will look like:

    iter->prepare_entry();
    iter->add_single_entry();

    while (iter->next_entry())
    iter->add_next_entry();

    iter->finish_entry();

    This will help further work like the cumulative callchain patchset.

    Signed-off-by: Namhyung Kim
    Tested-by: Arun Sharma
    Tested-by: Rodrigo Campos
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/r/1401335910-16832-3-git-send-email-namhyung@kernel.org
    Signed-off-by: Jiri Olsa

    Namhyung Kim
     

21 May, 2014

1 commit