// SPDX-License-Identifier: GPL-2.0+

  /*

   * (C) Copyright 2009
   * Sergey Kubushyn, himself, ksi@koi8.net
   *
   * Changes for unified multibus/multiadapter I2C support.
   *

   * (C) Copyright 2001
   * Gerald Van Baren, Custom IDEAS, vanbaren@cideas.com.

   */
  
  /*
   * I2C Functions similar to the standard memory functions.
   *
   * There are several parameters in many of the commands that bear further
   * explanations:
   *

   * {i2c_chip} is the I2C chip address (the first byte sent on the bus).
   *   Each I2C chip on the bus has a unique address.  On the I2C data bus,
   *   the address is the upper seven bits and the LSB is the "read/write"
   *   bit.  Note that the {i2c_chip} address specified on the command
   *   line is not shifted up: e.g. a typical EEPROM memory chip may have
   *   an I2C address of 0x50, but the data put on the bus will be 0xA0
   *   for write and 0xA1 for read.  This "non shifted" address notation
   *   matches at least half of the data sheets :-/.
   *
   * {addr} is the address (or offset) within the chip.  Small memory
   *   chips have 8 bit addresses.  Large memory chips have 16 bit
   *   addresses.  Other memory chips have 9, 10, or 11 bit addresses.
   *   Many non-memory chips have multiple registers and {addr} is used
   *   as the register index.  Some non-memory chips have only one register
   *   and therefore don't need any {addr} parameter.
   *
   *   The default {addr} parameter is one byte (.1) which works well for
   *   memories and registers with 8 bits of address space.
   *
   *   You can specify the length of the {addr} field with the optional .0,
   *   .1, or .2 modifier (similar to the .b, .w, .l modifier).  If you are
   *   manipulating a single register device which doesn't use an address
   *   field, use "0.0" for the address and the ".0" length field will
   *   suppress the address in the I2C data stream.  This also works for
   *   successive reads using the I2C auto-incrementing memory pointer.
   *
   *   If you are manipulating a large memory with 2-byte addresses, use
   *   the .2 address modifier, e.g. 210.2 addresses location 528 (decimal).
   *
   *   Then there are the unfortunate memory chips that spill the most
   *   significant 1, 2, or 3 bits of address into the chip address byte.
   *   This effectively makes one chip (logically) look like 2, 4, or
   *   8 chips.  This is handled (awkwardly) by #defining

   *   CONFIG_SYS_I2C_EEPROM_ADDR_OVERFLOW and using the .1 modifier on the

   *   {addr} field (since .1 is the default, it doesn't actually have to
   *   be specified).  Examples: given a memory chip at I2C chip address
   *   0x50, the following would happen...

   *     i2c md 50 0 10   display 16 bytes starting at 0x000

   *                      On the bus: <S> A0 00 <E> <S> A1 <rd> ... <rd>

   *     i2c md 50 100 10 display 16 bytes starting at 0x100

   *                      On the bus: <S> A2 00 <E> <S> A3 <rd> ... <rd>

   *     i2c md 50 210 10 display 16 bytes starting at 0x210

   *                      On the bus: <S> A4 10 <E> <S> A5 <rd> ... <rd>
   *   This is awfully ugly.  It would be nice if someone would think up
   *   a better way of handling this.
   *
   * Adapted from cmd_mem.c which is copyright Wolfgang Denk (wd@denx.de).
   */
  
  #include <common.h>

  #include <bootretry.h>

  #include <cli.h>

  #include <command.h>

  #include <console.h>

  #include <dm.h>

  #include <edid.h>

  #include <environment.h>

  #include <errno.h>

  #include <i2c.h>

  #include <malloc.h>

  #include <asm/byteorder.h>

  #include <linux/compiler.h>

  /* Display values from last command.
   * Memory modify remembered values are different from display memory.
   */

  static uint	i2c_dp_last_chip;

  static uint	i2c_dp_last_addr;
  static uint	i2c_dp_last_alen;
  static uint	i2c_dp_last_length = 0x10;

  static uint	i2c_mm_last_chip;

  static uint	i2c_mm_last_addr;
  static uint	i2c_mm_last_alen;

  /* If only one I2C bus is present, the list of devices to ignore when
   * the probe command is issued is represented by a 1D array of addresses.
   * When multiple buses are present, the list is an array of bus-address
   * pairs.  The following macros take care of this */

  #if defined(CONFIG_SYS_I2C_NOPROBES)

  #if defined(CONFIG_SYS_I2C) || defined(CONFIG_I2C_MULTI_BUS)

  static struct
  {
  	uchar	bus;
  	uchar	addr;

  } i2c_no_probes[] = CONFIG_SYS_I2C_NOPROBES;

  #define GET_BUS_NUM	i2c_get_bus_num()
  #define COMPARE_BUS(b,i)	(i2c_no_probes[(i)].bus == (b))
  #define COMPARE_ADDR(a,i)	(i2c_no_probes[(i)].addr == (a))
  #define NO_PROBE_ADDR(i)	i2c_no_probes[(i)].addr
  #else		/* single bus */

  static uchar i2c_no_probes[] = CONFIG_SYS_I2C_NOPROBES;

  #define GET_BUS_NUM	0
  #define COMPARE_BUS(b,i)	((b) == 0)	/* Make compiler happy */
  #define COMPARE_ADDR(a,i)	(i2c_no_probes[(i)] == (a))
  #define NO_PROBE_ADDR(i)	i2c_no_probes[(i)]

  #endif	/* defined(CONFIG_SYS_I2C) */

  #endif

  #define DISP_LINE_LEN	16

  /*
   * Default for driver model is to use the chip's existing address length.
   * For legacy code, this is not stored, so we need to use a suitable
   * default.
   */
  #ifdef CONFIG_DM_I2C
  #define DEFAULT_ADDR_LEN	(-1)
  #else
  #define DEFAULT_ADDR_LEN	1
  #endif
  
  #ifdef CONFIG_DM_I2C
  static struct udevice *i2c_cur_bus;

  static int cmd_i2c_set_bus_num(unsigned int busnum)

  {
  	struct udevice *bus;
  	int ret;
  
  	ret = uclass_get_device_by_seq(UCLASS_I2C, busnum, &bus);
  	if (ret) {
  		debug("%s: No bus %d
  ", __func__, busnum);
  		return ret;
  	}
  	i2c_cur_bus = bus;
  
  	return 0;
  }
  
  static int i2c_get_cur_bus(struct udevice **busp)
  {

  #ifdef CONFIG_I2C_SET_DEFAULT_BUS_NUM
  	if (!i2c_cur_bus) {
  		if (cmd_i2c_set_bus_num(CONFIG_I2C_DEFAULT_BUS_NUMBER)) {
  			printf("Default I2C bus %d not found
  ",
  			       CONFIG_I2C_DEFAULT_BUS_NUMBER);
  			return -ENODEV;
  		}
  	}
  #endif

  	if (!i2c_cur_bus) {
  		puts("No I2C bus selected
  ");
  		return -ENODEV;
  	}
  	*busp = i2c_cur_bus;
  
  	return 0;
  }
  
  static int i2c_get_cur_bus_chip(uint chip_addr, struct udevice **devp)
  {
  	struct udevice *bus;
  	int ret;
  
  	ret = i2c_get_cur_bus(&bus);
  	if (ret)
  		return ret;

  	return i2c_get_chip(bus, chip_addr, 1, devp);

  }
  
  #endif

  /**
   * i2c_init_board() - Board-specific I2C bus init
   *
   * This function is the default no-op implementation of I2C bus

   * initialization. This function can be overridden by board-specific

   * implementation if needed.
   */

  __weak
  void i2c_init_board(void)

  {

  }

  /* TODO: Implement architecture-specific get/set functions */

  
  /**
   * i2c_get_bus_speed() - Return I2C bus speed
   *
   * This function is the default implementation of function for retrieveing
   * the current I2C bus speed in Hz.
   *
   * A driver implementing runtime switching of I2C bus speed must override
   * this function to report the speed correctly. Simple or legacy drivers
   * can use this fallback.
   *
   * Returns I2C bus speed in Hz.
   */

  #if !defined(CONFIG_SYS_I2C) && !defined(CONFIG_DM_I2C)

  /*
   * TODO: Implement architecture-specific get/set functions
   * Should go away, if we switched completely to new multibus support
   */

  __weak
  unsigned int i2c_get_bus_speed(void)

  {
  	return CONFIG_SYS_I2C_SPEED;
  }

  /**
   * i2c_set_bus_speed() - Configure I2C bus speed
   * @speed:	Newly set speed of the I2C bus in Hz
   *
   * This function is the default implementation of function for setting
   * the I2C bus speed in Hz.
   *
   * A driver implementing runtime switching of I2C bus speed must override
   * this function to report the speed correctly. Simple or legacy drivers
   * can use this fallback.
   *
   * Returns zero on success, negative value on error.
   */

  __weak
  int i2c_set_bus_speed(unsigned int speed)

  {
  	if (speed != CONFIG_SYS_I2C_SPEED)
  		return -1;
  
  	return 0;
  }

  #endif

  /**
   * get_alen() - Small parser helper function to get address length
   *
   * Returns the address length.

   */

  static uint get_alen(char *arg, int default_len)

  {
  	int	j;
  	int	alen;

  	alen = default_len;

  	for (j = 0; j < 8; j++) {
  		if (arg[j] == '.') {
  			alen = arg[j+1] - '0';

  			break;
  		} else if (arg[j] == '\0')
  			break;
  	}
  	return alen;
  }

  enum i2c_err_op {
  	I2C_ERR_READ,
  	I2C_ERR_WRITE,
  };
  
  static int i2c_report_err(int ret, enum i2c_err_op op)
  {
  	printf("Error %s the chip: %d
  ",
  	       op == I2C_ERR_READ ? "reading" : "writing", ret);
  
  	return CMD_RET_FAILURE;
  }

  /**
   * do_i2c_read() - Handle the "i2c read" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.
   *

   * Syntax:
   *	i2c read {i2c_chip} {devaddr}{.0, .1, .2} {len} {memaddr}
   */

  static int do_i2c_read ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

  {

  	uint	chip;

  	uint	devaddr, length;
  	int alen;

  	u_char  *memaddr;

  	int ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;
  #endif

  	if (argc != 5)

  		return CMD_RET_USAGE;

  
  	/*
  	 * I2C chip address
  	 */
  	chip = simple_strtoul(argv[1], NULL, 16);
  
  	/*
  	 * I2C data address within the chip.  This can be 1 or
  	 * 2 bytes long.  Some day it might be 3 bytes long :-).
  	 */
  	devaddr = simple_strtoul(argv[2], NULL, 16);

  	alen = get_alen(argv[2], DEFAULT_ADDR_LEN);

  	if (alen > 3)

  		return CMD_RET_USAGE;

  
  	/*
  	 * Length is the number of objects, not number of bytes.
  	 */
  	length = simple_strtoul(argv[3], NULL, 16);
  
  	/*
  	 * memaddr is the address where to store things in memory
  	 */
  	memaddr = (u_char *)simple_strtoul(argv[4], NULL, 16);

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret && alen != -1)
  		ret = i2c_set_chip_offset_len(dev, alen);
  	if (!ret)

  		ret = dm_i2c_read(dev, devaddr, memaddr, length);

  #else
  	ret = i2c_read(chip, devaddr, alen, memaddr, length);
  #endif
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_READ);

  	return 0;
  }

  static int do_i2c_write(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
  {

  	uint	chip;

  	uint	devaddr, length;
  	int alen;

  	u_char  *memaddr;

  	int ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;

  	struct dm_i2c_chip *i2c_chip;

  #endif

  	if ((argc < 5) || (argc > 6))

  		return cmd_usage(cmdtp);
  
  	/*
  	 * memaddr is the address where to store things in memory
  	 */
  	memaddr = (u_char *)simple_strtoul(argv[1], NULL, 16);
  
  	/*
  	 * I2C chip address
  	 */
  	chip = simple_strtoul(argv[2], NULL, 16);
  
  	/*
  	 * I2C data address within the chip.  This can be 1 or
  	 * 2 bytes long.  Some day it might be 3 bytes long :-).
  	 */
  	devaddr = simple_strtoul(argv[3], NULL, 16);

  	alen = get_alen(argv[3], DEFAULT_ADDR_LEN);

  	if (alen > 3)
  		return cmd_usage(cmdtp);
  
  	/*

  	 * Length is the number of bytes.

  	 */
  	length = simple_strtoul(argv[4], NULL, 16);

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret && alen != -1)
  		ret = i2c_set_chip_offset_len(dev, alen);
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_WRITE);

  	i2c_chip = dev_get_parent_platdata(dev);
  	if (!i2c_chip)
  		return i2c_report_err(ret, I2C_ERR_WRITE);

  #endif

  	if (argc == 6 && !strcmp(argv[5], "-s")) {
  		/*
  		 * Write all bytes in a single I2C transaction. If the target
  		 * device is an EEPROM, it is your responsibility to not cross
  		 * a page boundary. No write delay upon completion, take this
  		 * into account if linking commands.
  		 */

  #ifdef CONFIG_DM_I2C

  		i2c_chip->flags &= ~DM_I2C_CHIP_WR_ADDRESS;
  		ret = dm_i2c_write(dev, devaddr, memaddr, length);

  #else

  		ret = i2c_write(chip, devaddr, alen, memaddr, length);

  #endif
  		if (ret)
  			return i2c_report_err(ret, I2C_ERR_WRITE);

  	} else {
  		/*
  		 * Repeated addressing - perform <length> separate
  		 * write transactions of one byte each
  		 */
  		while (length-- > 0) {
  #ifdef CONFIG_DM_I2C
  			i2c_chip->flags |= DM_I2C_CHIP_WR_ADDRESS;
  			ret = dm_i2c_write(dev, devaddr++, memaddr++, 1);
  #else
  			ret = i2c_write(chip, devaddr++, alen, memaddr++, 1);
  #endif
  			if (ret)
  				return i2c_report_err(ret, I2C_ERR_WRITE);

  /*
   * No write delay with FRAM devices.
   */
  #if !defined(CONFIG_SYS_I2C_FRAM)

  			udelay(11000);

  #endif

  		}

  	}
  	return 0;
  }

  #ifdef CONFIG_DM_I2C
  static int do_i2c_flags(cmd_tbl_t *cmdtp, int flag, int argc,
  			char *const argv[])
  {
  	struct udevice *dev;
  	uint flags;
  	int chip;
  	int ret;
  
  	if (argc < 2)
  		return CMD_RET_USAGE;
  
  	chip = simple_strtoul(argv[1], NULL, 16);
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_READ);
  
  	if (argc > 2) {
  		flags = simple_strtoul(argv[2], NULL, 16);
  		ret = i2c_set_chip_flags(dev, flags);
  	} else  {
  		ret = i2c_get_chip_flags(dev, &flags);
  		if (!ret)
  			printf("%x
  ", flags);
  	}
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_READ);
  
  	return 0;
  }

  
  static int do_i2c_olen(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
  {
  	struct udevice *dev;
  	uint olen;
  	int chip;
  	int ret;
  
  	if (argc < 2)
  		return CMD_RET_USAGE;
  
  	chip = simple_strtoul(argv[1], NULL, 16);
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_READ);
  
  	if (argc > 2) {
  		olen = simple_strtoul(argv[2], NULL, 16);
  		ret = i2c_set_chip_offset_len(dev, olen);
  	} else  {
  		ret = i2c_get_chip_offset_len(dev);
  		if (ret >= 0) {
  			printf("%x
  ", ret);
  			ret = 0;
  		}
  	}
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_READ);
  
  	return 0;
  }

  #endif

  /**
   * do_i2c_md() - Handle the "i2c md" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.
   *

   * Syntax:
   *	i2c md {i2c_chip} {addr}{.0, .1, .2} {len}
   */

  static int do_i2c_md ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

  {

  	uint	chip;

  	uint	addr, length;
  	int alen;

  	int	j, nbytes, linebytes;

  	int ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;
  #endif

  
  	/* We use the last specified parameters, unless new ones are
  	 * entered.
  	 */
  	chip   = i2c_dp_last_chip;
  	addr   = i2c_dp_last_addr;
  	alen   = i2c_dp_last_alen;
  	length = i2c_dp_last_length;

  	if (argc < 3)

  		return CMD_RET_USAGE;

  
  	if ((flag & CMD_FLAG_REPEAT) == 0) {
  		/*
  		 * New command specified.
  		 */

  
  		/*
  		 * I2C chip address
  		 */
  		chip = simple_strtoul(argv[1], NULL, 16);
  
  		/*
  		 * I2C data address within the chip.  This can be 1 or
  		 * 2 bytes long.  Some day it might be 3 bytes long :-).
  		 */
  		addr = simple_strtoul(argv[2], NULL, 16);

  		alen = get_alen(argv[2], DEFAULT_ADDR_LEN);

  		if (alen > 3)

  			return CMD_RET_USAGE;

  
  		/*
  		 * If another parameter, it is the length to display.
  		 * Length is the number of objects, not number of bytes.
  		 */
  		if (argc > 3)
  			length = simple_strtoul(argv[3], NULL, 16);
  	}

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret && alen != -1)
  		ret = i2c_set_chip_offset_len(dev, alen);
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_READ);
  #endif

  	/*
  	 * Print the lines.
  	 *
  	 * We buffer all read data, so we can make sure data is read only
  	 * once.
  	 */
  	nbytes = length;
  	do {
  		unsigned char	linebuf[DISP_LINE_LEN];
  		unsigned char	*cp;
  
  		linebytes = (nbytes > DISP_LINE_LEN) ? DISP_LINE_LEN : nbytes;

  #ifdef CONFIG_DM_I2C

  		ret = dm_i2c_read(dev, addr, linebuf, linebytes);

  #else
  		ret = i2c_read(chip, addr, alen, linebuf, linebytes);
  #endif
  		if (ret)

  			return i2c_report_err(ret, I2C_ERR_READ);

  		else {

  			printf("%04x:", addr);
  			cp = linebuf;
  			for (j=0; j<linebytes; j++) {
  				printf(" %02x", *cp++);
  				addr++;
  			}

  			puts ("    ");

  			cp = linebuf;
  			for (j=0; j<linebytes; j++) {
  				if ((*cp < 0x20) || (*cp > 0x7e))

  					puts (".");

  				else
  					printf("%c", *cp);
  				cp++;
  			}

  			putc ('
  ');

  		}
  		nbytes -= linebytes;
  	} while (nbytes > 0);
  
  	i2c_dp_last_chip   = chip;
  	i2c_dp_last_addr   = addr;
  	i2c_dp_last_alen   = alen;
  	i2c_dp_last_length = length;
  
  	return 0;
  }

  /**
   * do_i2c_mw() - Handle the "i2c mw" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.

   *
   * Syntax:

   *	i2c mw {i2c_chip} {addr}{.0, .1, .2} {data} [{count}]

   */

  static int do_i2c_mw ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

  {

  	uint	chip;

  	ulong	addr;

  	int	alen;

  	uchar	byte;
  	int	count;

  	int ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;
  #endif

  	if ((argc < 4) || (argc > 5))

  		return CMD_RET_USAGE;

  
  	/*

  	 * Chip is always specified.
  	 */

  	chip = simple_strtoul(argv[1], NULL, 16);
  
  	/*
  	 * Address is always specified.
  	 */
  	addr = simple_strtoul(argv[2], NULL, 16);

  	alen = get_alen(argv[2], DEFAULT_ADDR_LEN);

  	if (alen > 3)

  		return CMD_RET_USAGE;

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret && alen != -1)
  		ret = i2c_set_chip_offset_len(dev, alen);
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_WRITE);
  #endif

  	/*
  	 * Value to write is always specified.
  	 */
  	byte = simple_strtoul(argv[3], NULL, 16);
  
  	/*
  	 * Optional count
  	 */

  	if (argc == 5)

  		count = simple_strtoul(argv[4], NULL, 16);

  	else

  		count = 1;

  
  	while (count-- > 0) {

  #ifdef CONFIG_DM_I2C

  		ret = dm_i2c_write(dev, addr++, &byte, 1);

  #else
  		ret = i2c_write(chip, addr++, alen, &byte, 1);
  #endif
  		if (ret)

  			return i2c_report_err(ret, I2C_ERR_WRITE);

  		/*
  		 * Wait for the write to complete.  The write can take
  		 * up to 10mSec (we allow a little more time).

  		 */

  /*
   * No write delay with FRAM devices.
   */

  #if !defined(CONFIG_SYS_I2C_FRAM)

  		udelay(11000);

  #endif

  	}

  	return 0;

  }

  /**
   * do_i2c_crc() - Handle the "i2c crc32" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Calculate a CRC on memory
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.

   *
   * Syntax:

   *	i2c crc32 {i2c_chip} {addr}{.0, .1, .2} {count}

   */

  static int do_i2c_crc (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

  {

  	uint	chip;

  	ulong	addr;

  	int	alen;

  	int	count;
  	uchar	byte;
  	ulong	crc;
  	ulong	err;

  	int ret = 0;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;
  #endif

  	if (argc < 4)

  		return CMD_RET_USAGE;

  
  	/*

  	 * Chip is always specified.
  	 */

  	chip = simple_strtoul(argv[1], NULL, 16);
  
  	/*
  	 * Address is always specified.
  	 */
  	addr = simple_strtoul(argv[2], NULL, 16);

  	alen = get_alen(argv[2], DEFAULT_ADDR_LEN);

  	if (alen > 3)

  		return CMD_RET_USAGE;

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret && alen != -1)
  		ret = i2c_set_chip_offset_len(dev, alen);
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_READ);
  #endif

  	/*
  	 * Count is always specified
  	 */
  	count = simple_strtoul(argv[3], NULL, 16);
  
  	printf ("CRC32 for %08lx ... %08lx ==> ", addr, addr + count - 1);
  	/*
  	 * CRC a byte at a time.  This is going to be slooow, but hey, the
  	 * memories are small and slow too so hopefully nobody notices.
  	 */
  	crc = 0;
  	err = 0;

  	while (count-- > 0) {

  #ifdef CONFIG_DM_I2C

  		ret = dm_i2c_read(dev, addr, &byte, 1);

  #else
  		ret = i2c_read(chip, addr, alen, &byte, 1);
  #endif
  		if (ret)

  			err++;

  		crc = crc32 (crc, &byte, 1);
  		addr++;
  	}

  	if (err > 0)

  		i2c_report_err(ret, I2C_ERR_READ);

  	else

  		printf ("%08lx
  ", crc);

  
  	return 0;
  }

  /**
   * mod_i2c_mem() - Handle the "i2c mm" and "i2c nm" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Modify memory.
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.

   *
   * Syntax:

   *	i2c mm{.b, .w, .l} {i2c_chip} {addr}{.0, .1, .2}
   *	i2c nm{.b, .w, .l} {i2c_chip} {addr}{.0, .1, .2}

   */

  static int

  mod_i2c_mem(cmd_tbl_t *cmdtp, int incrflag, int flag, int argc, char * const argv[])

  {

  	uint	chip;

  	ulong	addr;

  	int	alen;

  	ulong	data;
  	int	size = 1;
  	int	nbytes;

  	int ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;
  #endif

  	if (argc != 3)

  		return CMD_RET_USAGE;

  	bootretry_reset_cmd_timeout();	/* got a good command to get here */

  	/*
  	 * We use the last specified parameters, unless new ones are
  	 * entered.
  	 */
  	chip = i2c_mm_last_chip;
  	addr = i2c_mm_last_addr;
  	alen = i2c_mm_last_alen;
  
  	if ((flag & CMD_FLAG_REPEAT) == 0) {
  		/*
  		 * New command specified.  Check for a size specification.
  		 * Defaults to byte if no or incorrect specification.
  		 */
  		size = cmd_get_data_size(argv[0], 1);
  
  		/*

  		 * Chip is always specified.
  		 */

  		chip = simple_strtoul(argv[1], NULL, 16);
  
  		/*
  		 * Address is always specified.
  		 */
  		addr = simple_strtoul(argv[2], NULL, 16);

  		alen = get_alen(argv[2], DEFAULT_ADDR_LEN);

  		if (alen > 3)

  			return CMD_RET_USAGE;

  	}

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret && alen != -1)
  		ret = i2c_set_chip_offset_len(dev, alen);
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_WRITE);
  #endif

  	/*
  	 * Print the address, followed by value.  Then accept input for
  	 * the next value.  A non-converted value exits.
  	 */
  	do {
  		printf("%08lx:", addr);

  #ifdef CONFIG_DM_I2C

  		ret = dm_i2c_read(dev, addr, (uchar *)&data, size);

  #else
  		ret = i2c_read(chip, addr, alen, (uchar *)&data, size);
  #endif
  		if (ret)

  			return i2c_report_err(ret, I2C_ERR_READ);
  
  		data = cpu_to_be32(data);
  		if (size == 1)
  			printf(" %02lx", (data >> 24) & 0x000000FF);
  		else if (size == 2)
  			printf(" %04lx", (data >> 16) & 0x0000FFFF);
  		else
  			printf(" %08lx", data);

  		nbytes = cli_readline(" ? ");

  		if (nbytes == 0) {
  			/*
  			 * <CR> pressed as only input, don't modify current
  			 * location and move to next.
  			 */
  			if (incrflag)
  				addr += size;
  			nbytes = size;

  			/* good enough to not time out */
  			bootretry_reset_cmd_timeout();

  		}
  #ifdef CONFIG_BOOT_RETRY_TIME

  		else if (nbytes == -2)

  			break;	/* timed out, exit the command	*/

  #endif
  		else {
  			char *endp;
  
  			data = simple_strtoul(console_buffer, &endp, 16);

  			if (size == 1)

  				data = data << 24;

  			else if (size == 2)

  				data = data << 16;

  			data = be32_to_cpu(data);
  			nbytes = endp - console_buffer;
  			if (nbytes) {

  				/*
  				 * good enough to not time out
  				 */

  				bootretry_reset_cmd_timeout();

  #ifdef CONFIG_DM_I2C

  				ret = dm_i2c_write(dev, addr, (uchar *)&data,
  						   size);

  #else
  				ret = i2c_write(chip, addr, alen,
  						(uchar *)&data, size);
  #endif
  				if (ret)

  					return i2c_report_err(ret,
  							      I2C_ERR_WRITE);

  #ifdef CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS
  				udelay(CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS * 1000);

  #endif

  				if (incrflag)
  					addr += size;
  			}
  		}
  	} while (nbytes);

  	i2c_mm_last_chip = chip;
  	i2c_mm_last_addr = addr;
  	i2c_mm_last_alen = alen;

  
  	return 0;
  }

  /**
   * do_i2c_probe() - Handle the "i2c probe" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.
   *

   * Syntax:

   *	i2c probe {addr}
   *
   * Returns zero (success) if one or more I2C devices was found

   */

  static int do_i2c_probe (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

  {
  	int j;

  	int addr = -1;
  	int found = 0;

  #if defined(CONFIG_SYS_I2C_NOPROBES)

  	int k, skip;

  	unsigned int bus = GET_BUS_NUM;

  #endif	/* NOPROBES */

  	int ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *bus, *dev;
  
  	if (i2c_get_cur_bus(&bus))
  		return CMD_RET_FAILURE;
  #endif

  	if (argc == 2)
  		addr = simple_strtol(argv[1], 0, 16);

  	puts ("Valid chip addresses:");

  	for (j = 0; j < 128; j++) {

  		if ((0 <= addr) && (j != addr))
  			continue;

  #if defined(CONFIG_SYS_I2C_NOPROBES)

  		skip = 0;

  		for (k = 0; k < ARRAY_SIZE(i2c_no_probes); k++) {

  			if (COMPARE_BUS(bus, k) && COMPARE_ADDR(j, k)) {

  				skip = 1;
  				break;
  			}
  		}
  		if (skip)
  			continue;
  #endif

  #ifdef CONFIG_DM_I2C

  		ret = dm_i2c_probe(bus, j, 0, &dev);

  #else
  		ret = i2c_probe(j);
  #endif
  		if (ret == 0) {

  			printf(" %02X", j);

  			found++;
  		}

  	}

  	putc ('
  ');

  #if defined(CONFIG_SYS_I2C_NOPROBES)

  	puts ("Excluded chip addresses:");

  	for (k = 0; k < ARRAY_SIZE(i2c_no_probes); k++) {

  		if (COMPARE_BUS(bus,k))

  			printf(" %02X", NO_PROBE_ADDR(k));
  	}

  	putc ('
  ');

  #endif

  	return (0 == found);

  }

  /**
   * do_i2c_loop() - Handle the "i2c loop" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.
   *

   * Syntax:

   *	i2c loop {i2c_chip} {addr}{.0, .1, .2} [{length}] [{delay}]

   *	{length} - Number of bytes to read
   *	{delay}  - A DECIMAL number and defaults to 1000 uSec
   */

  static int do_i2c_loop(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

  {

  	uint	chip;

  	int alen;

  	uint	addr;
  	uint	length;
  	u_char	bytes[16];
  	int	delay;

  	int ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;
  #endif

  	if (argc < 3)

  		return CMD_RET_USAGE;

  
  	/*
  	 * Chip is always specified.
  	 */
  	chip = simple_strtoul(argv[1], NULL, 16);
  
  	/*
  	 * Address is always specified.
  	 */
  	addr = simple_strtoul(argv[2], NULL, 16);

  	alen = get_alen(argv[2], DEFAULT_ADDR_LEN);

  	if (alen > 3)

  		return CMD_RET_USAGE;

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret && alen != -1)
  		ret = i2c_set_chip_offset_len(dev, alen);
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_WRITE);
  #endif

  
  	/*
  	 * Length is the number of objects, not number of bytes.
  	 */
  	length = 1;
  	length = simple_strtoul(argv[3], NULL, 16);

  	if (length > sizeof(bytes))

  		length = sizeof(bytes);

  
  	/*
  	 * The delay time (uSec) is optional.
  	 */
  	delay = 1000;

  	if (argc > 3)

  		delay = simple_strtoul(argv[4], NULL, 10);

  	/*
  	 * Run the loop...
  	 */

  	while (1) {

  #ifdef CONFIG_DM_I2C

  		ret = dm_i2c_read(dev, addr, bytes, length);

  #else
  		ret = i2c_read(chip, addr, alen, bytes, length);
  #endif
  		if (ret)
  			i2c_report_err(ret, I2C_ERR_READ);

  		udelay(delay);
  	}
  
  	/* NOTREACHED */
  	return 0;
  }

  /*
   * The SDRAM command is separately configured because many
   * (most?) embedded boards don't use SDRAM DIMMs.

   *
   * FIXME: Document and probably move elsewhere!

   */

  #if defined(CONFIG_CMD_SDRAM)

  static void print_ddr2_tcyc (u_char const b)
  {
  	printf ("%d.", (b >> 4) & 0x0F);
  	switch (b & 0x0F) {
  	case 0x0:
  	case 0x1:
  	case 0x2:
  	case 0x3:
  	case 0x4:
  	case 0x5:
  	case 0x6:
  	case 0x7:
  	case 0x8:
  	case 0x9:
  		printf ("%d ns
  ", b & 0x0F);
  		break;
  	case 0xA:
  		puts ("25 ns
  ");
  		break;
  	case 0xB:
  		puts ("33 ns
  ");
  		break;
  	case 0xC:
  		puts ("66 ns
  ");
  		break;
  	case 0xD:
  		puts ("75 ns
  ");
  		break;
  	default:
  		puts ("?? ns
  ");
  		break;
  	}
  }
  
  static void decode_bits (u_char const b, char const *str[], int const do_once)
  {
  	u_char mask;
  
  	for (mask = 0x80; mask != 0x00; mask >>= 1, ++str) {
  		if (b & mask) {
  			puts (*str);
  			if (do_once)
  				return;
  		}
  	}
  }

  
  /*
   * Syntax:

   *	i2c sdram {i2c_chip}

   */

  static int do_sdram (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])

  {

  	enum { unknown, EDO, SDRAM, DDR, DDR2, DDR3, DDR4 } type;

  	uint	chip;

  	u_char	data[128];
  	u_char	cksum;

  	int	j, ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;
  #endif

  	static const char *decode_CAS_DDR2[] = {
  		" TBD", " 6", " 5", " 4", " 3", " 2", " TBD", " TBD"
  	};
  
  	static const char *decode_CAS_default[] = {
  		" TBD", " 7", " 6", " 5", " 4", " 3", " 2", " 1"
  	};
  
  	static const char *decode_CS_WE_default[] = {
  		" TBD", " 6", " 5", " 4", " 3", " 2", " 1", " 0"
  	};
  
  	static const char *decode_byte21_default[] = {
  		"  TBD (bit 7)
  ",
  		"  Redundant row address
  ",
  		"  Differential clock input
  ",
  		"  Registerd DQMB inputs
  ",
  		"  Buffered DQMB inputs
  ",
  		"  On-card PLL
  ",
  		"  Registered address/control lines
  ",
  		"  Buffered address/control lines
  "
  	};
  
  	static const char *decode_byte22_DDR2[] = {
  		"  TBD (bit 7)
  ",
  		"  TBD (bit 6)
  ",
  		"  TBD (bit 5)
  ",
  		"  TBD (bit 4)
  ",
  		"  TBD (bit 3)
  ",
  		"  Supports partial array self refresh
  ",
  		"  Supports 50 ohm ODT
  ",
  		"  Supports weak driver
  "
  	};
  
  	static const char *decode_row_density_DDR2[] = {
  		"512 MiB", "256 MiB", "128 MiB", "16 GiB",
  		"8 GiB", "4 GiB", "2 GiB", "1 GiB"
  	};
  
  	static const char *decode_row_density_default[] = {
  		"512 MiB", "256 MiB", "128 MiB", "64 MiB",
  		"32 MiB", "16 MiB", "8 MiB", "4 MiB"
  	};

  	if (argc < 2)

  		return CMD_RET_USAGE;

  	/*
  	 * Chip is always specified.

  	 */
  	chip = simple_strtoul (argv[1], NULL, 16);

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret)
  		ret = dm_i2c_read(dev, 0, data, sizeof(data));
  #else
  	ret = i2c_read(chip, 0, 1, data, sizeof(data));
  #endif
  	if (ret) {

  		puts ("No SDRAM Serial Presence Detect found.
  ");

  		return 1;
  	}
  
  	cksum = 0;
  	for (j = 0; j < 63; j++) {
  		cksum += data[j];
  	}

  	if (cksum != data[63]) {

  		printf ("WARNING: Configuration data checksum failure:
  "

  			"  is 0x%02x, calculated 0x%02x
  ", data[63], cksum);

  	}

  	printf ("SPD data revision            %d.%d
  ",

  		(data[62] >> 4) & 0x0F, data[62] & 0x0F);

  	printf ("Bytes used                   0x%02X
  ", data[0]);
  	printf ("Serial memory size           0x%02X
  ", 1 << data[1]);

  	puts ("Memory type                  ");

  	switch (data[2]) {

  	case 2:
  		type = EDO;
  		puts ("EDO
  ");
  		break;
  	case 4:
  		type = SDRAM;
  		puts ("SDRAM
  ");
  		break;

  	case 7:
  		type = DDR;
  		puts("DDR
  ");
  		break;

  	case 8:
  		type = DDR2;
  		puts ("DDR2
  ");
  		break;

  	case 11:
  		type = DDR3;
  		puts("DDR3
  ");
  		break;
  	case 12:
  		type = DDR4;
  		puts("DDR4
  ");
  		break;

  	default:
  		type = unknown;
  		puts ("unknown
  ");
  		break;

  	}

  	puts ("Row address bits             ");

  	if ((data[3] & 0x00F0) == 0)

  		printf ("%d
  ", data[3] & 0x0F);

  	else

  		printf ("%d/%d
  ", data[3] & 0x0F, (data[3] >> 4) & 0x0F);

  	puts ("Column address bits          ");

  	if ((data[4] & 0x00F0) == 0)

  		printf ("%d
  ", data[4] & 0x0F);

  	else

  		printf ("%d/%d
  ", data[4] & 0x0F, (data[4] >> 4) & 0x0F);

  
  	switch (type) {
  	case DDR2:

  		printf ("Number of ranks              %d
  ",
  			(data[5] & 0x07) + 1);

  		break;
  	default:

  		printf ("Module rows                  %d
  ", data[5]);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("Module data width            %d bits
  ", data[6]);

  		break;
  	default:

  		printf ("Module data width            %d bits
  ",
  			(data[7] << 8) | data[6]);

  		break;
  	}

  	puts ("Interface signal levels      ");

  	switch(data[8]) {

  		case 0:  puts ("TTL 5.0 V
  ");	break;

  		case 1:  puts ("LVTTL
  ");	break;

  		case 2:  puts ("HSTL 1.5 V
  ");	break;
  		case 3:  puts ("SSTL 3.3 V
  ");	break;
  		case 4:  puts ("SSTL 2.5 V
  ");	break;
  		case 5:  puts ("SSTL 1.8 V
  ");	break;

  		default: puts ("unknown
  ");	break;

  	}

  
  	switch (type) {
  	case DDR2:

  		printf ("SDRAM cycle time             ");
  		print_ddr2_tcyc (data[9]);

  		break;
  	default:

  		printf ("SDRAM cycle time             %d.%d ns
  ",
  			(data[9] >> 4) & 0x0F, data[9] & 0x0F);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("SDRAM access time            0.%d%d ns
  ",
  			(data[10] >> 4) & 0x0F, data[10] & 0x0F);

  		break;
  	default:

  		printf ("SDRAM access time            %d.%d ns
  ",
  			(data[10] >> 4) & 0x0F, data[10] & 0x0F);

  		break;
  	}

  	puts ("EDC configuration            ");

  	switch (data[11]) {

  		case 0:  puts ("None
  ");	break;
  		case 1:  puts ("Parity
  ");	break;
  		case 2:  puts ("ECC
  ");	break;
  		default: puts ("unknown
  ");	break;

  	}

  	if ((data[12] & 0x80) == 0)

  		puts ("No self refresh, rate        ");

  	else

  		puts ("Self refresh, rate           ");

  	switch(data[12] & 0x7F) {

  		case 0:  puts ("15.625 us
  ");	break;
  		case 1:  puts ("3.9 us
  ");	break;
  		case 2:  puts ("7.8 us
  ");	break;
  		case 3:  puts ("31.3 us
  ");	break;
  		case 4:  puts ("62.5 us
  ");	break;
  		case 5:  puts ("125 us
  ");	break;

  		default: puts ("unknown
  ");	break;

  	}

  
  	switch (type) {
  	case DDR2:

  		printf ("SDRAM width (primary)        %d
  ", data[13]);

  		break;
  	default:

  		printf ("SDRAM width (primary)        %d
  ", data[13] & 0x7F);

  		if ((data[13] & 0x80) != 0) {

  			printf ("  (second bank)              %d
  ",
  				2 * (data[13] & 0x7F));

  		}
  		break;
  	}
  
  	switch (type) {
  	case DDR2:
  		if (data[14] != 0)

  			printf ("EDC width                    %d
  ", data[14]);

  		break;
  	default:
  		if (data[14] != 0) {

  			printf ("EDC width                    %d
  ",
  				data[14] & 0x7F);

  
  			if ((data[14] & 0x80) != 0) {

  				printf ("  (second bank)              %d
  ",
  					2 * (data[14] & 0x7F));

  			}
  		}
  		break;

  	}

  	if (DDR2 != type) {
  		printf ("Min clock delay, back-to-back random column addresses "
  			"%d
  ", data[15]);

  	}

  	puts ("Burst length(s)             ");
  	if (data[16] & 0x80) puts (" Page");
  	if (data[16] & 0x08) puts (" 8");
  	if (data[16] & 0x04) puts (" 4");
  	if (data[16] & 0x02) puts (" 2");
  	if (data[16] & 0x01) puts (" 1");
  	putc ('
  ');

  	printf ("Number of banks              %d
  ", data[17]);

  
  	switch (type) {
  	case DDR2:
  		puts ("CAS latency(s)              ");

  		decode_bits (data[18], decode_CAS_DDR2, 0);

  		putc ('
  ');
  		break;
  	default:
  		puts ("CAS latency(s)              ");

  		decode_bits (data[18], decode_CAS_default, 0);

  		putc ('
  ');
  		break;
  	}
  
  	if (DDR2 != type) {
  		puts ("CS latency(s)               ");

  		decode_bits (data[19], decode_CS_WE_default, 0);

  		putc ('
  ');
  	}
  
  	if (DDR2 != type) {
  		puts ("WE latency(s)               ");

  		decode_bits (data[20], decode_CS_WE_default, 0);

  		putc ('
  ');
  	}
  
  	switch (type) {
  	case DDR2:
  		puts ("Module attributes:
  ");
  		if (data[21] & 0x80)
  			puts ("  TBD (bit 7)
  ");
  		if (data[21] & 0x40)
  			puts ("  Analysis probe installed
  ");
  		if (data[21] & 0x20)
  			puts ("  TBD (bit 5)
  ");
  		if (data[21] & 0x10)
  			puts ("  FET switch external enable
  ");

  		printf ("  %d PLLs on DIMM
  ", (data[21] >> 2) & 0x03);

  		if (data[20] & 0x11) {

  			printf ("  %d active registers on DIMM
  ",
  				(data[21] & 0x03) + 1);

  		}
  		break;
  	default:
  		puts ("Module attributes:
  ");
  		if (!data[21])
  			puts ("  (none)
  ");

  		else
  			decode_bits (data[21], decode_byte21_default, 0);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		decode_bits (data[22], decode_byte22_DDR2, 0);

  		break;
  	default:
  		puts ("Device attributes:
  ");
  		if (data[22] & 0x80) puts ("  TBD (bit 7)
  ");
  		if (data[22] & 0x40) puts ("  TBD (bit 6)
  ");
  		if (data[22] & 0x20) puts ("  Upper Vcc tolerance 5%
  ");
  		else                 puts ("  Upper Vcc tolerance 10%
  ");
  		if (data[22] & 0x10) puts ("  Lower Vcc tolerance 5%
  ");
  		else                 puts ("  Lower Vcc tolerance 10%
  ");
  		if (data[22] & 0x08) puts ("  Supports write1/read burst
  ");
  		if (data[22] & 0x04) puts ("  Supports precharge all
  ");
  		if (data[22] & 0x02) puts ("  Supports auto precharge
  ");
  		if (data[22] & 0x01) puts ("  Supports early RAS# precharge
  ");
  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("SDRAM cycle time (2nd highest CAS latency)        ");
  		print_ddr2_tcyc (data[23]);

  		break;
  	default:

  		printf ("SDRAM cycle time (2nd highest CAS latency)        %d."
  			"%d ns
  ", (data[23] >> 4) & 0x0F, data[23] & 0x0F);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("SDRAM access from clock (2nd highest CAS latency) 0."
  			"%d%d ns
  ", (data[24] >> 4) & 0x0F, data[24] & 0x0F);

  		break;
  	default:

  		printf ("SDRAM access from clock (2nd highest CAS latency) %d."
  			"%d ns
  ", (data[24] >> 4) & 0x0F, data[24] & 0x0F);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("SDRAM cycle time (3rd highest CAS latency)        ");
  		print_ddr2_tcyc (data[25]);

  		break;
  	default:

  		printf ("SDRAM cycle time (3rd highest CAS latency)        %d."
  			"%d ns
  ", (data[25] >> 4) & 0x0F, data[25] & 0x0F);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("SDRAM access from clock (3rd highest CAS latency) 0."
  			"%d%d ns
  ", (data[26] >> 4) & 0x0F, data[26] & 0x0F);

  		break;
  	default:

  		printf ("SDRAM access from clock (3rd highest CAS latency) %d."
  			"%d ns
  ", (data[26] >> 4) & 0x0F, data[26] & 0x0F);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("Minimum row precharge        %d.%02d ns
  ",
  			(data[27] >> 2) & 0x3F, 25 * (data[27] & 0x03));

  		break;
  	default:

  		printf ("Minimum row precharge        %d ns
  ", data[27]);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("Row active to row active min %d.%02d ns
  ",
  			(data[28] >> 2) & 0x3F, 25 * (data[28] & 0x03));

  		break;
  	default:

  		printf ("Row active to row active min %d ns
  ", data[28]);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("RAS to CAS delay min         %d.%02d ns
  ",
  			(data[29] >> 2) & 0x3F, 25 * (data[29] & 0x03));

  		break;
  	default:

  		printf ("RAS to CAS delay min         %d ns
  ", data[29]);

  		break;
  	}

  	printf ("Minimum RAS pulse width      %d ns
  ", data[30]);

  
  	switch (type) {
  	case DDR2:

  		puts ("Density of each row          ");
  		decode_bits (data[31], decode_row_density_DDR2, 1);
  		putc ('
  ');

  		break;
  	default:

  		puts ("Density of each row          ");
  		decode_bits (data[31], decode_row_density_default, 1);
  		putc ('
  ');

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		puts ("Command and Address setup    ");

  		if (data[32] >= 0xA0) {

  			printf ("1.%d%d ns
  ",
  				((data[32] >> 4) & 0x0F) - 10, data[32] & 0x0F);

  		} else {

  			printf ("0.%d%d ns
  ",
  				((data[32] >> 4) & 0x0F), data[32] & 0x0F);

  		}
  		break;
  	default:

  		printf ("Command and Address setup    %c%d.%d ns
  ",
  			(data[32] & 0x80) ? '-' : '+',
  			(data[32] >> 4) & 0x07, data[32] & 0x0F);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		puts ("Command and Address hold     ");

  		if (data[33] >= 0xA0) {

  			printf ("1.%d%d ns
  ",
  				((data[33] >> 4) & 0x0F) - 10, data[33] & 0x0F);

  		} else {

  			printf ("0.%d%d ns
  ",
  				((data[33] >> 4) & 0x0F), data[33] & 0x0F);

  		}
  		break;
  	default:

  		printf ("Command and Address hold     %c%d.%d ns
  ",
  			(data[33] & 0x80) ? '-' : '+',
  			(data[33] >> 4) & 0x07, data[33] & 0x0F);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("Data signal input setup      0.%d%d ns
  ",
  			(data[34] >> 4) & 0x0F, data[34] & 0x0F);

  		break;
  	default:

  		printf ("Data signal input setup      %c%d.%d ns
  ",
  			(data[34] & 0x80) ? '-' : '+',
  			(data[34] >> 4) & 0x07, data[34] & 0x0F);

  		break;
  	}
  
  	switch (type) {
  	case DDR2:

  		printf ("Data signal input hold       0.%d%d ns
  ",
  			(data[35] >> 4) & 0x0F, data[35] & 0x0F);

  		break;
  	default:

  		printf ("Data signal input hold       %c%d.%d ns
  ",
  			(data[35] & 0x80) ? '-' : '+',
  			(data[35] >> 4) & 0x07, data[35] & 0x0F);

  		break;
  	}

  	puts ("Manufacturer's JEDEC ID      ");

  	for (j = 64; j <= 71; j++)

  		printf ("%02X ", data[j]);

  	putc ('
  ');

  	printf ("Manufacturing Location       %02X
  ", data[72]);

  	puts ("Manufacturer's Part Number   ");

  	for (j = 73; j <= 90; j++)

  		printf ("%02X ", data[j]);

  	putc ('
  ');

  	printf ("Revision Code                %02X %02X
  ", data[91], data[92]);
  	printf ("Manufacturing Date           %02X %02X
  ", data[93], data[94]);

  	puts ("Assembly Serial Number       ");

  	for (j = 95; j <= 98; j++)

  		printf ("%02X ", data[j]);

  	putc ('
  ');

  	if (DDR2 != type) {

  		printf ("Speed rating                 PC%d
  ",
  			data[126] == 0x66 ? 66 : data[126]);

  	}

  	return 0;
  }

  #endif

  /*
   * Syntax:
   *	i2c edid {i2c_chip}
   */
  #if defined(CONFIG_I2C_EDID)
  int do_edid(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
  {

  	uint chip;

  	struct edid1_info edid;

  	int ret;
  #ifdef CONFIG_DM_I2C
  	struct udevice *dev;
  #endif

  
  	if (argc < 2) {
  		cmd_usage(cmdtp);
  		return 1;
  	}
  
  	chip = simple_strtoul(argv[1], NULL, 16);

  #ifdef CONFIG_DM_I2C
  	ret = i2c_get_cur_bus_chip(chip, &dev);
  	if (!ret)

  		ret = dm_i2c_read(dev, 0, (uchar *)&edid, sizeof(edid));

  #else
  	ret = i2c_read(chip, 0, 1, (uchar *)&edid, sizeof(edid));
  #endif
  	if (ret)
  		return i2c_report_err(ret, I2C_ERR_READ);

  
  	if (edid_check_info(&edid)) {
  		puts("Content isn't valid EDID.
  ");
  		return 1;
  	}
  
  	edid_print_info(&edid);
  	return 0;
  
  }
  #endif /* CONFIG_I2C_EDID */

  #ifdef CONFIG_DM_I2C
  static void show_bus(struct udevice *bus)
  {
  	struct udevice *dev;
  
  	printf("Bus %d:\t%s", bus->req_seq, bus->name);
  	if (device_active(bus))
  		printf("  (active %d)", bus->seq);
  	printf("
  ");
  	for (device_find_first_child(bus, &dev);
  	     dev;
  	     device_find_next_child(&dev)) {
  		struct dm_i2c_chip *chip = dev_get_parent_platdata(dev);
  
  		printf("   %02x: %s, offset len %x, flags %x
  ",
  		       chip->chip_addr, dev->name, chip->offset_len,
  		       chip->flags);
  	}
  }
  #endif

  /**

   * do_i2c_show_bus() - Handle the "i2c bus" command-line command

   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero always.
   */

  #if defined(CONFIG_SYS_I2C) || defined(CONFIG_DM_I2C)

  static int do_i2c_show_bus(cmd_tbl_t *cmdtp, int flag, int argc,
  				char * const argv[])

  {

  	if (argc == 1) {
  		/* show all busses */

  #ifdef CONFIG_DM_I2C
  		struct udevice *bus;
  		struct uclass *uc;
  		int ret;
  
  		ret = uclass_get(UCLASS_I2C, &uc);
  		if (ret)
  			return CMD_RET_FAILURE;
  		uclass_foreach_dev(bus, uc)
  			show_bus(bus);
  #else
  		int i;

  		for (i = 0; i < CONFIG_SYS_NUM_I2C_BUSES; i++) {
  			printf("Bus %d:\t%s", i, I2C_ADAP_NR(i)->name);
  #ifndef CONFIG_SYS_I2C_DIRECT_BUS

  			int j;

  			for (j = 0; j < CONFIG_SYS_I2C_MAX_HOPS; j++) {
  				if (i2c_bus[i].next_hop[j].chip == 0)
  					break;
  				printf("->%s@0x%2x:%d",
  				       i2c_bus[i].next_hop[j].mux.name,
  				       i2c_bus[i].next_hop[j].chip,
  				       i2c_bus[i].next_hop[j].channel);

  			}

  #endif
  			printf("
  ");

  		}

  #endif

  	} else {

  		int i;

  		/* show specific bus */
  		i = simple_strtoul(argv[1], NULL, 10);

  #ifdef CONFIG_DM_I2C
  		struct udevice *bus;
  		int ret;
  
  		ret = uclass_get_device_by_seq(UCLASS_I2C, i, &bus);
  		if (ret) {
  			printf("Invalid bus %d: err=%d
  ", i, ret);
  			return CMD_RET_FAILURE;
  		}
  		show_bus(bus);
  #else

  		if (i >= CONFIG_SYS_NUM_I2C_BUSES) {
  			printf("Invalid bus %d
  ", i);
  			return -1;
  		}
  		printf("Bus %d:\t%s", i, I2C_ADAP_NR(i)->name);
  #ifndef CONFIG_SYS_I2C_DIRECT_BUS

  			int j;

  			for (j = 0; j < CONFIG_SYS_I2C_MAX_HOPS; j++) {
  				if (i2c_bus[i].next_hop[j].chip == 0)
  					break;
  				printf("->%s@0x%2x:%d",
  				       i2c_bus[i].next_hop[j].mux.name,
  				       i2c_bus[i].next_hop[j].chip,
  				       i2c_bus[i].next_hop[j].channel);
  			}
  #endif
  		printf("
  ");

  #endif

  	}

  
  	return 0;

  }

  #endif

  /**
   * do_i2c_bus_num() - Handle the "i2c dev" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.
   */

  #if defined(CONFIG_SYS_I2C) || defined(CONFIG_I2C_MULTI_BUS) || \
  		defined(CONFIG_DM_I2C)

  static int do_i2c_bus_num(cmd_tbl_t *cmdtp, int flag, int argc,
  				char * const argv[])

  {

  	int		ret = 0;

  	int	bus_no;

  	if (argc == 1) {

  		/* querying current setting */

  #ifdef CONFIG_DM_I2C
  		struct udevice *bus;
  
  		if (!i2c_get_cur_bus(&bus))
  			bus_no = bus->seq;
  		else
  			bus_no = -1;
  #else
  		bus_no = i2c_get_bus_num();
  #endif
  		printf("Current bus is %d
  ", bus_no);
  	} else {

  		bus_no = simple_strtoul(argv[1], NULL, 10);

  #if defined(CONFIG_SYS_I2C)

  		if (bus_no >= CONFIG_SYS_NUM_I2C_BUSES) {
  			printf("Invalid bus %d
  ", bus_no);
  			return -1;
  		}

  #endif

  		printf("Setting bus to %d
  ", bus_no);

  #ifdef CONFIG_DM_I2C
  		ret = cmd_i2c_set_bus_num(bus_no);
  #else

  		ret = i2c_set_bus_num(bus_no);

  #endif

  		if (ret)

  			printf("Failure changing bus number (%d)
  ", ret);

  	}

  
  	return ret ? CMD_RET_FAILURE : 0;

  }

  #endif  /* defined(CONFIG_SYS_I2C) */

  /**
   * do_i2c_bus_speed() - Handle the "i2c speed" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.
   */

  static int do_i2c_bus_speed(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])

  {
  	int speed, ret=0;

  #ifdef CONFIG_DM_I2C
  	struct udevice *bus;
  
  	if (i2c_get_cur_bus(&bus))
  		return 1;
  #endif
  	if (argc == 1) {
  #ifdef CONFIG_DM_I2C

  		speed = dm_i2c_get_bus_speed(bus);

  #else
  		speed = i2c_get_bus_speed();
  #endif

  		/* querying current speed */

  		printf("Current bus speed=%d
  ", speed);
  	} else {

  		speed = simple_strtoul(argv[1], NULL, 10);
  		printf("Setting bus speed to %d Hz
  ", speed);

  #ifdef CONFIG_DM_I2C

  		ret = dm_i2c_set_bus_speed(bus, speed);

  #else

  		ret = i2c_set_bus_speed(speed);

  #endif

  		if (ret)

  			printf("Failure changing bus speed (%d)
  ", ret);

  	}

  
  	return ret ? CMD_RET_FAILURE : 0;

  }

  /**
   * do_i2c_mm() - Handle the "i2c mm" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.
   */

  static int do_i2c_mm(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])

  {

  	return mod_i2c_mem (cmdtp, 1, flag, argc, argv);
  }

  /**
   * do_i2c_nm() - Handle the "i2c nm" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero on success, CMD_RET_USAGE in case of misuse and negative
   * on error.
   */

  static int do_i2c_nm(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])

  {
  	return mod_i2c_mem (cmdtp, 0, flag, argc, argv);
  }

  /**
   * do_i2c_reset() - Handle the "i2c reset" command-line command
   * @cmdtp:	Command data struct pointer
   * @flag:	Command flag
   * @argc:	Command-line argument count
   * @argv:	Array of command-line arguments
   *
   * Returns zero always.
   */

  static int do_i2c_reset(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])

  {

  #if defined(CONFIG_DM_I2C)
  	struct udevice *bus;
  
  	if (i2c_get_cur_bus(&bus))
  		return CMD_RET_FAILURE;
  	if (i2c_deblock(bus)) {
  		printf("Error: Not supported by the driver
  ");
  		return CMD_RET_FAILURE;
  	}
  #elif defined(CONFIG_SYS_I2C)

  	i2c_init(I2C_ADAP->speed, I2C_ADAP->slaveaddr);
  #else

  	i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);

  #endif

  	return 0;
  }
  
  static cmd_tbl_t cmd_i2c_sub[] = {

  #if defined(CONFIG_SYS_I2C) || defined(CONFIG_DM_I2C)