Eric Lee / smarc-uboot

Download as
Browse Code ยป

Commit 169b50efe2635952d9679268860a3e37aa13adf6

Authored by xypron.glpk@gmx.de
Committed by Tom Rini
1 parent f59a3b21f6
Exists in smarc_8mq_lf_v2020.04 and in 17 other branches 8qm-imx_v2020.04_5.4.70_2.3.0, emb_lf_v2022.04, pitx_8mp_lf_v2020.04, smarc-8m-android-10.0.0_2.6.0, smarc-8m-android-11.0.0_2.0.0, smarc-8mp-android-11.0.0_2.0.0, smarc-imx6_v2018.03_4.14.98_2.0.0_ga, smarc-imx7_v2018.03_4.14.98_2.0.0_ga, smarc-imx_v2018.03_4.14.78_1.0.0_ga, smarc_8m-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8m-imx_v2019.04_4.19.35_1.1.0, smarc_8m_00d0-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2019.04_4.19.35_1.1.0, smarc_8mm-imx_v2020.04_5.4.24_2.1.0, smarc_8mp_lf_v2020.04, smarc_8mq-imx_v2020.04_5.4.24_2.1.0

board/BuR/common: incorrect check of dtb 

The logical expression to check the dtb is incorrect in
load_devicetree.

The problem was indicated by cppcheck.

The inconsistent variable name dtppart is changed to dtbpart.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Hannes Schmelzer <oe5hpm@oevsv.at>
Acked-by: Hannes Schmelzer <oe5hpm@oevsv.at>

Showing 1 changed file with 3 additions and 3 deletions Side-by-side Diff

board/BuR/common/common.c
Diff comments   View file @ 169b50e
... ... @@ -264,13 +264,13 @@
264 264 #else
265 265 char *dtbname = getenv("dtb");
266 266 char *dtbdev = getenv("dtbdev");
267   - char *dtppart = getenv("dtbpart");
268   - if (!dtbdev || !dtbdev || !dtbname) {
  267 + char *dtbpart = getenv("dtbpart");
  268 + if (!dtbdev || !dtbpart || !dtbname) {
269 269 printf("%s: <dtbdev>/<dtbpart>/<dtb> missing.\n", __func__);
270 270 return -1;
271 271 }
272 272  
273   - if (fs_set_blk_dev(dtbdev, dtppart, FS_TYPE_EXT)) {
  273 + if (fs_set_blk_dev(dtbdev, dtbpart, FS_TYPE_EXT)) {
274 274 puts("load_devicetree: set_blk_dev failed.\n");
275 275 return -1;
276 276 }