cmd: ubi: remove unnecessary logical constraint

A size_t variable can never be negative. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Tom Rini <trini@konsulko.com> Reviewed-by: Heiko Schocher <hs@denx.de>

cmd: ubi: remove unnecessary logical constraint
A size_t variable can never be negative. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Tom Rini <trini@konsulko.com> Reviewed-by: Heiko Schocher <hs@denx.de>
xypron.glpk@gmx.de · Heiko Schocher
1 parent f6c1df44b8
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
cmd/ubi.c
@@ -308,7 +308,7 @@
 		return ENODEV;
  
 	rsvd_bytes = vol->reserved_pebs * (ubi->leb_size - vol->data_pad);
-	if (size < 0 || size > rsvd_bytes) {
+	if (size > rsvd_bytes) {
 		printf("size > volume size! Aborting!\n");
 		return EINVAL;
 	}
...	...	@@ -308,7 +308,7 @@
308	308	return ENODEV;
309	309
310	310	rsvd_bytes = vol->reserved_pebs * (ubi->leb_size - vol->data_pad);
311		- if (size < 0 \|\| size > rsvd_bytes) {
	311	+ if (size > rsvd_bytes) {
312	312	printf("size > volume size! Aborting!\n");
313	313	return EINVAL;
314	314	}