Commit 1d8104fe8897c5fec3e03b4165bc67c57eeeaa72

Authored by Simon Glass
1 parent f66153be19

buildman: Don't default to -e when building current source

We probably don't need to enable this option by default. It is useful to
display only failure boards (not errors) and it is easy to add -e if it
is required. Also update the docs.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Albert Aribaud <albert.u.boot@aribaud.net>

Showing 2 changed files with 12 additions and 14 deletions Side-by-side Diff

tools/buildman/README
... ... @@ -85,10 +85,10 @@
85 85 valid value, and all will be well. Otherwise buildman will perform random
86 86 actions. Use -n to check what the random actions might be.
87 87  
88   -If you just want to build the current source tree, leave off the -b flag.
89   -This will display results and errors as they happen. You can still look
90   -at them later using -s. Note that buildman will assume that the source
91   -has changed, and will build all specified boards in this case.
  88 +If you just want to build the current source tree, leave off the -b flag
  89 +and add -e. This will display results and errors as they happen. You can
  90 +still look at them later using -se. Note that buildman will assume that the
  91 +source has changed, and will build all specified boards in this case.
92 92  
93 93 Buildman is optimised for building many commits at once, for many boards.
94 94 On multi-core machines, Buildman is fast because it uses most of the
... ... @@ -693,9 +693,9 @@
693 693 ==================
694 694  
695 695 If you have made changes and want to do a quick sanity check of the
696   -currently-checked-out source, run buildman without the -b flag. This will
697   -build the selected boards and display build status and errors as it runs
698   -(i.e. -v amd -e are enabled automatically).
  696 +currently checked-out source, run buildman without the -b flag. This will
  697 +build the selected boards and display build status as it runs (i.e. -v is
  698 +enabled automatically). Use -e to see errors/warnings as well.
699 699  
700 700  
701 701 Other options
... ... @@ -752,7 +752,7 @@
752 752 flag to see the full errors and -l to see which boards caused which errors.
753 753  
754 754 If you really want to see build results as they happen, use -v when doing a
755   -build (-e will be enabled automatically).
  755 +build (and -e to see the errors/warnings too).
756 756  
757 757 You don't need to stick around on that branch while buildman is running. It
758 758 checks out its own copy of the source code, so you can change branches,
... ... @@ -816,11 +816,10 @@
816 816  
817 817 This has mostly be written in my spare time as a response to my difficulties
818 818 in testing large series of patches. Apart from tidying up there is quite a
819   -bit of scope for improvement. Things like better error diffs, easier access
820   -to log files, error display while building. Also it would be nice it buildman
821   -could 'hunt' for problems, perhaps by building a few boards for each arch,
822   -or checking commits for changed files and building only boards which use
823   -those files.
  819 +bit of scope for improvement. Things like better error diffs and easier
  820 +access to log files. Also it would be nice it buildman could 'hunt' for
  821 +problems, perhaps by building a few boards for each arch, or checking
  822 +commits for changed files and building only boards which use those files.
824 823  
825 824  
826 825 Credits
tools/buildman/control.py
... ... @@ -188,7 +188,6 @@
188 188 else:
189 189 series = None
190 190 options.verbose = True
191   - options.show_errors = True
192 191  
193 192 # By default we have one thread per CPU. But if there are not enough jobs
194 193 # we can have fewer threads and use a high '-j' value for make.