sf: Use unsigned type for buffers

The verify code is broken on archs with signed char. Fix it. Signed-off-by: Simon Glass <sjg@chromium.org>

sf: Use unsigned type for buffers
The verify code is broken on archs with signed char. Fix it. Signed-off-by: Simon Glass <sjg@chromium.org>
Simon Glass
1 parent 363464f993
Showing 1 changed file with 4 additions and 4 deletions Side-by-side Diff
common/cmd_sf.c
@@ -369,8 +369,8 @@
  * @param vbuf		Verification buffer
  * @return 0 if ok, -1 on error
  */
-static int spi_flash_test(struct spi_flash *flash, char *buf, ulong len,
-			   ulong offset, char *vbuf)
+static int spi_flash_test(struct spi_flash *flash, uint8_t *buf, ulong len,
+			   ulong offset, uint8_t *vbuf)
 {
 	struct test_info test;
 	int i;
  
@@ -431,9 +431,9 @@
 {
 	unsigned long offset;
 	unsigned long len;
-	char *buf = (char *)CONFIG_SYS_TEXT_BASE;
+	uint8_t *buf = (uint8_t *)CONFIG_SYS_TEXT_BASE;
 	char *endp;
-	char *vbuf;
+	uint8_t *vbuf;
 	int ret;
  
 	offset = simple_strtoul(argv[1], &endp, 16);
...	...	@@ -369,8 +369,8 @@
369	369	* @param vbuf Verification buffer
370	370	* @return 0 if ok, -1 on error
371	371	*/
372		-static int spi_flash_test(struct spi_flash flash, char buf, ulong len,
373		- ulong offset, char *vbuf)
	372	+static int spi_flash_test(struct spi_flash flash, uint8_t buf, ulong len,
	373	+ ulong offset, uint8_t *vbuf)
374	374	{
375	375	struct test_info test;
376	376	int i;
377	377
...	...	@@ -431,9 +431,9 @@
431	431	{
432	432	unsigned long offset;
433	433	unsigned long len;
434		- char buf = (char )CONFIG_SYS_TEXT_BASE;
	434	+ uint8_t buf = (uint8_t )CONFIG_SYS_TEXT_BASE;
435	435	char *endp;
436		- char *vbuf;
	436	+ uint8_t *vbuf;
437	437	int ret;
438	438
439	439	offset = simple_strtoul(argv[1], &endp, 16);