Commit 248a0488bfbb2eb16dee408a976d5f4b5546bb51
1 parent
df3b23ae3a
Exists in
v2017.01-smarct4x
and in
37 other branches
spi: Add brackets and tidy defines in spi.h
Some of the #defines in spi.h are not bracketed. To avoid future mistakes add brackets. Also add an explanatory comment for SPI_CONN_DUAL_... Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
Showing 1 changed file with 12 additions and 12 deletions Side-by-side Diff
include/spi.h
| ... | ... | @@ -30,24 +30,24 @@ |
| 30 | 30 | #define SPI_XFER_MMAP 0x08 /* Memory Mapped start */ |
| 31 | 31 | #define SPI_XFER_MMAP_END 0x10 /* Memory Mapped End */ |
| 32 | 32 | #define SPI_XFER_ONCE (SPI_XFER_BEGIN | SPI_XFER_END) |
| 33 | -#define SPI_XFER_U_PAGE (1 << 5) | |
| 33 | +#define SPI_XFER_U_PAGE (1 << 5) | |
| 34 | 34 | |
| 35 | 35 | /* SPI TX operation modes */ |
| 36 | -#define SPI_OPM_TX_QPP 1 << 0 | |
| 36 | +#define SPI_OPM_TX_QPP (1 << 0) | |
| 37 | 37 | |
| 38 | 38 | /* SPI RX operation modes */ |
| 39 | -#define SPI_OPM_RX_AS 1 << 0 | |
| 40 | -#define SPI_OPM_RX_DOUT 1 << 1 | |
| 41 | -#define SPI_OPM_RX_DIO 1 << 2 | |
| 42 | -#define SPI_OPM_RX_QOF 1 << 3 | |
| 43 | -#define SPI_OPM_RX_QIOF 1 << 4 | |
| 44 | -#define SPI_OPM_RX_EXTN SPI_OPM_RX_AS | SPI_OPM_RX_DOUT | \ | |
| 39 | +#define SPI_OPM_RX_AS (1 << 0) | |
| 40 | +#define SPI_OPM_RX_DOUT (1 << 1) | |
| 41 | +#define SPI_OPM_RX_DIO (1 << 2) | |
| 42 | +#define SPI_OPM_RX_QOF (1 << 3) | |
| 43 | +#define SPI_OPM_RX_QIOF (1 << 4) | |
| 44 | +#define SPI_OPM_RX_EXTN (SPI_OPM_RX_AS | SPI_OPM_RX_DOUT | \ | |
| 45 | 45 | SPI_OPM_RX_DIO | SPI_OPM_RX_QOF | \ |
| 46 | - SPI_OPM_RX_QIOF | |
| 46 | + SPI_OPM_RX_QIOF) | |
| 47 | 47 | |
| 48 | -/* SPI bus connection options */ | |
| 49 | -#define SPI_CONN_DUAL_SHARED 1 << 0 | |
| 50 | -#define SPI_CONN_DUAL_SEPARATED 1 << 1 | |
| 48 | +/* SPI bus connection options - see enum spi_dual_flash */ | |
| 49 | +#define SPI_CONN_DUAL_SHARED (1 << 0) | |
| 50 | +#define SPI_CONN_DUAL_SEPARATED (1 << 1) | |
| 51 | 51 | |
| 52 | 52 | /* Header byte that marks the start of the message */ |
| 53 | 53 | #define SPI_PREAMBLE_END_BYTE 0xec |