USB: gadget: atmel: zero out allocated requests

A UDC's alloc_request method should zero out the newly allocated request. Ensure the Atmel driver does so. This issue was found by code inspection, following the investigation of an intermittent issue with ci_udc, which was tracked down to failing to zero out allocated requests following some of my changes. All other UDC drivers already zero out requests in one way or another. Signed-off-by: Stephen Warren <swarren@nvidia.com>

USB: gadget: atmel: zero out allocated requests
A UDC's alloc_request method should zero out the newly allocated request. Ensure the Atmel driver does so. This issue was found by code inspection, following the investigation of an intermittent issue with ci_udc, which was tracked down to failing to zero out allocated requests following some of my changes. All other UDC drivers already zero out requests in one way or another. Signed-off-by: Stephen Warren <swarren@nvidia.com>
Stephen Warren · Marek Vasut
1 parent 639e9903c2
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
drivers/usb/gadget/atmel_usba_udc.c
@@ -314,7 +314,7 @@
  
 	DBG(DBG_GADGET, "ep_alloc_request: %p, 0x%x\n", _ep, gfp_flags);
  
-	req = malloc(sizeof(struct usba_request));
+	req = calloc(1, sizeof(struct usba_request));
 	if (!req)
 		return NULL;
...	...	@@ -314,7 +314,7 @@
314	314
315	315	DBG(DBG_GADGET, "ep_alloc_request: %p, 0x%x\n", _ep, gfp_flags);
316	316
317		- req = malloc(sizeof(struct usba_request));
	317	+ req = calloc(1, sizeof(struct usba_request));
318	318	if (!req)
319	319	return NULL;
320	320