Eric Lee / smarc-uboot

Download as
Browse Code ยป

Commit 3f05f087c37ec6b408dfd3b0a864c59749b5b8e1

Authored by Philippe Reynes
Committed by Tom Rini
1 parent 53dc8ae66c
Exists in smarc_8mq_lf_v2020.04 and in 9 other branches 8qm-imx_v2020.04_5.4.70_2.3.0, emb_lf_v2022.04, pitx_8mp_lf_v2020.04, smarc-8m-android-10.0.0_2.6.0, smarc-8m-android-11.0.0_2.0.0, smarc-8mp-android-11.0.0_2.0.0, smarc_8mm-imx_v2020.04_5.4.24_2.1.0, smarc_8mp_lf_v2020.04, smarc_8mq-imx_v2020.04_5.4.24_2.1.0

test/cmd_ut.c: fix cmd_ut_category 

In the function cmd_ut_category, the prefix is used with
the function strncmp to know if the prefix should be
removed from the test name, even if the prefix is NULL.

To avoid this issue, we consider that a prefix NULL
mean no prefix. So we only try to remove the prefix
from the test_name if the prefix is not NULL, then
we avoid to call the function strncmp with a NULL
prefix.

Reported-by: Coverity CID 281110
Fixes: 4ad4edfe ("cmd_ut: add a parameter prefix to the function cmd_ut_category")
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -26,7 +26,7 @@
26 26 const char *test_name = test->name;
27 27  
28 28 /* Remove the prefix */
29   - if (!strncmp(test_name, prefix, prefix_len))
  29 + if (prefix && !strncmp(test_name, prefix, prefix_len))
30 30 test_name += prefix_len;
31 31  
32 32 if (argc > 1 && strcmp(argv[1], test_name))