Eric Lee / smarc-uboot

Download as
Browse Code ยป

Commit 4c509343abe693d7ee835c39ded1dc10149ff91c

Authored by Simon Glass
1 parent 410b10f1e3
Exists in v2017.01-smarct4x and in 34 other branches 8qm-imx_v2020.04_5.4.70_2.3.0, emb_lf_v2022.04, pitx_8mp_lf_v2020.04, smarc-8m-android-10.0.0_2.6.0, smarc-8m-android-11.0.0_2.0.0, smarc-8mp-android-11.0.0_2.0.0, smarc-imx6_v2018.03_4.14.98_2.0.0_ga, smarc-imx7_v2017.03_4.9.11_1.0.0_ga, smarc-imx7_v2018.03_4.14.98_2.0.0_ga, smarc-imx_v2017.03_4.9.11_1.0.0_ga, smarc-imx_v2017.03_4.9.88_2.0.0_ga, smarc-imx_v2017.03_o8.1.0_1.3.0_8m, smarc-imx_v2018.03_4.14.78_1.0.0_ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_2.0.0_ga, smarc_8m-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8m-imx_v2019.04_4.19.35_1.1.0, smarc_8m_00d0-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2019.04_4.19.35_1.1.0, smarc_8mm-imx_v2020.04_5.4.24_2.1.0, smarc_8mp_lf_v2020.04, smarc_8mq-imx_v2020.04_5.4.24_2.1.0, smarc_8mq_lf_v2020.04, ti-u-boot-2015.07, v2015.07-smarct33, v2015.07-smarct33-emmc, v2015.07-smarct4x, v2016.05-dlt, v2016.05-smarct3x, v2016.05-smarct3x-emmc, v2016.05-smarct4x, v2017.01-smarct3x, v2017.01-smarct3x-emmc

Fix comment nits in board_f.c 

Try to make it a little clearer.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Showing 1 changed file with 4 additions and 5 deletions Side-by-side Diff

... ... @@ -73,7 +73,7 @@
73 73 #endif
74 74  
75 75 /*
76   - * sjg: IMO this code should be
  76 + * TODO(sjg@chromium.org): IMO this code should be
77 77 * refactored to a single function, something like:
78 78 *
79 79 * void led_set_state(enum led_colour_t colour, int on);
... ... @@ -300,7 +300,7 @@
300 300 {
301 301 #ifdef CONFIG_SYS_SDRAM_BASE
302 302 /*
303   - * Detect whether we have so much RAM it goes past the end of our
  303 + * Detect whether we have so much RAM that it goes past the end of our
304 304 * 32-bit address space. If so, clip the usable RAM so it doesn't.
305 305 */
306 306 if (gd->ram_top < CONFIG_SYS_SDRAM_BASE)
... ... @@ -507,7 +507,7 @@
507 507 static int reserve_fdt(void)
508 508 {
509 509 /*
510   - * If the device tree is sitting immediate above our image then we
  510 + * If the device tree is sitting immediately above our image then we
511 511 * must relocate it. If it is embedded in the data section, then it
512 512 * will be relocated with other data.
513 513 */
... ... @@ -535,7 +535,7 @@
535 535 gd->start_addr_sp &= ~0xf;
536 536  
537 537 /*
538   - * let the architecture specific code tailor gd->start_addr_sp and
  538 + * let the architecture-specific code tailor gd->start_addr_sp and
539 539 * gd->irq_sp
540 540 */
541 541 return arch_reserve_stacks();
... ... @@ -556,7 +556,6 @@
556 556 /*
557 557 * Save local variables to board info struct
558 558 */
559   -
560 559 bd->bi_memstart = CONFIG_SYS_SDRAM_BASE; /* start of memory */
561 560 bd->bi_memsize = gd->ram_size; /* size in bytes */
562 561