Eric Lee / smarc-uboot

Download as
Browse Code ยป

Commit 5312838dd5b3959907d6c4f0ec3e04954210fafc

Authored by Mario Six
Committed by Stefan Roese
1 parent d3525b6bb0
Exists in smarc_8mq_lf_v2020.04 and in 17 other branches 8qm-imx_v2020.04_5.4.70_2.3.0, emb_lf_v2022.04, pitx_8mp_lf_v2020.04, smarc-8m-android-10.0.0_2.6.0, smarc-8m-android-11.0.0_2.0.0, smarc-8mp-android-11.0.0_2.0.0, smarc-imx6_v2018.03_4.14.98_2.0.0_ga, smarc-imx7_v2018.03_4.14.98_2.0.0_ga, smarc-imx_v2018.03_4.14.78_1.0.0_ga, smarc_8m-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8m-imx_v2019.04_4.19.35_1.1.0, smarc_8m_00d0-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2019.04_4.19.35_1.1.0, smarc_8mm-imx_v2020.04_5.4.24_2.1.0, smarc_8mp_lf_v2020.04, smarc_8mq-imx_v2020.04_5.4.24_2.1.0

cfi_flash: Use u8 pointers instead of void pointers 

According to the C standard, pointer arithmetic for pointers of type
void is undefined behavior (the assumption that they're 8-bit wide is a
GCC-specific assumption). In the interest of keeping the code
standards-compliant, and also better communicate intent, switch all
void* variables where pointer arithmetic is used to u8* variables.

Signed-off-by: Mario Six <mario.six@gdsys.cc>
Signed-off-by: Stefan Roese <sr@denx.de>

Showing 1 changed file with 4 additions and 4 deletions Side-by-side Diff

drivers/mtd/cfi_flash.c
Diff comments   View file @ 5312838
... ... @@ -491,7 +491,7 @@
491 491 static int flash_toggle(flash_info_t *info, flash_sect_t sect,
492 492 uint offset, uchar cmd)
493 493 {
494   - void *addr;
  494 + u8 *addr;
495 495 cfiword_t cword;
496 496 int retval;
497 497  
... ... @@ -872,9 +872,9 @@
872 872 flash_sect_t sector;
873 873 int cnt;
874 874 int retcode;
875   - void *src = cp;
876   - void *dst = (void *)dest;
877   - void *dst2 = dst;
  875 + u8 *src = cp;
  876 + u8 *dst = (u8 *)dest;
  877 + u8 *dst2 = dst;
878 878 int flag = 1;
879 879 uint offset = 0;
880 880 unsigned int shift;