cmd/led.c: Remove unnecessary check on 'cmd' value

We first check that if argc is less than 2 we return CMD_RET_USAGE. We then see if argc is greater than 2 and if so call get_led_cmd() to set 'cmd' and otherwise set it to LEDST_COUNT (which will always be positive as it's an enum with 0 already assigned). Therefore the test on if cmd is less than 0 will always be false and simply be omitted. Reported by clang-3.8. Signed-off-by: Tom Rini <trini@konsulko.com>

cmd/led.c: Remove unnecessary check on 'cmd' value
We first check that if argc is less than 2 we return CMD_RET_USAGE. We then see if argc is greater than 2 and if so call get_led_cmd() to set 'cmd' and otherwise set it to LEDST_COUNT (which will always be positive as it's an enum with 0 already assigned). Therefore the test on if cmd is less than 0 will always be false and simply be omitted. Reported by clang-3.8. Signed-off-by: Tom Rini <trini@konsulko.com>
Tom Rini
1 parent 9398b8ce5f
Showing 1 changed file with 0 additions and 2 deletions Side-by-side Diff
cmd/led.c
@@ -90,8 +90,6 @@
 		return list_leds();
  
 	cmd = argc > 2 ? get_led_cmd(argv[2]) : LEDST_COUNT;
-	if (cmd < 0)
-		return CMD_RET_USAGE;
 #ifdef CONFIG_LED_BLINK
 	if (cmd == LEDST_BLINK) {
 		if (argc < 4)
...	...	@@ -90,8 +90,6 @@
90	90	return list_leds();
91	91
92	92	cmd = argc > 2 ? get_led_cmd(argv[2]) : LEDST_COUNT;
93		- if (cmd < 0)
94		- return CMD_RET_USAGE;
95	93	#ifdef CONFIG_LED_BLINK
96	94	if (cmd == LEDST_BLINK) {
97	95	if (argc < 4)