Eric Lee / smarc-uboot | Embedian Git Server

Commit 875143f32428b8317a2b890b34a1eeb31cbf8a53

Authored by Alexey Brodkin 2015-01-13 22:10:24 +0800

Committed by Joe Hershberger 2015-01-31 05:55:00 +0800

Exists in v2017.01-smarct4x and in 37 other branches

net/designware: add error message on DMA reset timeout

If for some reason DMA module fails to reset user oserves only this:
--->---
# dhcp
Trying dwmac.e0018000
FAIL
--->---

This message makes not much sense.
With proposed change error message will be more helpful:
--->---
# dhcp
Trying dwmac.e0018000
DMA reset timeout
FAIL
--->---

For example user may do power toggle to recover board functionality.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@altera.com>
Cc: Albert Aribaud <albert.u.boot@aribaud.net>
Cc: Tom Rini <trini@ti.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Pavel Machek <pavel@denx.de>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
Cc: Ian Campbell <ijc@hellion.org.uk>
Cc: Marek Vasut <marex@denx.de>
Reviewed-by: Tom Rini <trini@ti.com>
Acked-by: Pavel Machek <pavel@denx.de>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>

Showing 1 changed file with 3 additions and 1 deletions Side-by-side Diff

drivers/net/designware.c

drivers/net/designware.c

Diff comments View file @ 875143f

...	...	@@ -236,8 +236,10 @@
236	236
237	237	start = get_timer(0);
238	238	while (readl(&dma_p->busmode) & DMAMAC_SRST) {
239		- if (get_timer(start) >= CONFIG_MACRESET_TIMEOUT)
	239	+ if (get_timer(start) >= CONFIG_MACRESET_TIMEOUT) {
	240	+ printf("DMA reset timeout\n");
240	241	return -1;
	242	+ }
241	243
242	244	mdelay(100);
243	245	};