Fix memory leak in mmc_read()

There is be a path through mmc_read in drivers/mmc/mmc.c where malloc'd memory is not freed before exiting mmc_read: it occurs if mmc_set_blocklen() returns a non-zero value. Reported-by: Quentin Armitage <Quentin@Armitage.org.uk> Signed-off-by: Wolfgang Denk <wd@denx.de>

Fix memory leak in mmc_read()
There is be a path through mmc_read in drivers/mmc/mmc.c where malloc'd memory is not freed before exiting mmc_read: it occurs if mmc_set_blocklen() returns a non-zero value. Reported-by: Quentin Armitage <Quentin@Armitage.org.uk> Signed-off-by: Wolfgang Denk <wd@denx.de>
Wolfgang Denk
1 parent 6258b04e9a
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
drivers/mmc/mmc.c
@@ -179,7 +179,7 @@
 	err = mmc_set_blocklen(mmc, mmc->read_bl_len);
  
 	if (err)
-		return err;
+		goto free_buffer;
  
 	for (i = startblock; i <= endblock; i++) {
 		int segment_size;
...	...	@@ -179,7 +179,7 @@
179	179	err = mmc_set_blocklen(mmc, mmc->read_bl_len);
180	180
181	181	if (err)
182		- return err;
	182	+ goto free_buffer;
183	183
184	184	for (i = startblock; i <= endblock; i++) {
185	185	int segment_size;