Eric Lee / smarc-uboot

Download as
Browse Code ยป

Commit 9413ad4f0def2e06a5042106a6e1650a1aa03a5a

Authored by Simon Glass
1 parent 8f4b612333
Exists in smarc_8mq_lf_v2020.04 and in 17 other branches 8qm-imx_v2020.04_5.4.70_2.3.0, emb_lf_v2022.04, pitx_8mp_lf_v2020.04, smarc-8m-android-10.0.0_2.6.0, smarc-8m-android-11.0.0_2.0.0, smarc-8mp-android-11.0.0_2.0.0, smarc-imx6_v2018.03_4.14.98_2.0.0_ga, smarc-imx7_v2018.03_4.14.98_2.0.0_ga, smarc-imx_v2018.03_4.14.78_1.0.0_ga, smarc_8m-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8m-imx_v2019.04_4.19.35_1.1.0, smarc_8m_00d0-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2019.04_4.19.35_1.1.0, smarc_8mm-imx_v2020.04_5.4.24_2.1.0, smarc_8mp_lf_v2020.04, smarc_8mq-imx_v2020.04_5.4.24_2.1.0

dm: led: Support toggling LEDs 

Add support for toggling an LED into the uclass interface. This can be
efficiently implemented by the driver.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Ziping Chen <techping.chan@gmail.com>

Showing 3 changed files with 33 additions and 0 deletions Side-by-side Diff

drivers/led/led_gpio.c
Diff comments   View file @ 9413ad4
... ... @@ -21,12 +21,19 @@
21 21 static int gpio_led_set_state(struct udevice *dev, enum led_state_t state)
22 22 {
23 23 struct led_gpio_priv *priv = dev_get_priv(dev);
  24 + int ret;
24 25  
25 26 if (!dm_gpio_is_valid(&priv->gpio))
26 27 return -EREMOTEIO;
27 28 switch (state) {
28 29 case LEDST_OFF:
29 30 case LEDST_ON:
  31 + break;
  32 + case LEDST_TOGGLE:
  33 + ret = dm_gpio_get_value(&priv->gpio);
  34 + if (ret < 0)
  35 + return ret;
  36 + state = !ret;
30 37 break;
31 38 default:
32 39 return -ENOSYS;
... ... @@ -20,6 +20,7 @@
20 20 enum led_state_t {
21 21 LEDST_OFF = 0,
22 22 LEDST_ON = 1,
  23 + LEDST_TOGGLE,
23 24  
24 25 LEDST_COUNT,
25 26 };
... ... @@ -53,6 +53,31 @@
53 53 }
54 54 DM_TEST(dm_test_led_gpio, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
55 55  
  56 +/* Test that we can toggle LEDs */
  57 +static int dm_test_led_toggle(struct unit_test_state *uts)
  58 +{
  59 + const int offset = 1;
  60 + struct udevice *dev, *gpio;
  61 +
  62 + /*
  63 + * Check that we can manipulate an LED. LED 1 is connected to GPIO
  64 + * bank gpio_a, offset 1.
  65 + */
  66 + ut_assertok(uclass_get_device(UCLASS_LED, 1, &dev));
  67 + ut_assertok(uclass_get_device(UCLASS_GPIO, 1, &gpio));
  68 + ut_asserteq(0, sandbox_gpio_get_value(gpio, offset));
  69 + ut_assertok(led_set_state(dev, LEDST_TOGGLE));
  70 + ut_asserteq(1, sandbox_gpio_get_value(gpio, offset));
  71 + ut_asserteq(LEDST_ON, led_get_state(dev));
  72 +
  73 + ut_assertok(led_set_state(dev, LEDST_TOGGLE));
  74 + ut_asserteq(0, sandbox_gpio_get_value(gpio, offset));
  75 + ut_asserteq(LEDST_OFF, led_get_state(dev));
  76 +
  77 + return 0;
  78 +}
  79 +DM_TEST(dm_test_led_toggle, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
  80 +
56 81 /* Test obtaining an LED by label */
57 82 static int dm_test_led_label(struct unit_test_state *uts)
58 83 {