Eric Lee / smarc-uboot

Download as
Browse Code ยป

Commit a09431da381ce8d1b4d48e1cbca5f2b4eea662f4

Authored by pekon gupta
Committed by Tom Rini
1 parent 9233279f8e
Exists in v2017.01-smarct4x and in 40 other branches 8qm-imx_v2020.04_5.4.70_2.3.0, emb_lf_v2022.04, imx_v2015.04_4.1.15_1.0.0_ga, pitx_8mp_lf_v2020.04, smarc-8m-android-10.0.0_2.6.0, smarc-8m-android-11.0.0_2.0.0, smarc-8mp-android-11.0.0_2.0.0, smarc-imx6_v2018.03_4.14.98_2.0.0_ga, smarc-imx7_v2017.03_4.9.11_1.0.0_ga, smarc-imx7_v2018.03_4.14.98_2.0.0_ga, smarc-imx_v2015.04_4.1.15_1.0.0_ga, smarc-imx_v2017.03_4.9.11_1.0.0_ga, smarc-imx_v2017.03_4.9.88_2.0.0_ga, smarc-imx_v2017.03_o8.1.0_1.3.0_8m, smarc-imx_v2018.03_4.14.78_1.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_2.0.0_ga, smarc_8m-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8m-imx_v2019.04_4.19.35_1.1.0, smarc_8m_00d0-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2018.03_4.14.98_2.0.0_ga, smarc_8mm-imx_v2019.04_4.19.35_1.1.0, smarc_8mm-imx_v2020.04_5.4.24_2.1.0, smarc_8mp_lf_v2020.04, smarc_8mq-imx_v2020.04_5.4.24_2.1.0, smarc_8mq_lf_v2020.04, ti-u-boot-2015.07, v2014.07, v2014.07-smarct33, v2014.07-smartmen, v2015.07-smarct33, v2015.07-smarct33-emmc, v2015.07-smarct4x, v2016.05-dlt, v2016.05-smarct3x, v2016.05-smarct3x-emmc, v2016.05-smarct4x, v2017.01-smarct3x, v2017.01-smarct3x-emmc

mtd: nand: omap_gpmc: minor cleanup of omap_correct_data_bch 

This patch tries to avoid some local pointer dereferences, by using common
local variables in omap_correct_data_bch()

Signed-off-by: Pekon Gupta <pekon@ti.com>
Reviewed-by: Stefan Roese <sr@denx.de>

Showing 1 changed file with 5 additions and 5 deletions Side-by-side Diff

drivers/mtd/nand/omap_gpmc.c
Diff comments   View file @ a09431d
... ... @@ -331,7 +331,7 @@
331 331 {
332 332 struct nand_chip *chip = mtd->priv;
333 333 struct omap_nand_info *info = chip->priv;
334   - uint32_t eccbytes = chip->ecc.bytes;
  334 + struct nand_ecc_ctrl *ecc = &chip->ecc;
335 335 uint32_t error_count = 0, error_max;
336 336 uint32_t error_loc[8];
337 337 enum bch_level bch_type;
... ... @@ -340,7 +340,7 @@
340 340 uint32_t byte_pos, bit_pos;
341 341  
342 342 /* check calculated ecc */
343   - for (i = 0; i < chip->ecc.bytes && !ecc_flag; i++) {
  343 + for (i = 0; i < ecc->bytes && !ecc_flag; i++) {
344 344 if (calc_ecc[i] != 0x00)
345 345 ecc_flag = 1;
346 346 }
... ... @@ -349,7 +349,7 @@
349 349  
350 350 /* check for whether its a erased-page */
351 351 ecc_flag = 0;
352   - for (i = 0; i < chip->ecc.bytes && !ecc_flag; i++) {
  352 + for (i = 0; i < ecc->bytes && !ecc_flag; i++) {
353 353 if (read_ecc[i] != 0xff)
354 354 ecc_flag = 1;
355 355 }
... ... @@ -363,7 +363,7 @@
363 363 switch (info->ecc_scheme) {
364 364 case OMAP_ECC_BCH8_CODE_HW:
365 365 bch_type = BCH_8_BIT;
366   - omap_reverse_list(calc_ecc, eccbytes - 1);
  366 + omap_reverse_list(calc_ecc, ecc->bytes - 1);
367 367 break;
368 368 default:
369 369 return -EINVAL;
... ... @@ -379,7 +379,7 @@
379 379 switch (info->ecc_scheme) {
380 380 case OMAP_ECC_BCH8_CODE_HW:
381 381 /* 14th byte in ECC is reserved to match ROM layout */
382   - error_max = SECTOR_BYTES + (eccbytes - 1);
  382 + error_max = SECTOR_BYTES + (ecc->bytes - 1);
383 383 break;
384 384 default:
385 385 return -EINVAL;