mmc: Remove ops from struct mmc and put in mmc_ops

Remove the in-structure ops and put them in mmc_ops with a constant pointer to it. This makes the mmc structure smaller as well as conserving code space (in theory). All in-tree drivers are converted as well; this is done in a single patch in order to not break git bisect. Changes since V1: Fix compilation b0rked issue on omap platforms where OMAP_GPIO was not set. Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>

mmc: Remove ops from struct mmc and put in mmc_ops
Remove the in-structure ops and put them in mmc_ops with a constant pointer to it. This makes the mmc structure smaller as well as conserving code space (in theory). All in-tree drivers are converted as well; this is done in a single patch in order to not break git bisect. Changes since V1: Fix compilation b0rked issue on omap platforms where OMAP_GPIO was not set. Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
Pantelis Antoniou
1 parent 2c072c958b
Showing 17 changed files with 184 additions and 119 deletions Side-by-side Diff
drivers/mmc/arm_pl180_mmci.c
drivers/mmc/bfin_sdh.c
drivers/mmc/davinci_mmc.c
drivers/mmc/dw_mmc.c
drivers/mmc/fsl_esdhc.c
drivers/mmc/ftsdc010_mci.c
drivers/mmc/gen_atmel_mci.c
drivers/mmc/mmc.c
drivers/mmc/mmc_spi.c
drivers/mmc/mxcmmc.c
drivers/mmc/mxsmmc.c
drivers/mmc/omap_hsmmc.c
drivers/mmc/pxa_mmc_gen.c
drivers/mmc/sdhci.c
drivers/mmc/sh_mmcif.c
drivers/mmc/tegra_mmc.c
include/mmc.h
@@ -335,6 +335,12 @@
 	udelay(CLK_CHANGE_DELAY);
 }
  
+static const struct mmc_ops arm_pl180_mmci_ops = {
+	.send_cmd = host_request,
+	.set_ios = host_set_ios,
+	.init = mmc_host_reset,
+};
+
 /*
  * mmc_host_init - initialize the mmc controller.
  * Set initial clock and power for mmc slot.
@@ -360,11 +366,7 @@
 	sdi_u32 = readl(&host->base->mask0) & ~SDI_MASK0_MASK;
 	writel(sdi_u32, &host->base->mask0);
 	strncpy(dev->name, host->name, sizeof(dev->name));
-	dev->send_cmd = host_request;
-	dev->set_ios = host_set_ios;
-	dev->init = mmc_host_reset;
-	dev->getcd = NULL;
-	dev->getwp = NULL;
+	dev->ops = &arm_pl180_mmci_ops;
 	dev->host_caps = host->caps;
 	dev->voltages = host->voltages;
 	dev->f_min = host->clock_min;
@@ -274,6 +274,11 @@
 	return 0;
 }
  
+static const struct mmc_ops bfin_mmc_ops = {
+	.send_cmd	= bfin_sdh_request,
+	.set_ios	= bfin_sdh_set_ios,
+	.init		= bfin_sdh_init,
+};
  
 int bfin_mmc_init(bd_t *bis)
 {
@@ -284,11 +289,7 @@
 	if (!mmc)
 		return -ENOMEM;
 	sprintf(mmc->name, "Blackfin SDH");
-	mmc->send_cmd = bfin_sdh_request;
-	mmc->set_ios = bfin_sdh_set_ios;
-	mmc->init = bfin_sdh_init;
-	mmc->getcd = NULL;
-	mmc->getwp = NULL;
+	mmc->ops = &bfin_mmc_ops;
 	mmc->host_caps = MMC_MODE_4BIT;
  
 	mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
@@ -363,6 +363,12 @@
 		dmmc_set_clock(mmc, mmc->clock);
 }
  
+static const struct mmc_ops dmmc_ops = {
+	.send_cmd	= dmmc_send_cmd,
+	.set_ios	= dmmc_set_ios,
+	.init		= dmmc_init,
+};
+
 /* Called from board_mmc_init during startup. Can be called multiple times
  * depending on the number of slots available on board and controller
  */
@@ -375,12 +381,7 @@
  
 	sprintf(mmc->name, "davinci");
 	mmc->priv = host;
-	mmc->send_cmd = dmmc_send_cmd;
-	mmc->set_ios = dmmc_set_ios;
-	mmc->init = dmmc_init;
-	mmc->getcd = NULL;
-	mmc->getwp = NULL;
-
+	mmc->ops = &dmmc_ops;
 	mmc->f_min = 200000;
 	mmc->f_max = 25000000;
 	mmc->voltages = host->voltages;
@@ -343,6 +343,12 @@
 	return 0;
 }
  
+static const struct mmc_ops dwmci_ops = {
+	.send_cmd	= dwmci_send_cmd,
+	.set_ios	= dwmci_set_ios,
+	.init		= dwmci_init,
+};
+
 int add_dwmci(struct dwmci_host *host, u32 max_clk, u32 min_clk)
 {
 	struct mmc *mmc;
@@ -358,9 +364,7 @@
 	host->mmc = mmc;
  
 	sprintf(mmc->name, "%s", host->name);
-	mmc->send_cmd = dwmci_send_cmd;
-	mmc->set_ios = dwmci_set_ios;
-	mmc->init = dwmci_init;
+	mmc->ops = &dwmci_ops;
 	mmc->f_min = min_clk;
 	mmc->f_max = max_clk;
  
@@ -524,6 +524,13 @@
 		printf("MMC/SD: Reset never completed.\n");
 }
  
+static const struct mmc_ops esdhc_ops = {
+	.send_cmd	= esdhc_send_cmd,
+	.set_ios	= esdhc_set_ios,
+	.init		= esdhc_init,
+	.getcd		= esdhc_getcd,
+};
+
 int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg)
 {
 	struct fsl_esdhc *regs;
@@ -548,12 +555,7 @@
 				| SYSCTL_IPGEN | SYSCTL_CKEN);
  
 	mmc->priv = cfg;
-	mmc->send_cmd = esdhc_send_cmd;
-	mmc->set_ios = esdhc_set_ios;
-	mmc->init = esdhc_init;
-	mmc->getcd = esdhc_getcd;
-	mmc->getwp = NULL;
-
+	mmc->ops = &esdhc_ops;
 	voltage_caps = 0;
 	caps = regs->hostcapblt;
  
@@ -316,6 +316,12 @@
 	return 0;
 }
  
+static const struct mmc_ops ftsdc010_ops = {
+	.send_cmd	= ftsdc010_request,
+	.set_ios	= ftsdc010_set_ios,
+	.init		= ftsdc010_init,
+};
+
 int ftsdc010_mmc_init(int devid)
 {
 	struct mmc *mmc;
@@ -347,10 +353,7 @@
 	mmc->priv  = chip;
  
 	sprintf(mmc->name, "ftsdc010");
-	mmc->send_cmd  = ftsdc010_request;
-	mmc->set_ios   = ftsdc010_set_ios;
-	mmc->init      = ftsdc010_init;
-
+	mmc->ops = &ftsdc010_ops;
 	mmc->host_caps = MMC_MODE_HS | MMC_MODE_HS_52MHz;
 	switch (readl(&regs->bwr) & FTSDC010_BWR_CAPS_MASK) {
 	case FTSDC010_BWR_CAPS_4BIT:
@@ -344,6 +344,12 @@
 	return 0;
 }
  
+static const struct mmc_ops atmel_mci_ops = {
+	.send_cmd	= mci_send_cmd,
+	.set_ios	= mci_set_ios,
+	.init		= mci_init,
+};
+
 /*
  * This is the only exported function
  *
@@ -360,11 +366,7 @@
  
 	strcpy(mmc->name, "mci");
 	mmc->priv = regs;
-	mmc->send_cmd = mci_send_cmd;
-	mmc->set_ios = mci_set_ios;
-	mmc->init = mci_init;
-	mmc->getcd = NULL;
-	mmc->getwp = NULL;
+	mmc->ops = &atmel_mci_ops;
  
 	/* need to be able to pass these in on a board by board basis */
 	mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
@@ -37,8 +37,8 @@
 	wp = board_mmc_getwp(mmc);
  
 	if (wp < 0) {
-		if (mmc->getwp)
-			wp = mmc->getwp(mmc);
+		if (mmc->ops->getwp)
+			wp = mmc->ops->getwp(mmc);
 		else
 			wp = 0;
 	}
@@ -63,7 +63,7 @@
  
 	printf("CMD_SEND:%d\n", cmd->cmdidx);
 	printf("\t\tARG\t\t\t 0x%08X\n", cmd->cmdarg);
-	ret = mmc->send_cmd(mmc, cmd, data);
+	ret = mmc->ops->send_cmd(mmc, cmd, data);
 	switch (cmd->resp_type) {
 		case MMC_RSP_NONE:
 			printf("\t\tMMC_RSP_NONE\n");
@@ -106,7 +106,7 @@
 			break;
 	}
 #else
-	ret = mmc->send_cmd(mmc, cmd, data);
+	ret = mmc->ops->send_cmd(mmc, cmd, data);
 #endif
 	return ret;
 }
@@ -578,8 +578,8 @@
 	cd = board_mmc_getcd(mmc);
  
 	if (cd < 0) {
-		if (mmc->getcd)
-			cd = mmc->getcd(mmc);
+		if (mmc->ops->getcd)
+			cd = mmc->ops->getcd(mmc);
 		else
 			cd = 1;
 	}
@@ -751,7 +751,8 @@
  
 static void mmc_set_ios(struct mmc *mmc)
 {
-	mmc->set_ios(mmc);
+	if (mmc->ops->set_ios)
+		mmc->ops->set_ios(mmc);
 }
  
 void mmc_set_clock(struct mmc *mmc, uint clock)
@@ -1207,7 +1208,8 @@
 {
 	int err;
  
-	if (mmc_getcd(mmc) == 0) {
+	/* we pretend there's no card when init is NULL */
+	if (mmc_getcd(mmc) == 0 || mmc->ops->init == NULL) {
 		mmc->has_init = 0;
 #if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
 		printf("MMC: no card present\n");
@@ -1218,7 +1220,8 @@
 	if (mmc->has_init)
 		return 0;
  
-	err = mmc->init(mmc);
+	/* made sure it's not NULL earlier */
+	err = mmc->ops->init(mmc);
  
 	if (err)
 		return err;
@@ -255,6 +255,12 @@
 	return 0;
 }
  
+static const struct mmc_ops mmc_spi_ops = {
+	.send_cmd	= mmc_spi_request,
+	.set_ios	= mmc_spi_set_ios,
+	.init		= mmc_spi_init_p,
+};
+
 struct mmc *mmc_spi_init(uint bus, uint cs, uint speed, uint mode)
 {
 	struct mmc *mmc;
@@ -269,11 +275,7 @@
 		return NULL;
 	}
 	sprintf(mmc->name, "MMC_SPI");
-	mmc->send_cmd = mmc_spi_request;
-	mmc->set_ios = mmc_spi_set_ios;
-	mmc->init = mmc_spi_init_p;
-	mmc->getcd = NULL;
-	mmc->getwp = NULL;
+	mmc->ops = &mmc_spi_ops;
 	mmc->host_caps = MMC_MODE_SPI;
  
 	mmc->voltages = MMC_SPI_VOLTAGE;
@@ -485,6 +485,12 @@
 	return 0;
 }
  
+static const struct mmc_ops mxcmci_ops = {
+	.send_cmd	= mxcmci_request,
+	.set_ios	= mxcmci_set_ios,
+	.init		= mxcmci_init,
+};
+
 static int mxcmci_initialize(bd_t *bis)
 {
 	struct mmc *mmc = NULL;
@@ -495,11 +501,7 @@
 		return -ENOMEM;
  
 	sprintf(mmc->name, "MXC MCI");
-	mmc->send_cmd = mxcmci_request;
-	mmc->set_ios = mxcmci_set_ios;
-	mmc->init = mxcmci_init;
-	mmc->getcd = NULL;
-	mmc->getwp = NULL;
+	mmc->ops = &mxcmci_ops;
 	mmc->host_caps = MMC_MODE_4BIT;
  
 	host->base = (struct mxcmci_regs *)CONFIG_MXC_MCI_REGS_BASE;
@@ -363,6 +363,12 @@
 	return 0;
 }
  
+static const struct mmc_ops mxsmmc_ops = {
+	.send_cmd	= mxsmmc_send_cmd,
+	.set_ios	= mxsmmc_set_ios,
+	.init		= mxsmmc_init,
+};
+
 int mxsmmc_initialize(bd_t *bis, int id, int (*wp)(int), int (*cd)(int))
 {
 	struct mmc *mmc = NULL;
@@ -400,11 +406,7 @@
 	priv->regs = mxs_ssp_regs_by_bus(id);
  
 	sprintf(mmc->name, "MXS MMC");
-	mmc->send_cmd = mxsmmc_send_cmd;
-	mmc->set_ios = mxsmmc_set_ios;
-	mmc->init = mxsmmc_init;
-	mmc->getcd = NULL;
-	mmc->getwp = NULL;
+	mmc->ops = &mxsmmc_ops;
 	mmc->priv = priv;
  
 	mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34;
@@ -35,14 +35,24 @@
 #include <asm/arch/mmc_host_def.h>
 #include <asm/arch/sys_proto.h>
  
+/* simplify defines to OMAP_HSMMC_USE_GPIO */
+#if (defined(CONFIG_OMAP_GPIO) && !defined(CONFIG_SPL_BUILD)) || \
+	(defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_GPIO_SUPPORT))
+#define OMAP_HSMMC_USE_GPIO
+#else
+#undef OMAP_HSMMC_USE_GPIO
+#endif
+
 /* common definitions for all OMAPs */
 #define SYSCTL_SRC	(1 << 25)
 #define SYSCTL_SRD	(1 << 26)
  
 struct omap_hsmmc_data {
 	struct hsmmc *base_addr;
+#ifdef OMAP_HSMMC_USE_GPIO
 	int cd_gpio;
 	int wp_gpio;
+#endif
 };
  
 /* If we fail after 1 second wait, something is really bad */
@@ -54,8 +64,7 @@
 static struct mmc hsmmc_dev[3];
 static struct omap_hsmmc_data hsmmc_dev_data[3];
  
-#if (defined(CONFIG_OMAP_GPIO) && !defined(CONFIG_SPL_BUILD)) || \
-	(defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_GPIO_SUPPORT))
+#ifdef OMAP_HSMMC_USE_GPIO
 static int omap_mmc_setup_gpio_in(int gpio, const char *label)
 {
 	if (!gpio_is_valid(gpio))
@@ -69,26 +78,6 @@
  
 	return gpio;
 }
-
-static int omap_mmc_getcd(struct mmc *mmc)
-{
-	int cd_gpio = ((struct omap_hsmmc_data *)mmc->priv)->cd_gpio;
-	return gpio_get_value(cd_gpio);
-}
-
-static int omap_mmc_getwp(struct mmc *mmc)
-{
-	int wp_gpio = ((struct omap_hsmmc_data *)mmc->priv)->wp_gpio;
-	return gpio_get_value(wp_gpio);
-}
-#else
-static inline int omap_mmc_setup_gpio_in(int gpio, const char *label)
-{
-	return -1;
-}
-
-#define omap_mmc_getcd NULL
-#define omap_mmc_getwp NULL
 #endif
  
 #if defined(CONFIG_OMAP44XX) && defined(CONFIG_TWL6030_POWER)
@@ -213,7 +202,7 @@
 }
  
  
-static int mmc_init_setup(struct mmc *mmc)
+static int omap_hsmmc_init_setup(struct mmc *mmc)
 {
 	struct hsmmc *mmc_base;
 	unsigned int reg_val;
@@ -322,7 +311,7 @@
 	}
 }
  
-static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
+static int omap_hsmmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 			struct mmc_data *data)
 {
 	struct hsmmc *mmc_base;
@@ -552,7 +541,7 @@
 	return 0;
 }
  
-static void mmc_set_ios(struct mmc *mmc)
+static void omap_hsmmc_set_ios(struct mmc *mmc)
 {
 	struct hsmmc *mmc_base;
 	unsigned int dsor = 0;
@@ -606,6 +595,44 @@
 	writel(readl(&mmc_base->sysctl) | CEN_ENABLE, &mmc_base->sysctl);
 }
  
+#ifdef OMAP_HSMMC_USE_GPIO
+static int omap_hsmmc_getcd(struct mmc *mmc)
+{
+	struct omap_hsmmc_data *priv_data = mmc->priv;
+	int cd_gpio;
+
+	/* if no CD return as 1 */
+	cd_gpio = priv_data->cd_gpio;
+	if (cd_gpio < 0)
+		return 1;
+
+	return gpio_get_value(cd_gpio);
+}
+
+static int omap_hsmmc_getwp(struct mmc *mmc)
+{
+	struct omap_hsmmc_data *priv_data = mmc->priv;
+	int wp_gpio;
+
+	/* if no WP return as 0 */
+	wp_gpio = priv_data->wp_gpio;
+	if (wp_gpio < 0)
+		return 0;
+
+	return gpio_get_value(wp_gpio);
+}
+#endif
+
+static const struct mmc_ops omap_hsmmc_ops = {
+	.send_cmd	= omap_hsmmc_send_cmd,
+	.set_ios	= omap_hsmmc_set_ios,
+	.init		= omap_hsmmc_init_setup,
+#ifdef OMAP_HSMMC_USE_GPIO
+	.getcd		= omap_hsmmc_getcd,
+	.getwp		= omap_hsmmc_getwp,
+#endif
+};
+
 int omap_mmc_init(int dev_index, uint host_caps_mask, uint f_max, int cd_gpio,
 		int wp_gpio)
 {
@@ -615,9 +642,7 @@
 			     MMC_MODE_HC;
  
 	sprintf(mmc->name, "OMAP SD/MMC");
-	mmc->send_cmd = mmc_send_cmd;
-	mmc->set_ios = mmc_set_ios;
-	mmc->init = mmc_init_setup;
+	mmc->ops = &omap_hsmmc_ops;
 	mmc->priv = priv_data;
  
 	switch (dev_index) {
  
  
@@ -647,13 +672,11 @@
 		priv_data->base_addr = (struct hsmmc *)OMAP_HSMMC1_BASE;
 		return 1;
 	}
+#ifdef OMAP_HSMMC_USE_GPIO
+	/* on error gpio values are set to -1, which is what we want */
 	priv_data->cd_gpio = omap_mmc_setup_gpio_in(cd_gpio, "mmc_cd");
-	if (priv_data->cd_gpio != -1)
-		mmc->getcd = omap_mmc_getcd;
-
 	priv_data->wp_gpio = omap_mmc_setup_gpio_in(wp_gpio, "mmc_wp");
-	if (priv_data->wp_gpio != -1)
-		mmc->getwp = omap_mmc_getwp;
+#endif
  
 	mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
 	mmc->host_caps = host_caps_val & ~host_caps_mask;
@@ -366,6 +366,12 @@
 	return 0;
 }
  
+static const struct mmc_ops pxa_mmc_ops = {
+	.send_cmd	= pxa_mmc_request,
+	.set_ios	= pxa_mmc_set_ios,
+	.init		= pxa_mmc_init,
+};
+
 int pxa_mmc_register(int card_index)
 {
 	struct mmc *mmc;
@@ -397,10 +403,7 @@
 	mmc->priv = priv;
  
 	sprintf(mmc->name, "PXA MMC");
-	mmc->send_cmd	= pxa_mmc_request;
-	mmc->set_ios	= pxa_mmc_set_ios;
-	mmc->init	= pxa_mmc_init;
-	mmc->getcd	= NULL;
+	mmc->ops = &pxa_mmc_ops;
  
 	mmc->voltages	= MMC_VDD_32_33 | MMC_VDD_33_34;
 	mmc->f_max	= PXAMMC_MAX_SPEED;
@@ -430,6 +430,13 @@
 	return 0;
 }
  
+
+static const struct mmc_ops sdhci_ops = {
+	.send_cmd	= sdhci_send_command,
+	.set_ios	= sdhci_set_ios,
+	.init		= sdhci_init,
+};
+
 int add_sdhci(struct sdhci_host *host, u32 max_clk, u32 min_clk)
 {
 	struct mmc *mmc;
@@ -445,11 +452,7 @@
 	host->mmc = mmc;
  
 	sprintf(mmc->name, "%s", host->name);
-	mmc->send_cmd = sdhci_send_command;
-	mmc->set_ios = sdhci_set_ios;
-	mmc->init = sdhci_init;
-	mmc->getcd = NULL;
-	mmc->getwp = NULL;
+	mmc->ops = &sdhci_ops;
  
 	caps = sdhci_readl(host, SDHCI_CAPABILITIES);
 #ifdef CONFIG_MMC_SDMA
@@ -574,6 +574,12 @@
 	return 0;
 }
  
+static const struct mmc_ops sh_mmcif_ops = {
+	.send_cmd	= sh_mmcif_request,
+	.set_ios	= sh_mmcif_set_ios,
+	.init		= sh_mmcif_init,
+};
+
 int mmcif_mmc_init(void)
 {
 	int ret = 0;
@@ -595,11 +601,7 @@
 	mmc->host_caps = MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT |
 			 MMC_MODE_8BIT | MMC_MODE_HC;
 	memcpy(mmc->name, DRIVER_NAME, sizeof(DRIVER_NAME));
-	mmc->send_cmd = sh_mmcif_request;
-	mmc->set_ios = sh_mmcif_set_ios;
-	mmc->init = sh_mmcif_init;
-	mmc->getcd = NULL;
-	mmc->getwp = NULL;
+	mmc->ops = &sh_mmcif_ops;
 	host->regs = (struct sh_mmcif_regs *)CONFIG_SH_MMCIF_ADDR;
 	host->clk = CONFIG_SH_MMCIF_CLK;
 	mmc->priv = host;
@@ -314,7 +314,7 @@
 	return 0;
 }
  
-static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
+static int tegra_mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 			struct mmc_data *data)
 {
 	void *buf;
@@ -396,7 +396,7 @@
 	host->clock = clock;
 }
  
-static void mmc_set_ios(struct mmc *mmc)
+static void tegra_mmc_set_ios(struct mmc *mmc)
 {
 	struct mmc_host *host = mmc->priv;
 	unsigned char ctrl;
@@ -464,7 +464,7 @@
 	pad_init_mmc(host);
 }
  
-static int mmc_core_init(struct mmc *mmc)
+static int tegra_mmc_core_init(struct mmc *mmc)
 {
 	struct mmc_host *host = (struct mmc_host *)mmc->priv;
 	unsigned int mask;
@@ -521,6 +521,13 @@
 	return 1;
 }
  
+static const struct mmc_ops tegra_mmc_ops = {
+	.send_cmd	= tegra_mmc_send_cmd,
+	.set_ios	= tegra_mmc_set_ios,
+	.init		= tegra_mmc_core_init,
+	.getcd		= tegra_mmc_getcd,
+};
+
 static int do_mmc_init(int dev_index)
 {
 	struct mmc_host *host;
@@ -558,11 +565,7 @@
  
 	sprintf(mmc->name, "Tegra SD/MMC");
 	mmc->priv = host;
-	mmc->send_cmd = mmc_send_cmd;
-	mmc->set_ios = mmc_set_ios;
-	mmc->init = mmc_core_init;
-	mmc->getcd = tegra_mmc_getcd;
-	mmc->getwp = NULL;
+	mmc->ops = &tegra_mmc_ops;
  
 	mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
 	mmc->host_caps = 0;
@@ -250,6 +250,18 @@
 	uint blocksize;
 };
  
+/* forward decl. */
+struct mmc;
+
+struct mmc_ops {
+	int (*send_cmd)(struct mmc *mmc,
+			struct mmc_cmd *cmd, struct mmc_data *data);
+	void (*set_ios)(struct mmc *mmc);
+	int (*init)(struct mmc *mmc);
+	int (*getcd)(struct mmc *mmc);
+	int (*getwp)(struct mmc *mmc);
+};
+
 struct mmc {
 	struct list_head link;
 	char name[32];
@@ -283,12 +295,7 @@
 	u64 capacity_rpmb;
 	u64 capacity_gp[4];
 	block_dev_desc_t block_dev;
-	int (*send_cmd)(struct mmc *mmc,
-			struct mmc_cmd *cmd, struct mmc_data *data);
-	void (*set_ios)(struct mmc *mmc);
-	int (*init)(struct mmc *mmc);
-	int (*getcd)(struct mmc *mmc);
-	int (*getwp)(struct mmc *mmc);
+	const struct mmc_ops *ops;
 	uint b_max;
 	char op_cond_pending;	/* 1 if we are waiting on an op_cond command */
 	char init_in_progress;	/* 1 if we have done mmc_start_init() */
...	...	@@ -335,6 +335,12 @@
335	335	udelay(CLK_CHANGE_DELAY);
336	336	}
337	337
	338	+static const struct mmc_ops arm_pl180_mmci_ops = {
	339	+ .send_cmd = host_request,
	340	+ .set_ios = host_set_ios,
	341	+ .init = mmc_host_reset,
	342	+};
	343	+
338	344	/*
339	345	* mmc_host_init - initialize the mmc controller.
340	346	* Set initial clock and power for mmc slot.
...	...	@@ -360,11 +366,7 @@
360	366	sdi_u32 = readl(&host->base->mask0) & ~SDI_MASK0_MASK;
361	367	writel(sdi_u32, &host->base->mask0);
362	368	strncpy(dev->name, host->name, sizeof(dev->name));
363		- dev->send_cmd = host_request;
364		- dev->set_ios = host_set_ios;
365		- dev->init = mmc_host_reset;
366		- dev->getcd = NULL;
367		- dev->getwp = NULL;
	369	+ dev->ops = &arm_pl180_mmci_ops;
368	370	dev->host_caps = host->caps;
369	371	dev->voltages = host->voltages;
370	372	dev->f_min = host->clock_min;
...	...	@@ -274,6 +274,11 @@
274	274	return 0;
275	275	}
276	276
	277	+static const struct mmc_ops bfin_mmc_ops = {
	278	+ .send_cmd = bfin_sdh_request,
	279	+ .set_ios = bfin_sdh_set_ios,
	280	+ .init = bfin_sdh_init,
	281	+};
277	282
278	283	int bfin_mmc_init(bd_t *bis)
279	284	{
...	...	@@ -284,11 +289,7 @@
284	289	if (!mmc)
285	290	return -ENOMEM;
286	291	sprintf(mmc->name, "Blackfin SDH");
287		- mmc->send_cmd = bfin_sdh_request;
288		- mmc->set_ios = bfin_sdh_set_ios;
289		- mmc->init = bfin_sdh_init;
290		- mmc->getcd = NULL;
291		- mmc->getwp = NULL;
	292	+ mmc->ops = &bfin_mmc_ops;
292	293	mmc->host_caps = MMC_MODE_4BIT;
293	294
294	295	mmc->voltages = MMC_VDD_32_33 \| MMC_VDD_33_34;
...	...	@@ -363,6 +363,12 @@
363	363	dmmc_set_clock(mmc, mmc->clock);
364	364	}
365	365
	366	+static const struct mmc_ops dmmc_ops = {
	367	+ .send_cmd = dmmc_send_cmd,
	368	+ .set_ios = dmmc_set_ios,
	369	+ .init = dmmc_init,
	370	+};
	371	+
366	372	/* Called from board_mmc_init during startup. Can be called multiple times
367	373	* depending on the number of slots available on board and controller
368	374	*/
...	...	@@ -375,12 +381,7 @@
375	381
376	382	sprintf(mmc->name, "davinci");
377	383	mmc->priv = host;
378		- mmc->send_cmd = dmmc_send_cmd;
379		- mmc->set_ios = dmmc_set_ios;
380		- mmc->init = dmmc_init;
381		- mmc->getcd = NULL;
382		- mmc->getwp = NULL;
383		-
	384	+ mmc->ops = &dmmc_ops;
384	385	mmc->f_min = 200000;
385	386	mmc->f_max = 25000000;
386	387	mmc->voltages = host->voltages;
...	...	@@ -343,6 +343,12 @@
343	343	return 0;
344	344	}
345	345
	346	+static const struct mmc_ops dwmci_ops = {
	347	+ .send_cmd = dwmci_send_cmd,
	348	+ .set_ios = dwmci_set_ios,
	349	+ .init = dwmci_init,
	350	+};
	351	+
346	352	int add_dwmci(struct dwmci_host *host, u32 max_clk, u32 min_clk)
347	353	{
348	354	struct mmc *mmc;
...	...	@@ -358,9 +364,7 @@
358	364	host->mmc = mmc;
359	365
360	366	sprintf(mmc->name, "%s", host->name);
361		- mmc->send_cmd = dwmci_send_cmd;
362		- mmc->set_ios = dwmci_set_ios;
363		- mmc->init = dwmci_init;
	367	+ mmc->ops = &dwmci_ops;
364	368	mmc->f_min = min_clk;
365	369	mmc->f_max = max_clk;
366	370
...	...	@@ -524,6 +524,13 @@
524	524	printf("MMC/SD: Reset never completed.\n");
525	525	}
526	526
	527	+static const struct mmc_ops esdhc_ops = {
	528	+ .send_cmd = esdhc_send_cmd,
	529	+ .set_ios = esdhc_set_ios,
	530	+ .init = esdhc_init,
	531	+ .getcd = esdhc_getcd,
	532	+};
	533	+
527	534	int fsl_esdhc_initialize(bd_t bis, struct fsl_esdhc_cfg cfg)
528	535	{
529	536	struct fsl_esdhc *regs;
...	...	@@ -548,12 +555,7 @@
548	555	\| SYSCTL_IPGEN \| SYSCTL_CKEN);
549	556
550	557	mmc->priv = cfg;
551		- mmc->send_cmd = esdhc_send_cmd;
552		- mmc->set_ios = esdhc_set_ios;
553		- mmc->init = esdhc_init;
554		- mmc->getcd = esdhc_getcd;
555		- mmc->getwp = NULL;
556		-
	558	+ mmc->ops = &esdhc_ops;
557	559	voltage_caps = 0;
558	560	caps = regs->hostcapblt;
559	561
...	...	@@ -316,6 +316,12 @@
316	316	return 0;
317	317	}
318	318
	319	+static const struct mmc_ops ftsdc010_ops = {
	320	+ .send_cmd = ftsdc010_request,
	321	+ .set_ios = ftsdc010_set_ios,
	322	+ .init = ftsdc010_init,
	323	+};
	324	+
319	325	int ftsdc010_mmc_init(int devid)
320	326	{
321	327	struct mmc *mmc;
...	...	@@ -347,10 +353,7 @@
347	353	mmc->priv = chip;
348	354
349	355	sprintf(mmc->name, "ftsdc010");
350		- mmc->send_cmd = ftsdc010_request;
351		- mmc->set_ios = ftsdc010_set_ios;
352		- mmc->init = ftsdc010_init;
353		-
	356	+ mmc->ops = &ftsdc010_ops;
354	357	mmc->host_caps = MMC_MODE_HS \| MMC_MODE_HS_52MHz;
355	358	switch (readl(&regs->bwr) & FTSDC010_BWR_CAPS_MASK) {
356	359	case FTSDC010_BWR_CAPS_4BIT:
...	...	@@ -344,6 +344,12 @@
344	344	return 0;
345	345	}
346	346
	347	+static const struct mmc_ops atmel_mci_ops = {
	348	+ .send_cmd = mci_send_cmd,
	349	+ .set_ios = mci_set_ios,
	350	+ .init = mci_init,
	351	+};
	352	+
347	353	/*
348	354	* This is the only exported function
349	355	*
...	...	@@ -360,11 +366,7 @@
360	366
361	367	strcpy(mmc->name, "mci");
362	368	mmc->priv = regs;
363		- mmc->send_cmd = mci_send_cmd;
364		- mmc->set_ios = mci_set_ios;
365		- mmc->init = mci_init;
366		- mmc->getcd = NULL;
367		- mmc->getwp = NULL;
	369	+ mmc->ops = &atmel_mci_ops;
368	370
369	371	/* need to be able to pass these in on a board by board basis */
370	372	mmc->voltages = MMC_VDD_32_33 \| MMC_VDD_33_34;
...	...	@@ -37,8 +37,8 @@
37	37	wp = board_mmc_getwp(mmc);
38	38
39	39	if (wp < 0) {
40		- if (mmc->getwp)
41		- wp = mmc->getwp(mmc);
	40	+ if (mmc->ops->getwp)
	41	+ wp = mmc->ops->getwp(mmc);
42	42	else
43	43	wp = 0;
44	44	}
...	...	@@ -63,7 +63,7 @@
63	63
64	64	printf("CMD_SEND:%d\n", cmd->cmdidx);
65	65	printf("\t\tARG\t\t\t 0x%08X\n", cmd->cmdarg);
66		- ret = mmc->send_cmd(mmc, cmd, data);
	66	+ ret = mmc->ops->send_cmd(mmc, cmd, data);
67	67	switch (cmd->resp_type) {
68	68	case MMC_RSP_NONE:
69	69	printf("\t\tMMC_RSP_NONE\n");
...	...	@@ -106,7 +106,7 @@
106	106	break;
107	107	}
108	108	#else
109		- ret = mmc->send_cmd(mmc, cmd, data);
	109	+ ret = mmc->ops->send_cmd(mmc, cmd, data);
110	110	#endif
111	111	return ret;
112	112	}
...	...	@@ -578,8 +578,8 @@
578	578	cd = board_mmc_getcd(mmc);
579	579
580	580	if (cd < 0) {
581		- if (mmc->getcd)
582		- cd = mmc->getcd(mmc);
	581	+ if (mmc->ops->getcd)
	582	+ cd = mmc->ops->getcd(mmc);
583	583	else
584	584	cd = 1;
585	585	}
...	...	@@ -751,7 +751,8 @@
751	751
752	752	static void mmc_set_ios(struct mmc *mmc)
753	753	{
754		- mmc->set_ios(mmc);
	754	+ if (mmc->ops->set_ios)
	755	+ mmc->ops->set_ios(mmc);
755	756	}
756	757
757	758	void mmc_set_clock(struct mmc *mmc, uint clock)
...	...	@@ -1207,7 +1208,8 @@
1207	1208	{
1208	1209	int err;
1209	1210
1210		- if (mmc_getcd(mmc) == 0) {
	1211	+ /* we pretend there's no card when init is NULL */
	1212	+ if (mmc_getcd(mmc) == 0 \|\| mmc->ops->init == NULL) {
1211	1213	mmc->has_init = 0;
1212	1214	#if !defined(CONFIG_SPL_BUILD) \|\| defined(CONFIG_SPL_LIBCOMMON_SUPPORT)
1213	1215	printf("MMC: no card present\n");
...	...	@@ -1218,7 +1220,8 @@
1218	1220	if (mmc->has_init)
1219	1221	return 0;
1220	1222
1221		- err = mmc->init(mmc);
	1223	+ /* made sure it's not NULL earlier */
	1224	+ err = mmc->ops->init(mmc);
1222	1225
1223	1226	if (err)
1224	1227	return err;
...	...	@@ -255,6 +255,12 @@
255	255	return 0;
256	256	}
257	257
	258	+static const struct mmc_ops mmc_spi_ops = {
	259	+ .send_cmd = mmc_spi_request,
	260	+ .set_ios = mmc_spi_set_ios,
	261	+ .init = mmc_spi_init_p,
	262	+};
	263	+
258	264	struct mmc *mmc_spi_init(uint bus, uint cs, uint speed, uint mode)
259	265	{
260	266	struct mmc *mmc;
...	...	@@ -269,11 +275,7 @@
269	275	return NULL;
270	276	}
271	277	sprintf(mmc->name, "MMC_SPI");
272		- mmc->send_cmd = mmc_spi_request;
273		- mmc->set_ios = mmc_spi_set_ios;
274		- mmc->init = mmc_spi_init_p;
275		- mmc->getcd = NULL;
276		- mmc->getwp = NULL;
	278	+ mmc->ops = &mmc_spi_ops;
277	279	mmc->host_caps = MMC_MODE_SPI;
278	280
279	281	mmc->voltages = MMC_SPI_VOLTAGE;
...	...	@@ -485,6 +485,12 @@
485	485	return 0;
486	486	}
487	487
	488	+static const struct mmc_ops mxcmci_ops = {
	489	+ .send_cmd = mxcmci_request,
	490	+ .set_ios = mxcmci_set_ios,
	491	+ .init = mxcmci_init,
	492	+};
	493	+
488	494	static int mxcmci_initialize(bd_t *bis)
489	495	{
490	496	struct mmc *mmc = NULL;
...	...	@@ -495,11 +501,7 @@
495	501	return -ENOMEM;
496	502
497	503	sprintf(mmc->name, "MXC MCI");
498		- mmc->send_cmd = mxcmci_request;
499		- mmc->set_ios = mxcmci_set_ios;
500		- mmc->init = mxcmci_init;
501		- mmc->getcd = NULL;
502		- mmc->getwp = NULL;
	504	+ mmc->ops = &mxcmci_ops;
503	505	mmc->host_caps = MMC_MODE_4BIT;
504	506
505	507	host->base = (struct mxcmci_regs *)CONFIG_MXC_MCI_REGS_BASE;