Eric Lee / smarc-uboot

Download as
Browse Code ยป

Commit d23cfa097679acc00f2c28587c3473e8369e5227

Authored by Han Xu
Committed by Ye Li
1 parent 413b08f841
Exists in emb_lf_v2022.04

LFU-426: qspihdr: Coverity Issue: unchecked return value 

fix the unchecked return value(CWE-252) issue in qspihdr tool.

Signed-off-by: Han Xu <han.xu@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>

Showing 1 changed file with 12 additions and 2 deletions Side-by-side Diff

arch/arm/mach-imx/cmd_qspihdr.c
Diff comments   View file @ d23cfa0
... ... @@ -235,6 +235,7 @@
235 235 unsigned long addr;
236 236 char *endp;
237 237 void *tmp;
  238 + int ret;
238 239  
239 240 #if defined(CONFIG_MX6) || defined(CONFIG_MX7) || defined(CONFIG_ARCH_MX7ULP)
240 241 int off = QSPI_HDR_OFF + QSPI_HDR_TAG_OFF;
... ... @@ -266,7 +267,11 @@
266 267 return 1;
267 268 }
268 269 } else {
269   - spi_flash_read(flash, off, 4, &buf);
  270 + ret = spi_flash_read(flash, off, 4, &buf);
  271 + if (ret) {
  272 + printf("flash read failed, ret: %d\n", ret);
  273 + return -1;
  274 + }
270 275  
271 276 if (buf == tag) {
272 277 if (flag & FLAG_VERBOSE)
... ... @@ -398,6 +403,7 @@
398 403 char *endp;
399 404 void *tmp;
400 405 void *buf;
  406 + int ret;
401 407  
402 408 #if defined(CONFIG_MX6) || defined(CONFIG_MX7) || defined(CONFIG_ARCH_MX7ULP)
403 409 int off = QSPI_HDR_OFF;
... ... @@ -431,7 +437,11 @@
431 437 return 0;
432 438 }
433 439  
434   - spi_flash_read(flash, off, HDR_LEN, buf);
  440 + ret = spi_flash_read(flash, off, HDR_LEN, buf);
  441 + if (ret) {
  442 + printf("flash read failed, ret: %d\n", ret);
  443 + return -1;
  444 + }
435 445  
436 446 hdr_dump(buf);
437 447 free(buf);