Eric Lee / smarc-uboot

Download as
Browse Code ยป

Commit d78ecc733988d07a87c97f7f1c19171c437a8712

Authored by Baruch Siach
Committed by Heiko Schocher
1 parent 173ec35191
Exists in smarc_8mq_lf_v2020.04 and in 11 other branches 8qm-imx_v2020.04_5.4.70_2.3.0, emb_lf_v2022.04, pitx_8mp_lf_v2020.04, smarc-8m-android-10.0.0_2.6.0, smarc-8m-android-11.0.0_2.0.0, smarc-8mp-android-11.0.0_2.0.0, smarc_8m-imx_v2019.04_4.19.35_1.1.0, smarc_8mm-imx_v2019.04_4.19.35_1.1.0, smarc_8mm-imx_v2020.04_5.4.24_2.1.0, smarc_8mp_lf_v2020.04, smarc_8mq-imx_v2020.04_5.4.24_2.1.0

mvebu: turris_omnia: add note about i2c slave disable 

Code that disables the i2c slave is now in the mvtwsi i2c driver.
Platform must enable DM_I2C to use that code. Add a comment in the code
as a reminder for the planned DM_I2C migration of Turris Omnia.

Reviewed-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Showing 1 changed file with 5 additions and 1 deletions Side-by-side Diff

board/CZ.NIC/turris_omnia/turris_omnia.c
Diff comments   View file @ d78ecc7
... ... @@ -321,7 +321,11 @@
321 321 writel(OMNIA_GPP_OUT_ENA_LOW, MVEBU_GPIO0_BASE + 0x04);
322 322 writel(OMNIA_GPP_OUT_ENA_MID, MVEBU_GPIO1_BASE + 0x04);
323 323  
324   - /* Disable I2C debug mode blocking 0x64 I2C address */
  324 + /*
  325 + * Disable I2C debug mode blocking 0x64 I2C address.
  326 + * Note: that would be redundant once Turris Omnia migrates to DM_I2C,
  327 + * because the mvtwsi driver includes equivalent code.
  328 + */
325 329 i2c_debug_reg = readl(MVEBU_TWSI_BASE + MVTWSI_ARMADA_DEBUG_REG);
326 330 i2c_debug_reg &= ~(1<<18);
327 331 writel(i2c_debug_reg, MVEBU_TWSI_BASE + MVTWSI_ARMADA_DEBUG_REG);