mkimage: Require a data file when auto-fit is used

When auto-fit is used, it is not valid to create a FIT without an image file. Add a check for this to avoid a very confusing error message later ("Can't open (null): Bad address"). Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Tom Rini <trini@konsulko.com>

mkimage: Require a data file when auto-fit is used
When auto-fit is used, it is not valid to create a FIT without an image file. Add a check for this to avoid a very confusing error message later ("Can't open (null): Bad address"). Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Tom Rini <trini@konsulko.com>
Simon Glass · Tom Rini
1 parent 3c23c0feac
Showing 1 changed file with 2 additions and 0 deletions Side-by-side Diff
tools/mkimage.c
@@ -276,6 +276,8 @@
 		/* For auto_its, datafile is always 'auto' */
 		if (!params.auto_its)
 			params.datafile = datafile;
+		else if (!params.datafile)
+			usage("Missing data file for auto-FIT (use -d)");
 	} else if (type != IH_TYPE_INVALID) {
 		params.type = type;
 	}
...	...	@@ -276,6 +276,8 @@
276	276	/* For auto_its, datafile is always 'auto' */
277	277	if (!params.auto_its)
278	278	params.datafile = datafile;
	279	+ else if (!params.datafile)
	280	+ usage("Missing data file for auto-FIT (use -d)");
279	281	} else if (type != IH_TYPE_INVALID) {
280	282	params.type = type;
281	283	}