20 Aug, 2018
1 commit
-
Fix the null dereferenced issues from converity scan results.
issue id:
3618300:Dereference after null check
3618364:Dereference after null check
3618463:Dereference after null check
3618470:Explicit null dereferenced
3618520:Dereference after null checkTest: issue fixed by converity scan.
Change-Id: I577ed094a1f9b493de61b84827c0e1157a4fbd2f
Signed-off-by: Luo Ji
16 Aug, 2017
4 commits
-
We are now using an env_ prefix for environment functions. Rename these
other functions as well, for consistency:getenv_vlan()
getenv_bootm_size()
getenv_bootm_low()
getenv_bootm_mapsize()
env_get_default()Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass -
We are now using an env_ prefix for environment functions. Rename these
for consistency. Also add function comments in common.h.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass -
We are now using an env_ prefix for environment functions. Rename these
two functions for consistency. Also add function comments in common.h.Quite a few places use getenv() in a condition context, provoking a
warning from checkpatch. These are fixed up in this patch also.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass -
We are now using an env_ prefix for environment functions. Rename these
commonly used functions, for consistency. Also add function comments in
common.h.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass
08 Aug, 2017
1 commit
-
Add missing "defined" statement to fix the compile failures.
Signed-off-by: Holger Dengler
Acked-by: Joe Hershberger
22 Jan, 2017
1 commit
-
Move all of the status LED feature to drivers/led/Kconfig.
The LED status definitions were moved from the board configuration
files to the defconfig files.TBD: Move all of the definitions in the include/status_led.h to the
relevant board's defconfig files.Tested boards: CL-SOM-AM57x, CM-T335
Signed-off-by: Uri Mashiach
23 Aug, 2016
1 commit
-
At least on bfin, this "specimen" is actually allocated in the BSS and
wastes lots of memory in already tight memory conditions.Also, with the introduction of NFSv3 support, this waste got
substantially larger.Just remove it. If a board needs a specific different defragment size,
that board can override this setting.Signed-off-by: Joe Hershberger
27 May, 2016
1 commit
-
We can now successfully boot EFI applications from disk, but users
may want to also run them from a PXE setup.This patch implements rudimentary network support, allowing a payload
to send and receive network packets.With this patch, I was able to successfully run grub2 with network
access inside of QEMU's -M xlnx-ep108.Signed-off-by: Alexander Graf
08 Jan, 2016
1 commit
-
Introduced in 45b4773 (net/arp: account for ARP delay, avoid duplicate packets on timeout)
Check the arp timeout and adjust the timeout start time before the call
to eth_recv() so that the sandbox driver has the opportunity to adjust
the sandbox timer after the new start time has been recorded.Also, change the adjustment amount by 11 seconds instead of exactly the
10 seconds that the ping timout is expecting since the timeout check is
looking for the time elapsed to be greater than but not equal to the
specified delay.Signed-off-by: Joe Hershberger
Reviewed-by: Stefan Brüns
Acked-by: Simon Glass
20 Nov, 2015
1 commit
-
The console includes a global variable and several functions that are only
used by a small subset of U-Boot files. Before adding more functions, move
the definitions into their own header file.Signed-off-by: Simon Glass
30 Oct, 2015
1 commit
-
The net_boot_file_name buffer is used as storage for the bootfilename
command line argument to network boot commands such as tftp and nfs.Increase the size of this buffer to 1024 bytes as the current size of
128 bytes is restrictive for arbitrary paths on the server.Signed-off-by: Jacob Stiffler
Acked-by: Joe Hershberger
29 Oct, 2015
1 commit
-
eth_rx() in the main reception loop may trigger sending a packet which
is already timed out (or will immediately) upon reception of an ARP reply.
As long as the ARP reply is pending, the timeout handler of a packet
should be postponed.
Happens on TFTP with bad network (e.g. WLAN).Signed-off-by: Stefan Brüns
Acked-by: Joe Hershberger
07 Sep, 2015
1 commit
-
This change gives the ability to reuse the header file by other
subsystems (like e.g. dfu).Without this change compilation error emerges for the legacy update.c file.
Signed-off-by: Lukasz Majewski
Acked-by: Joe Hershberger
22 Aug, 2015
1 commit
-
Current behavior is that if CTRL+C is pressed command returns 0 that was
successful which is not correct behavior.
The easiest test case is "tftpboot 80000 uImage && echo yes"
and press CTRL+C. Then the second command is called which is incorrect.Error log:
zynq-uboot> tftpb 80000 uImage && echo yes
Gem.e000b000:7 is connected to Gem.e000b000. Reconnecting to
Gem.e000b000
Gem.e000b000 Waiting for PHY auto negotiation to complete....... done
Using Gem.e000b000 device
TFTP from server 192.168.0.102; our IP address is 192.168.0.101
Filename 'uImage'.
Load address: 0x80000
Loading: ################
Abort
yes
zynq-uboot>This patch adds -EINTR return value when CTRL+C is pressed.
Signed-off-by: Michal Simek
Reviewed-by: Tom Rini
Acked-by: Joe Hershberger
21 May, 2015
1 commit
-
Instead of checking for changes to the env each time we enter the
net_loop, use the env callbacks to update the values of the variables.
Don't update the variables when the source was programmatic, since the
variables were the source of the new value.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass
19 Apr, 2015
22 commits
-
Finish eliminating CamelCase from net.c and other failures
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within common/cmd_net.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within netconsole.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within dns.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within cdp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within sntp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within rarp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within nfs.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within bootp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within arp and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within tftp and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Update the naming convention used in the network stack functions and
variables that Ethernet drivers use to interact with it.This cleans up the temporary hacks that were added to this interface
along with the DM support.This patch has a few remaining checkpatch.pl failures that would be out
of the scope of this patch to fix (drivers that are in gross violation
of checkpatch.pl).Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
This patch cleans up the names of internal packet buffer names that are
used within the network stack and the functions that use them.Signed-off-by: Joe Hershberger
-
Use "_ethaddr" at the end of variables and drop CamelCase.
Make constant values actually 'const'.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Remove CamelCase variable naming.
Move the definition to the same compilation unit as the primary use.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
The variables around the bootfile were inconsistent and used CamelCase.
Update them to make the code more readable.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
This patch is simply clean-up to make the IPv4 type that is used match
what Linux uses. It also attempts to move all variables that are IP
addresses use good naming instead of CamelCase. No functional change.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Take a pass at plumbing errors through to the users of the network stack
Currently only the start() function errors will be returned from
NetLoop(). recv() tends not to have errors, so that is likely not worth
adding. send() certainly can return errors, but this patch does not
attempt to plumb them yet. halt() is not expected to error.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
Take the opportunity to enforce better names on newly written or
retrofitted Ethernet drivers.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
netretry previously would only retry in one specific case (your MAC
address is not set) and no other. This is basically useless. In the DM
implementation for eth it turns this into a completely useless case
since an un-configured MAC address results in not even entering the
NetLoop. The behavior is now changed to retry any failed command
(rotating through the eth adapters if ethrotate != no).It also defaulted to retry forever. It is now changed to default to not
retrySigned-off-by: Joe Hershberger
Reviewed-by: Simon Glass -
This value is not used by the network stack and is available in the
global data, so stop passing it around. For the one legacy function
that still expects it (init op on old Ethernet drivers) pass in the
global pointer version directly to avoid changing that interface.Signed-off-by: Joe Hershberger
Reported-by: Simon Glass
Reviewed-by: Simon Glass
Signed-off-by: Simon Glass
(Trival fix to remove an unneeded variable declaration in 4xx_enet.c) -
The current implementation exposes the eth_device struct to code that
needs to access the MAC address. Add a wrapper function for this to
abstract away the pointer for this operation.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass
13 Feb, 2015
1 commit
-
Drop the old checksum functions in favour of the new ones.
Signed-off-by: Simon Glass
Acked-by: Joe Hershberger
10 Oct, 2014
1 commit
-
A number of network related files were imported from the LiMon
project; these contain a somewhat unclear license statement:Copyright 1994 - 2000 Neil Russell.
(See License)I analyzed the source code of LiMon v1.4.2 which was used for this
import. It does not contain any "License" file, but the top level
directory contains a file "COPYING", which turns out to be GPL v2
of June 1991. So it is legitimate to conclude that the LiMon derived
files are also to be released under GPLv2. Mark them as such.Signed-off-by: Wolfgang Denk
