22 Nov, 2013
1 commit
-
Sometimes a commit should have notes enclosed with it rather
than withing the cover letter -- possibly even because there
is no cover letter. Add a 'Commit-notes' tag, similar to the
'Series-notes' one; lines between this tag and the next END
line are inserted in the patch right after the '---' commit
delimiter.Change-Id: I01e99ae125607dc6dec08f3be8a5a0b37f0a483d
Signed-off-by: Albert ARIBAUD
Signed-off-by: Simon Glass
(Updated README)
24 Jul, 2013
1 commit
-
Signed-off-by: Wolfgang Denk
[trini: Fixup common/cmd_io.c]
Signed-off-by: Tom Rini
16 Jul, 2013
1 commit
-
adjust instructions for the invocation of Patman's self test: the -t
flag appears to have a different meaning now, refer to the --test option
for the builtin unit test; adjust a directory location and make sure to
run the file which resides in the source directorySigned-off-by: Gerhard Sittig
Acked-by: Simon Glass
15 May, 2013
1 commit
-
Rather than a backtrace, produce a nice error message when an invalid
branch is provided to buildman.Signed-off-by: Simon Glass
10 May, 2013
2 commits
-
Patman requires python 2.7.4 to run but it doesn't
need to be placed in /usr/bin/python.
Use env to ensure that the interpreter used is
the first one on environment's $PATH on system
with several versions of Python installed.Signed-off-by: Michal Simek
Reviewed-by: Tom Rini
Acked-by: Simon Glass -
Conflicting tags can prevent buildman from building two series which exist
one after the other in a branch. There is no reason not to allow this sort
of workflow with buildman, so ignore conflicting tags in buildman.Change-Id: I2231d04d8684fe0f8fe77f8ea107e5899a3da5e8
Signed-off-by: Simon Glass
Reviewed-by: Tom Rini
19 Apr, 2013
1 commit
-
The git config parameter log.decorate is quite useful when working with git.
Patman, however can not handle the decorated output when parsing the commit.
To prevent this use the '--no-decorate' switch for git-log.Signed-off-by: Andreas Bießmann
Acked-by: Simon Glass
09 Apr, 2013
4 commits
-
For some series with lots of changes it is annoying that duplicate change
log items are not caught. It is also helpful sometimes to sort the change
logs.Add a Series-process-log tag to enable this, which can be placed in a
commit to control this.The change to the Cc: line is to fix a checkpatch warning.
Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson -
Especially with the Linux kernel, it takes a long time (a minute or more)
to test-apply the patches, so patman becomes significantly less useful.
The only real problem that is found with this apply step is trailing spaces.
Provide a -a option to skip this step, for those working with clean patches.Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson -
Patman's regular expression for detecting the start of a
commit in a git log was a little simplistic and could be
confused if the git log itself had the word "commit" as
the start of a line (as this commit does). Make patman
a little more robust.Signed-off-by: Doug Anderson
Acked-by: Simon Glass -
Often it happens that patches include tags which don't have aliases. It
is annoying that patman fails in this case, and provides no option to
continue other than adding empty tags to the .patman file.Correct this by adding a '-t' option to ignore tags that don't exist.
Print a warning instead.Since running the tests is not a common operation, move this to --test
instead, to reserve -t for this new option.Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson
05 Apr, 2013
15 commits
-
These tags are used by Gerrit, so let's ignore all of them.
Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson -
A few of the help messages are not quite right, and there is a typo
in the README. Fix these.Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson -
This comment is less than helpful. Since multiple tags are supported, add
an example of how multiple tags work.Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson -
At present something like:
Revert "arm: Add cache operations"
will try to use
Revert "arm
as a tag. Clearly this is wrong, so fix it.
If the revert is intended to be tagged, then the tag can come before
the revert, perhaps. Alternatively the 'Cc' tag can be used in the commit
messages.Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson -
checkpatch has a new type of warning, a 'CHECK'. At present patman fails
with these, which makes it less than useful.Add support for checks, making it backwards compatible with the old
checkpatch.At the same time, clean up formatting of the CheckPatches() output,
fix erroneous "internal error" if multiple patches have warnings and
be more robust to new types of problems.Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson -
The cover letter is sent to everyone who is on the Cc list for any of
the patches in the series. Sometimes it is useful to send just the cover
letter to additional people, so that they are aware of the series, but
don't need to wade through all the individual patches.Add a new Cover-letter-cc tag for this purpose.
Signed-off-by: Simon Glass
Reviewed-by: Doug Anderson -
Some versions of git don't seem to prompt you for the message ID that
your series is in reply to. Allow specifying this from the command
line.Signed-off-by: Doug Anderson
Acked-by: Simon Glass -
Although "Reviewed-by:" is a tag that gerrit adds, it's also a tag
used by upstream. Stripping it is undesirable. In fact, we should
treat it as important.Signed-off-by: Doug Anderson
Reviewed-by: Otavio Salvador
Acked-by: Simon Glass -
Add methods to find out the commits in a branch, clone a repo and
fetch from a repo.Signed-off-by: Simon Glass
-
We normally read from the current branch, but buildman will need to look
at commits from another branch. Allow the metadata to be read from any
list of commits, to provide this flexibility.Signed-off-by: Simon Glass
-
Make raise_on_error a parameter so that we can control which commands
raise and which do not. If we get an error reading the alias file, just
continue.Signed-off-by: Simon Glass
-
Rather than returning a list of things, return an object. That makes it
easier to access the returned items, and easier to extend the return
value later.Signed-off-by: Simon Glass
-
This adds a new library on top of subprocess which permits access to
the subprocess output as it is being generated. We can therefore
give the illusion that a process is running independently, but still
monitor its output so that we know what is going on.It is possible to display output on a terminal as it is generated
(a little like tee). The supplied output function is called with all
stdout/stderr data as it arrives.Signed-off-by: Simon Glass
-
Rather than the rather dull colours, use bright versions which normally
look better and are easier to read.Signed-off-by: Simon Glass
-
It is easy to detect whether or not the process is connected to a terminal,
or piped to a file. Disable ANSI colours automatically when output is
not to a terminal.Signed-off-by: Simon Glass
01 Feb, 2013
10 commits
-
To make it usable in git trees not providing a patch checker
implementation, add a command line option, allowing to suppress patch
check. While we are at it, sort debug options alphabetically.Also, do not raise an exception if checkpatch.pl is not found - just
print an error message suggesting to use the new option, and return
nonzero status.. unit test passes:
$ ./patman -t
. successfully used patman in the autotest tree to generate a patch
email (with --no-check option)
. successfully used patman in the u-boot tree to generate a patch
email
. `patman --help' now shows command line options ordered
alphabeticallySigned-off-by: Vadim Bendebury
Acked-by: Doug Anderson
Acked-by: Simon Glass -
The settings modules now has doctests, so run them.
Signed-off-by: Doug Anderson
-
There are cases that we want to support different settings (or maybe
even different aliases) for different projects. Add support for this
by:
* Adding detection for two big projects: U-Boot and Linux.
* Adding default settings for Linux (U-Boot is already good with the
standard patman defaults).
* Extend the new "settings" feature in .patman to specify per-project
settings.Signed-off-by: Doug Anderson
Acked-by: Simon Glass -
This patch adds support for a [settings] section in the .patman file.
In this section you can add settings that will affect the default
values for command-line options.Support is added in a generic way such that any setting can be updated
by just referring to the "dest" of the option that is passed to the
option parser. At the moment options that would make sense to put in
settings are "ignore_errors", "process_tags", and "verbose". You
could override them like:[settings]
ignore_errors: True
process_tags: False
verbose: TrueThe settings functionality is also used in a future change which adds
support for per-project settings.Signed-off-by: Doug Anderson
-
For Linux the best way to figure out where to send a patch is with the
"get_maintainer.pl" script. Add support for calling it from patman.
Support is added unconditionally for "scripts/get_maintainer.pl" in
case it is helpful for any other projects.Signed-off-by: Doug Anderson
-
If we're sending a cover letter make sure to CC everyone that we're
CCing on each of the individual patches.Signed-off-by: Doug Anderson
-
Currently we go through and generate the CC list for patches twice.
This gets slow when (in a future CL) we add a call to
get_maintainer.pl on Linux. Instead of doing things twice, just cache
the CC list when it is first generated.Signed-off-by: Doug Anderson
Acked-by: Simon Glass -
The Linux kernel stores checkpatch.pl in the scripts directory. Add
that to the search path to make things more automatic for kernel
development.Signed-off-by: Doug Anderson
Acked-by: Simon Glass -
Several of the patman doctests assume that patman was run with:
./patmanFix them so that they work even if patman is run with just "patman"
(because patman is in the path).Signed-off-by: Doug Anderson
Acked-by: Simon Glass -
The patman test code was failing because some extra spaces got
stripped when it was applied. These spaces are critical to the test
code working.Signed-off-by: Doug Anderson
Acked-by: Simon Glass
14 Nov, 2012
1 commit
-
Often a particular patch may change only for some versions of a series.
For versions where there is no change, issue a change log indicating
that (for example 'Changes in v4: None').For such lines, don't add a blank line afterwards, to conserve space.
Use list.insert() instead of list = [item] + list.Signed-off-by: Simon Glass
Tested-by: Stefan Roese
05 Nov, 2012
1 commit
-
The BRANCH= tag can be used to indicate the destination branch for a
commit. Ignore this tag.Also ignore the gerrit 'Commit-Ready:' tag.
Signed-off-by: Simon Glass
20 Oct, 2012
1 commit
-
Colored logs confuse patman when analyzing logs.
Add --no-color option in git log commands in case
the default config has color.Signed-off-by: Albert ARIBAUD
Acked-by: Simon Glass
Signed-off-by: Tom Rini
16 Oct, 2012
1 commit
-
Sometimes we don't get a valid filename or line number from checkpatch.pl,
for example if the patch is in a bad format. Deal with this by using a
default value, rather than a stack trace.Signed-off-by: Simon Glass