Eric Lee / smarc-uboot

21 Dec, 2019

1 commit

  • c62e6142b   fw_setenv: avoid writing environment when nothing has changed ... Browse Code »

    In the case where one deletes an already-non-existing variable, or sets
    a variable to the value it already has, there is no point in writing the
    environment back, thus reducing wear on the underlying storage
    device.

    In the case of redundant environments, if the two environments
    differ (e.g. because one is corrupt), make sure that any call of
    fw_setenv causes the two to become synchronized, even if the fw_setenv
    call does not change anything in the good copy.

    Signed-off-by: Rasmus Villemoes
    Acked-by: Joe Hershberger

    Rasmus Villemoes
     

03 Dec, 2019

1 commit

25 Sep, 2019

2 commits

  • 7ce01c78d   fw_env: fix build error ... Browse Code »

    The following error appears:

    tools/env/fw_env.c:1149:25: error: lvalue required as unary ‘&’ operand
    rc = write(fd, &ENV_REDUND_OBSOLETE, sizeof(ENV_REDUND_OBSOLETE));

    Fixes: d3716dd ("env: Rename the redundancy flags")

    Signed-off-by: Pierre-Jean Texier
    Tested-by: Joris Offouga
    Tested-by: Heiko Schocher
    Suggested-by: Heiko Schocher
    Acked-by: Joe Hershberger

    Pierre-Jean Texier
     
  • e184a3b4f   fw_env: remove duplicated definitions ... Browse Code »

    Since commit d3716dd ("env: Rename the redundancy flags"), the
    definitions of ENV_REDUND_OBSOLETE & ENV_REDUND_ACTIVE was moved
    to env.h.

    Fixes:

    tools/env/fw_env.c:122:22: error: ‘ENV_REDUND_ACTIVE’ redeclared as different kind of symbol
    static unsigned char ENV_REDUND_ACTIVE = 1;
    ^~~~~~~~~~~~~~~~~
    In file included from tools/env/fw_env.c:13:
    include/env.h:63:2: note: previous definition of ‘ENV_REDUND_ACTIVE’ was here
    ENV_REDUND_ACTIVE = 1,
    ^~~~~~~~~~~~~~~~~
    tools/env/fw_env.c:127:22: error: ‘ENV_REDUND_OBSOLETE’ redeclared as different kind of symbol
    static unsigned char ENV_REDUND_OBSOLETE;
    ^~~~~~~~~~~~~~~~~~~
    In file included from tools/env/fw_env.c:13:
    include/env.h:62:2: note: previous definition of ‘ENV_REDUND_OBSOLETE’ was here
    ENV_REDUND_OBSOLETE = 0,

    Signed-off-by: Pierre-Jean Texier
    Tested-by: Joris Offouga
    Tested-by: Heiko Schocher
    Acked-by: Joe Hershberger

    Pierre-Jean Texier
     

12 Aug, 2019

2 commits

20 Jun, 2019

1 commit

  • a762311a6   fw_env: Add missing write failure check ... Browse Code »

    If flash_write fails, whilst we propagate this up to our caller, we need
    to avoid swapping in the new file (if we're on a filesystem) in this
    case.

    Fixes: dbc34323796b ("tools: env: Implement atomic replace for filesystem")
    Signed-off-by: Alex Kiernan

    Alex Kiernan
     

05 May, 2019

1 commit

27 Apr, 2019

1 commit

11 Sep, 2018

1 commit

  • e1df3fa36   include/version.h: workaround sysroot inc order ... Browse Code »

    On some systems the host system or even the cross sysroot can
    contain a version.h. This leads to the wrong file being picked
    up and a PLAIN_VERSION undefined error.

    This workaround symlinks the version.h into the tool folder to
    allow reordering of search folders.

    Fixes
    http://autobuild.buildroot.net/results/770/7702d5df36a6532aafdbe6e9e62709bbfa058b54/build-end.log
    http://autobuild.buildroot.net/results/e34/e3401027d2fb3ce565ca9e2456a427afd3610a87/build-end.log
    ... additional can be found with these queries ...
    http://autobuild.buildroot.net/?reason=uboot-tools-2018.03
    http://autobuild.buildroot.net/?reason=uboot-tools-2018.05

    Upstream: pending

    Signed-off-by: Matthew Weber

    Matt Weber
     

02 Jul, 2018

1 commit

28 Jun, 2018

1 commit

13 Jun, 2018

2 commits

07 May, 2018

1 commit

  • 83d290c56   SPDX: Convert all of our single license tags to Linux Kernel style ... Browse Code »
    56

    When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

11 Apr, 2018

1 commit

20 Mar, 2018

4 commits

05 Mar, 2018

1 commit

15 Feb, 2018

1 commit

28 Jan, 2018

1 commit

30 Nov, 2017

1 commit

  • 34255b92e   tools: env: Add support for direct read/write UBI volumes ... Browse Code »
    1

    Up to now we were able to read/write environment data from/to UBI
    volumes only indirectly by gluebi driver. This driver creates NAND MTD
    on top of UBI volumes, which is quite a workaroung for this use case.

    Add support for direct read/write UBI volumes in order to not use
    obsolete gluebi driver.

    Forward-ported from this patch:
    http://patchwork.ozlabs.org/patch/619305/

    Original patch:
    Signed-off-by: Marcin Niestroj

    Forward port:
    Signed-off-by: S. Lockwood-Childs

    S. Lockwood-Childs
     

21 Nov, 2017

1 commit

06 Nov, 2017

1 commit

  • 84d46e7e8   tools: env: allow to print U-Boot version ... Browse Code »
    40

    The fw_env utility family has a default environment compiled in
    which ties it quite strongly to the U-Boot source/config it has
    been built with. Allow to display the U-Boot version it has been
    built with using the -v/--version argument.

    Signed-off-by: Stefan Agner
    Reviewed-by: Lukasz Majewski

    Stefan Agner
     

16 Oct, 2017

1 commit

06 Sep, 2017

3 commits

  • 84a42069f   env: Add 'envtools' target to 'make help' ... Browse Code »

    The target is not currently mentioned anywhere. Add it to the help so
    people can find it.

    Signed-off-by: Simon Glass

    Simon Glass
     
  • 573329571   env: Fix operation of 'make environ' ... Browse Code »

    This was broken by the recent environment refactoring. Specifically:

    $ make environ
    scripts/Makefile.build:59: tools/environ/Makefile: No such file or directory
    make[1]: *** No rule to make target 'tools/environ/Makefile'. Stop.
    make: *** [Makefile:1469: environ] Error 2

    Fix this by updating the Makefile and adjusting the #include filesnames in
    two C files.

    Fixes: ec74f5f (Makefile: Rename 'env' target to 'environ')
    Reported-by: Måns Rullgård
    Signed-off-by: Simon Glass

    Simon Glass
     
  • 2d3229bea   env: Fix out of tree building of tools-all ... Browse Code »

    With the move of environment code from common/ to env/ a number of
    changes needed to be made to various make targets. We missed updating
    some of the files required for out of tree builds of the tools. Correct
    the 'environ' target to know that we need to work under tools/env/ still
    (not tools/environ/) and then update the wrappers in env_attr.c and
    env_flags.c to point to the new correct file.

    Reported-by: Peter Robinson
    Tested-by: Peter Robinson
    Signed-off-by: Tom Rini

    Tom Rini
     

04 Sep, 2017

1 commit

  • 40fe89c6e   fix: fw_env: Prevent writing error message on special files, which don't support fsync ... Browse Code »

    According to fsync specification [1] some special files (e.g., a pipe, FIFO,
    or socket) don't support synchronization and return either EROFS or EINVAL.

    On the linux side the sys_fsync -> do_fsync() checks if the requested file
    has f_op->fsync defined. If not it returns EINVAL [2].

    This commit prevents writing error messages for files (devices), which
    do not support fsync().

    [1] - http://man7.org/linux/man-pages/man2/fsync.2.html
    [2] - http://elixir.free-electrons.com/linux/v4.13-rc6/source/fs/sync.c#L183

    Signed-off-by: Lukasz Majewski
    Acked-by: Michael Heimpold

    Lukasz Majewski
     

16 Aug, 2017

1 commit

23 Jul, 2017

1 commit

18 Apr, 2017

1 commit

13 Apr, 2017

4 commits

  • 33f0086cb   env: fix memory leak in fw_env routines ... Browse Code »

    fw_env_open allocates buffers to store the environment, but these
    buffers are never freed. This becomes quite nasty using the fw_ tools as
    library, because each access to the environment (even just reading a
    variable) generates a memory leak equal to the size of the environment.

    Fix this renaming fw_env_close() as fw_env_flush(), because the function
    really flushes the environment from RAM to storage, and add a
    fw_env_close function to free the allocated resources.

    Signed-off-by: Stefano Babic

    Stefano Babic
     
  • 00c234f38   env: add a version number to check API ... Browse Code »

    Changes in the environment library are difficult to tracked by programs
    using the library. Add simply an API version number that must be
    increased each time when the API is changed.

    This can be detected and a program can work with different versions of
    the library.

    Signed-off-by: Stefano Babic

    Stefano Babic
     
  • 9d80b49a6   env: split fw_env.h in public and private parts ... Browse Code »

    Move U-Boot private data into a separate file. This
    lets export fw_env.h to be used by external programs
    that want to change the environment using the library
    built in tools/env.

    Signed-off-by: Stefano Babic

    Stefano Babic
     
  • b80c0b993   Rename aes.h to uboot_aes.h ... Browse Code »

    aes.h is a too generic name if this file can
    be exported and used by a program.
    Rename it to avoid any conflicts with
    other files (for example, from openSSL).

    Signed-off-by: Stefano Babic

    Stefano Babic
     

15 Mar, 2017

1 commit

  • 3b0825296   tools: fix cross-compiling tools when HOSTCC is overridden ... Browse Code »

    Richard reported U-Boot tools issues in OpenEmbedded/Yocto project.

    OE needs to be able to change the default compiler. If we pass in
    HOSTCC through the make command, it overwrites all HOSTCC instances,
    including ones in tools/Makefile and tools/env/Makefile, which breaks
    "make cross_tools" and "make env", respectively.

    Add "override" directives to avoid overriding HOSTCC instances that
    really need to point to the cross-compiler.

    Signed-off-by: Masahiro Yamada
    Reported-by: Richard Purdie
    Reviewed-by: Simon Glass

    Masahiro Yamada
     

29 Nov, 2016

1 commit

  • 333ee16d0   tools/env: fix environment alignment tests for block devices ... Browse Code »

    commit 183923d3e412500bdc597d1745e2fb6f7f679ec7 enforces that the
    environment must start at an erase block boundary.

    For block devices the sample fw_env.config does not mandate a erase block size
    for block devices. A missing setting defaults to the full env size.

    Depending on the environment location the alignment check now errors out for
    perfectly legal settings.

    Fix this by defaulting to the standard blocksize of 0x200 for environments
    stored in a block device.
    That keeps the fw_env.config files for block devices working even with that
    new check.

    Signed-off-by: Max Krummenacher

    Max Krummenacher