12 Feb, 2016
2 commits
-
Boards with a saved environment may use 'lcd' in their stdout environment
variable, expecting that this will enable output to the LCD. When the board
moves to use driver model for video, this will no-longer work. Add a
work-around to fix this. A warning messages is printed, and we will remove
the work-around at the end of 2016.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin
Tested-by: Stephen Warren
10 Feb, 2016
1 commit
-
This commit breaks bootup on sunxi boards, the get stuck
when running the main u-boot binary at:CPU: Allwinner H3 (SUN8I)
I2C: ready
DRAM:This reverts commit 8e7cba048baae68ee0916a8f52b4304277328d5e.
Signed-off-by: Hans de Goede
08 Feb, 2016
9 commits
-
Signed-off-by: David Müller
-
Signed-off-by: Masahiro Yamada
Reviewed-by: Bin Meng
Reviewed-by: Simon Glass -
Commit 9c11135ce053 ("image: fix getenv_bootm_size() function") fixed
the case where "bootm_low" is defined, but "bootm_size" is not.
Instead, it broke the case where neither "bootm_low" nor "bootm_size"
is defined. Fix this function again.Fixes: 9c11135ce053 ("image: fix getenv_bootm_size() function")
Signed-off-by: Masahiro Yamada
Tested-by: Matthias Weisser
Tested-by: Hannes Schmelzer -
The recent change to memalign() caused the allocation failure detection
code to be dead code; the "retry" logic is always activated under the same
condition that the original failure detection code is, and also fully
handles any possible failures. This patch solves the presence of dead
code.Two alternatives are possible:
a) Delete the now-dead test, and rely on the "retry" path to handle any
allocation problems, as it does.b) Make the "retry" path fall through to the existing (currently dead)
failure detection code, thus making it not-dead.(b) was chosen since it reduces the diff between U-Boot's and the upstream
dlmalloc. This should make it marginally easier to import a new version of
dlmalloc in the future.Reported by: Coverity Scan
Fixes: 4f144a416469 ("malloc: work around some memalign fragmentation issues")
Signed-off-by: Stephen Warren
Reviewed-by: Tom Rini -
The case of memory of size 0 is not that different from a memory of any other
size, so we remove the duplicate code and treat the small differences when it
is the case.Signed-off-by: Eddy Petrișor
-
Add trivial support for changing the U-Boot command prompt string
by setting PS1 and PS2 environment variables. Only static variables
are supported.Signed-off-by: Marek Vasut
Reviewed-by: Heiko Schocher
Reviewed-by: Simon Glass -
Pull the code which displays U-Boot prompt and reads the command line
into a separate function. No functional change.Signed-off-by: Marek Vasut
Reviewed-by: Heiko Schocher
Reviewed-by: Simon Glass -
passing argv/argc can produce off-by-one errors
Signed-off-by: Andreas Fenkart
06 Feb, 2016
1 commit
-
Correct spelling of "U-Boot" shall be used in all written text
(documentation, comments in source files etc.).Signed-off-by: Bin Meng
Reviewed-by: Heiko Schocher
Reviewed-by: Simon Glass
Reviewed-by: Minkyu Kang
05 Feb, 2016
1 commit
-
The x86 build target "efi-x86" has no TEXT_BASE configured. And with the
introduction of CONFIG_BOOTDELAY for x86, this function is now called
for this board as well. Resulting in compile errors for this target.Without TEXT_BASE it makes no sense to fill these values. So lets only
configure the env variable if TEXT_BASE is defined.Signed-off-by: Stefan Roese
Cc: Simon Glass
Cc: Bin Meng
Cc: Tom Rini
Reviewed-by: Simon Glass
Reviewed-by: Bin Meng
02 Feb, 2016
1 commit
-
Use of memalign can trigger fragmentation issues such as:
// Internally, this needs to find a free block quite bit larger than s.
// Once the free region is found, any unaligned "padding" immediately
// before and after the block is marked free, so that the allocation
// takes only s bytes (plus malloc header overhead).
p = memalign(a, s);
// If there's little fragmentation so far, this allocation is likely
// located immediately after p.
p2 = malloc(x);
free(p);
// In theory, this should return the same value for p. However, the hole
// left by the free() call is only s in size (plus malloc header overhead)
// whereas memalign searches for a larger block in order to guarantee it
// can adjust the returned pointer to the alignment requirements. Hence,
// the pointer returned, if any, won't be p. If there's little or no space
// left after p2, this allocation will fail.
p = memalign(a, s);In practice, this issue occurs when running the "dfu" command repeatedly
on NVIDIA Tegra boards, since DFU allocates a large 32M data buffer, and
then initializes the USB controller. If this is the first time USB has
been used in the U-Boot session, this causes a probe of the USB driver,
which causes various allocations, including a strdup() of a GPIO name
when requesting the VBUS GPIO. When DFU is torn down, the USB driver
is left probed, and hence its memory is left allocated. If "dfu" is
executed again, allocation of the 32M data buffer fails as described
above.In practice, there is a memory hole exactly large enough to hold the 32M
data buffer than DFU needs. However, memalign() can't know that in a
general way. Given that, it's particularly annoying that the allocation
fails!The issue is that memalign() tries to allocate something larger to
guarantee the ability to align the returned pointer. This patch modifies
memalign() so that if the "general case" over-sized allocation fails,
another allocation is attempted, of the exact size the user desired. If
that allocation just happens to be aligned in the way the user wants,
(and in the case described above, it will be, since the free memory
region is located where a previous identical allocation was located),
the pointer can be returned.This patch is somewhat related to 806bd245b1ab "dfu: don't keep
freeing/reallocating". That patch worked around the issue by removing
repeated free/memalign within a single execution of "dfu". However,
the same technique can't be applied across multiple invocations, since
there's no reason to keep the DFU buffer allocated while DFU isn't
running. This patch addresses the root-cause a bit more directly.This problem highlights some of the disadvantages of dynamic allocation
and deferred probing of devices.This patch isn't checkpatch-clean, since it conforms to the existing
coding style in dlmalloc.c, which is different to the rest of U-Boot.Signed-off-by: Stephen Warren
Reviewed-by: Tom Rini
Acked-by: Lukasz Majewski
28 Jan, 2016
2 commits
-
It might be missed when converting spi_flash_probe() in cmd_sf.c.
This patch refers to commit fbb099183e3a ("dm: Convert
spi_flash_probe() and 'sf probe' to use driver model").Signed-off-by: Gong Qianyu
Reviewed-by: York Sun
26 Jan, 2016
3 commits
-
Scan code 0x39 is CapsLock, which is not a printable character and thus
is not covered by either usb_kbd_numkey_shifted[] or usb_kbd_numkey[].
Fix the scan code check to avoid looking it up in either of the arrays.Signed-off-by: Marek Vasut
25 Jan, 2016
4 commits
-
clang-3.8 reports that these functions are unused, remove them. As this
is the last part of CONFIG_MODEM_SUPPORT_DEBUG, drop that from README.Reviewed-by: Bin Meng
Signed-off-by: Tom Rini -
This enables boards to choose where to/from the environment should be
saved/loaded. They can then for example support using the same device
(dynamically) from which the bootloader was launched to load and save
env data and do not have to define CONFIG_SYS_MMC_ENV_DEV statically.In my use case, the environment needs to be on the same device I
booted from. It can be the eMMC or an optional SD card.
I therefore would override mmc_get_env_dev in the board code, read the
CPU registers to determine where we booted from and return the
corresponding device index.Cc: Tom Rini
Cc: Stephen Warren
Cc: Tim Harvey
Cc: Simon Glass
Cc: Hans de GoedeSigned-off-by: Clemens Gruber
Reviewed-by: Stephen Warren
Reviewed-by: Tom Rini -
Variable _load_end_ points to end address of uncompressed buffer
(*not* uncomress_buffer_end / sizeof(ulong)), so multipling uncompressed
size with sizeof(ulong) is grossly incorrect in flush_cache().
It might lead to access of address beyond valid memory range and hang the CPU.Tested on MIPS architecture by using compressed(gzip, lzma)
and uncompressed uImage.Signed-off-by: Purna Chandra Mandal
Reviewed-by: Simon Glass
Reviewed-by: Daniel Schwierzeck -
There are a lot of unrelated files in common, including all of the commands.
Moving them into their own directory makes them easier to find and is more
logical.Some commands include non-command code, such as cmd_scsi.c. This should be
sorted out at some point so that the function can be enabled with or without
the associated command.Unfortunately, with m68k I get this error:
m68k: + M5329AFEE
+arch/m68k/cpu/mcf532x/start.o: In function `_start':
+arch/m68k/cpu/mcf532x/start.S:159:(.text+0x452): relocation truncated to fit: R_68K_PC16 against symbol `board_init_f' defined in .text.board_init_f section in common/built-in.oI hope someone can shed some light on what this means. I hope it isn't
depending on the position of code in the image.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng
Reviewed-by: Heiko Schocher
Acked-by: Stefan Roese
Acked-by: Przemyslaw Marczak
24 Jan, 2016
1 commit
-
The testpattern of the lcd was only working in 8bit mode(2x3 tiles in
different colors). With this patch now 8bit and 16bit is supported.
In 16bit mode there are 2x4 tiles in different colors.
The number of LCD-colors is defined in the include/configs/.hSigned-off-by: Andreas Neubacher
Signed-off-by: Anatolij Gustschin
22 Jan, 2016
4 commits
-
At present there is no indication that an invalid GPIO is used except that
the GPIO status is not displayed. Make the error more explicit to avoid
confusion.Signed-off-by: Simon Glass
-
When driver model is used for video but not for the keyboard, a compiler
warnings is produced. Fix it.Signed-off-by: Simon Glass
-
The 'gpio' command allows abbreviations for most subcommands. Allow them
for 'status' also.Signed-off-by: Simon Glass
-
It is convenient to be able to see the status of all regulators in a list.
Add this feature to the 'reg status' command.Signed-off-by: Simon Glass
21 Jan, 2016
10 commits
-
Now that driver model support is available, convert sandbox over to use it.
We can remove a few of the special hooks that sandbox currently has.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin -
Register video drivers with stdio so that they can be used for text output.
This needs to be done explicitly for now. At some point we should be able to
convert stdio itself to driver model and avoid this step.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin -
This command can use the bitmap display code in the uclass. This is similar
to the code in lcd.c and cfb_console.c. These other copies will go away when
all boards are converted to use driver model for video.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin -
Before relocation we need to reserve memory for the video driver frame
buffers so that they can use this memory when they start up (after
relocation). Add a call to the uclass to permit this.The current top and bottom of the region is stored in global_data so that
it can be checked post-relocation to ensure enough memory is available. No
video device should be probed before relocation.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin -
These two functions are conceptually the same. Move them together in the
pre-relocation init.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin -
The LCD functions and definitions are not used with the driver model video
uclass. When all boards are converted over we can remove the file. For now,
use #ifdef to omit the contents.Signed-off-by: Simon Glass
Acked-by: Anatolij Gustschin -
This reverts commit 3e303f748cf57fb23e8ec95ab7eac0074be50e2b.
The fix up in the /aliases node does not work under the following
scenarios:
- Not every non-DM serial driver was written to have a driver name
that conforms the format of "serial%d" or "eserial%d".
- With driver model serial, the stdio_devices[] stores the serial
device node name in the device tree.Signed-off-by: Bin Meng
Acked-by: Simon Glass -
We can define this in the header file and use it in usb_storage.c. There is
no need to define it twice. Remove the #define from usb_storage.c.Signed-off-by: Simon Glass
Reviewed-by: Marek Vasut -
Adjust this command to use map_sysmem() correctly so that it works on
sandbox.Signed-off-by: Simon Glass
Reviewed-by: Tom Rini -
We should not return a -ve error code from command functions. Instead,
return CMD_RET_FAILURE. This avoids the "exit not allowed from main input
shell" error messages from the hush shell.Signed-off-by: Simon Glass
Acked-by: Heiko Schocher
19 Jan, 2016
1 commit
-
In a number of places we had wordings of the GPL (or LGPL in a few
cases) license text that were split in such a way that it wasn't caught
previously. Convert all of these to the correct SPDX-License-Identifier
tag.Signed-off-by: Tom Rini