26 Jul, 2019

3 commits


24 May, 2019

5 commits

  • Fix coverity issue CID 43665: Free of address-of expression (BAD_FREE)
    incorrect_free: free frees incorrect pointer pp.

    pp points the port array field of struct ahci_uc_priv, should not free it.

    Signed-off-by: Ye Li
    Acked-by: Peng Fan
    (cherry picked from commit da3f3a081690d4d7fc901d922d01e2bbe6cb4eb5)

    Ye Li
     
  • Fix coverity issue CID 3261683: Wrong operator used (CONSTANT_EXPRESSION_RESULT)
    operator_confusion: ({...; __v;}) | 67108864 is always 1/true regardless of the values
    of its operand. This occurs as the logical operand of !

    When DIAG_X is set, the PHY COMINIT signal is detected, so should use '&' to check
    whether it is set.

    Signed-off-by: Ye Li
    (cherry picked from commit 876f435b632fd6ef1f7cfd1f7752861f1da90118)

    Ye Li
     
  • Fix coverity issue CID 3606684: Resource leak (RESOURCE_LEAK)
    leaked_storage: Variable uc_priv going out of scope leaks the storage it points to

    Signed-off-by: Ye Li
    (cherry picked from commit 8f52ef83dbfc9f1c812b2166a7322a16efcbf939)

    Ye Li
     
  • The reset_sata should reset the sata device info and free the probe_ent
    memory. Otherwise, it will cause memory leak if we init the sata again.

    Signed-off-by: Ye Li
    (cherry picked from commit 148488728486137a790a89e9b869cc938c3e0c57)

    Ye Li
     
  • - some delay is required between SATA_CTRL0 RST SET and CLR.
    Otherwise, sata phy link would be down.
    - specific the ahci modification by imx8qm platform.

    Signed-off-by: Richard Zhu
    Signed-off-by: Ye Li
    (cherry picked from commit 83812d4d636d98afdcb617a3aeab7b037e884aa1)

    Ye Li
     

07 Dec, 2018

3 commits


29 Sep, 2018

1 commit


27 Sep, 2018

2 commits


26 Sep, 2018

2 commits


27 Jul, 2018

1 commit

  • Make the code structure more general so that more socs can be
    added easily and also remove speed limitation restriction.
    Add the ls1012a sata support as well.

    Signed-off-by: Tang Yuantian
    Reviewed-by: Michal Simek
    Tested-by: Michal Simek
    (with and without CONFIG_OF_LIVE on zynqmp zcu102)
    Reviewed-by: York Sun

    Yuantian Tang
     

29 May, 2018

3 commits

  • Mvebu AHCI is AHCI driver which uses SCSI under the hood.
    This patch adjusts AHCI setup to support SCSI by creating
    a SCSI device as a child. Since the functions of creating
    SCSI device need the kconfig option DM_SCSI, so let
    AHCI_MVEBU select DM_SCSI.

    Signed-off-by: Ken Ma
    Reviewed-by: Stefan Roese
    Reviewed-by: Simon Glass
    Signed-off-by: Stefan Roese

    Ken Ma
     
  • This workaround was added for A8040/7040 A0.
    A8040/7040 A0 is no longer supported so this workaround
    can be removed.

    Signed-off-by: David Sniatkiwicz
    Signed-off-by: Ken Ma
    Reviewed-by: Stefan Roese
    Reviewed-by: Simon Glass
    Signed-off-by: Stefan Roese

    David Sniatkiwicz
     
  • Currently mvebu sata driver is in arch/arm/mach_mvebu directory, this
    patch moves it to drivers/ata directory with renaming "sata.c" to
    "ahci_mvebu.c" which is aligned to Linux.
    New ahci driver's kconfig option is added as AHCI_MVEBU which selects
    SCSI_AHCI and is based on AHCI.

    Signed-off-by: Ken Ma
    Reviewed-by: Stefan Roese
    Reviewed-by: Simon Glass
    Signed-off-by: Stefan Roese

    Ken Ma
     

11 May, 2018

1 commit


07 May, 2018

1 commit

  • When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

28 Apr, 2018

1 commit


14 Apr, 2018

1 commit

  • The dwc_ahci has been broken for quite some time now. The breakage has been
    introduced by the series "dm: scsi: Enhance SCSI support for driver model"

    Use ahci_bind_scsi() and ahci_probe_scsi() to properly bind and probe the
    driver.

    Signed-off-by: Jean-Jacques Hiblot

    Jean-Jacques Hiblot
     

09 Feb, 2018

1 commit

  • config_fallbacks.h has some logic that sets HAVE_BLOCK_DEVICE
    based on a list of enabled options. Moving HAVE_BLOCK_DEVICE to
    Kconfig allows us to drastically shrink the logic in
    config_fallbacks.h

    Signed-off-by: Adam Ford
    [trini: Rename HAVE_BLOCK_DEVICE to CONFIG_BLOCK_DEVICE]
    Signed-off-by: Tom Rini

    Adam Ford
     

13 Dec, 2017

10 commits


28 Nov, 2017

1 commit


03 Nov, 2017

1 commit

  • The patch:
    "dm: ahci: Unwind the confusing init code"
    (sha1: 7cf1afce7fa3fe64189020fe14b93f7326dd0758)
    introduce bug for ceva sata because port didn't start.
    On the other hand the dwc_ahci.c was fixed correctly.
    Do the same change for ceva too.

    Signed-off-by: Michal Simek
    Tested-by: Mian Yousaf Kaukab

    Michal Simek
     

04 Oct, 2017

1 commit

  • U-Boot widely uses error() as a bit noisier variant of printf().

    This macro causes name conflict with the following line in
    include/linux/compiler-gcc.h:

    # define __compiletime_error(message) __attribute__((error(message)))

    This prevents us from using __compiletime_error(), and makes it
    difficult to fully sync BUILD_BUG macros with Linux. (Notice
    Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)

    Let's convert error() into now treewide-available pr_err().

    Done with the help of Coccinelle, excluing tools/ directory.

    The semantic patch I used is as follows:

    //
    @@@@
    -error
    +pr_err
    (...)
    //

    Signed-off-by: Masahiro Yamada
    Reviewed-by: Simon Glass
    [trini: Re-run Coccinelle]
    Signed-off-by: Tom Rini

    Masahiro Yamada
     

13 Sep, 2017

1 commit


17 Aug, 2017

1 commit