25 Jan, 2019
2 commits
-
No mainline board enables CONFIG_MCAST_TFTP and there have been
compilation issues with the code for some time. Additionally, it has a
potential buffer underrun issue (reported as a side note in
CVE-2018-18439).Remove the multicast TFTP code but keep the driver API for the future
addition of IPv6.Cc: Simon Goldschmidt
Signed-off-by: Chris Packham
Acked-by: Joe Hershberger -
When dealing with two ethernet ports and having "netretry" set
to "once", it could occur that the connection (e.g. an ARP
request) failed, hence the status of the netloop was
"NETLOOP_FAIL". Due to the setting of "netretry", the network
logic would then switch to the other network interface,
assigning "ret" with the return value of "net_start_again()".
If this call succeeded we would return 0 (i.e. success) to
the caller when in reality the network action failed.Signed-off-by: Thomas RIENOESSL
Reviewed-by: Christian Gmeiner
Acked-by: Joe Hershberger
11 Oct, 2018
2 commits
-
Make it possible to add TCP versions of the same, while reusing
IP portions. This patch should not change any behavior.Signed-off-by: Duncan Hare
Acked-by: Joe Hershberger -
Peter originally sent a fix, but it breaks a number of other things.
This addresses the original reported issue in a different way.That report was:
> U-Boot has 1 common buffer to send Ethernet frames, pointed to by
> net_tx_packet. When sending to an IP address without knowing the MAC
> address, U-Boot makes an ARP request (using the arp_tx_packet buffer)
> to find out the MAC address of the IP addressr. When a matching ARP
> reply is received, U-Boot continues sending the frame stored in the
> net_tx_packet buffer.
>
> However, in the mean time, if U-Boot needs to send out any network
> packets (e.g. replying ping packets or ARP requests for its own IP
> address etc.), it will use the net_tx_packet buffer to prepare the
> new packet. Thus this buffer is no longer the original packet meant
> to be transmitted after the ARP reply. The original packet will be
> lost.This instead uses the ARP tx buffer to send async replies in the case
where we are actively waiting for an ARP reply.Signed-off-by: Joe Hershberger
Reported-by: Tran Tien Dat
Reviewed-by: Simon Glass
Reviewed-by: Bin Meng
Tested-by: Bin Meng
27 Jul, 2018
5 commits
-
The same basic parsing was implemented in tftp and nfs, so add a helper
function to do the work once.Signed-off-by: Joe Hershberger
-
Instead of depending on a env callback for bootfile, read it explicitly.
We do this because the bootfile can be specified on the command line and
if it is, we will overwrite the internal variable. If a netboot_common()
is called again with no bootfile parameter, we want to use the one in
the environment.Signed-off-by: Joe Hershberger
-
Rather than crashing, check the src ptr and set dst to empty string.
Signed-off-by: Joe Hershberger
-
With net autoload, we check the prerequisites for the initial command,
but the greater prerequisites when autoloading are not checked.If we would attempt to autoload, check those prerequisites too.
If we are not expecting a serverip from the server, then don't worry
about it not being set, but don't attempt to load if it isn't.Signed-off-by: Joe Hershberger
-
For net_boot_common, we allow the serverip to be specified as part of
the boot file name. For net commands that require serverip, include that
source as a valid specification of serverip.Signed-off-by: Joe Hershberger
Reviewed-by: Alexander Graf
03 Jul, 2018
2 commits
-
We can call commands like dhcp and bootp without arguments or with
explicit command line arguments that really should tell the code where
to look for files instead.Unfortunately, the current code simply overwrites command line arguments
in the dhcp case with dhcp values.This patch allows the code to preserve the command line values if they
were set on the command line. That way the semantics are slightly more
intuitive.The reason this patch does that by introducing a new variable is that we
can not rely on net_boot_file_name[0] being unset, as today it's
completely legal to call "dhcp" and afterwards run "tftp" and expect the
latter to repeat the same query as before. I would prefer not to break
that behavior in case anyone relies on it.Signed-off-by: Alexander Graf
Acked-by: Joe Hershberger -
Add a new command 'wol': Wait for an incoming Wake-on-LAN packet or
time out if no WoL packed is received.
If the WoL packet contains a password, it is saved in the environment
variable 'wolpassword' using the etherwake format (dot or colon
separated decimals).Intended use case: a networked device should boot an alternate image.
It's attached to a network on a client site, modifying the DHCP server
configuration or setup of a tftp server is not allowed.
After power on the device waits a few seconds for a WoL packet. If a
packet is received, the device boots the alternate image. Otherwise
it boots the default image.This method is a simple way to interact with a system via network even
if only the MAC address is known. Tools to send WoL packets are
available on all common platforms.Some Ethernet drivers seem to pad the incoming packet. The additional
padding bytes might be recognized as Wake-on-LAN password bytes.By default enabled in pengwyn_defconfig.
Signed-off-by: Lothar Felten
Acked-by: Joe Hershberger
14 Jun, 2018
1 commit
-
Global variable "net_state" is used in net_loop() state-machine.
But it happens that some times the net_loop() can be called
multiple times in the same call stack. For example when the
netconsole is enabled and we print the message while some other
net protocol is in action. Netconsole will overwrite the "net_state"
and that will break the logic for earlier started protocol.To protect the state save and restore "net_state" variable each
time when we enter and exit net_loop().Signed-off-by: Leonid Iziumtsev
Acked-by: Joe Hershberger
30 May, 2018
1 commit
-
Merge UDP fastboot support from AOSP:
https://android.googlesource.com/platform/external/u-boot/+/android-o-mr1-iot-preview-8
Signed-off-by: Alex Kiernan
Signed-off-by: Alex Deymo
Signed-off-by: Jocelyn Bohr
Reviewed-by: Simon Glass
11 May, 2018
1 commit
-
As part of the main conversion a few files were missed. These files had
additional whitespace after the '*' and before the SPDX tag and my
previous regex was too strict. This time I did a grep for all SPDX tags
and then filtered out anything that matched the correct styles.Fixes: 83d290c56fab ("SPDX: Convert all of our single license tags to Linux Kernel style")
Reported-by: Heinrich Schuchardt
Signed-off-by: Tom Rini
28 Apr, 2018
1 commit
-
We have a large number of places where while we historically referenced
gd in the code we no longer do, as well as cases where the code added
that line "just in case" during development and never dropped it.Signed-off-by: Tom Rini
23 Mar, 2018
1 commit
-
The "net_try_count" counter starts from "1".
And the "retrycnt" contains requested amount of retries.With current logic, that means that the actual retry amount
will be one time less then what we set in "netretry" env.
For example setting "netretry" to "once" will make "retrycnt"
equal "1", so no retries will be triggered at all.Fix the logic by changing the statement of "if" condition.
Signed-off-by: Leonid Iziumtsev
Acked-by: Joe Hershberger
16 Aug, 2017
4 commits
-
We are now using an env_ prefix for environment functions. Rename these
other functions as well, for consistency:getenv_vlan()
getenv_bootm_size()
getenv_bootm_low()
getenv_bootm_mapsize()
env_get_default()Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass -
We are now using an env_ prefix for environment functions. Rename these
for consistency. Also add function comments in common.h.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass -
We are now using an env_ prefix for environment functions. Rename these
two functions for consistency. Also add function comments in common.h.Quite a few places use getenv() in a condition context, provoking a
warning from checkpatch. These are fixed up in this patch also.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass -
We are now using an env_ prefix for environment functions. Rename these
commonly used functions, for consistency. Also add function comments in
common.h.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass
08 Aug, 2017
1 commit
-
Add missing "defined" statement to fix the compile failures.
Signed-off-by: Holger Dengler
Acked-by: Joe Hershberger
22 Jan, 2017
1 commit
-
Move all of the status LED feature to drivers/led/Kconfig.
The LED status definitions were moved from the board configuration
files to the defconfig files.TBD: Move all of the definitions in the include/status_led.h to the
relevant board's defconfig files.Tested boards: CL-SOM-AM57x, CM-T335
Signed-off-by: Uri Mashiach
23 Aug, 2016
1 commit
-
At least on bfin, this "specimen" is actually allocated in the BSS and
wastes lots of memory in already tight memory conditions.Also, with the introduction of NFSv3 support, this waste got
substantially larger.Just remove it. If a board needs a specific different defragment size,
that board can override this setting.Signed-off-by: Joe Hershberger
27 May, 2016
1 commit
-
We can now successfully boot EFI applications from disk, but users
may want to also run them from a PXE setup.This patch implements rudimentary network support, allowing a payload
to send and receive network packets.With this patch, I was able to successfully run grub2 with network
access inside of QEMU's -M xlnx-ep108.Signed-off-by: Alexander Graf
08 Jan, 2016
1 commit
-
Introduced in 45b4773 (net/arp: account for ARP delay, avoid duplicate packets on timeout)
Check the arp timeout and adjust the timeout start time before the call
to eth_recv() so that the sandbox driver has the opportunity to adjust
the sandbox timer after the new start time has been recorded.Also, change the adjustment amount by 11 seconds instead of exactly the
10 seconds that the ping timout is expecting since the timeout check is
looking for the time elapsed to be greater than but not equal to the
specified delay.Signed-off-by: Joe Hershberger
Reviewed-by: Stefan Brüns
Acked-by: Simon Glass
20 Nov, 2015
1 commit
-
The console includes a global variable and several functions that are only
used by a small subset of U-Boot files. Before adding more functions, move
the definitions into their own header file.Signed-off-by: Simon Glass
30 Oct, 2015
1 commit
-
The net_boot_file_name buffer is used as storage for the bootfilename
command line argument to network boot commands such as tftp and nfs.Increase the size of this buffer to 1024 bytes as the current size of
128 bytes is restrictive for arbitrary paths on the server.Signed-off-by: Jacob Stiffler
Acked-by: Joe Hershberger
29 Oct, 2015
1 commit
-
eth_rx() in the main reception loop may trigger sending a packet which
is already timed out (or will immediately) upon reception of an ARP reply.
As long as the ARP reply is pending, the timeout handler of a packet
should be postponed.
Happens on TFTP with bad network (e.g. WLAN).Signed-off-by: Stefan Brüns
Acked-by: Joe Hershberger
07 Sep, 2015
1 commit
-
This change gives the ability to reuse the header file by other
subsystems (like e.g. dfu).Without this change compilation error emerges for the legacy update.c file.
Signed-off-by: Lukasz Majewski
Acked-by: Joe Hershberger
22 Aug, 2015
1 commit
-
Current behavior is that if CTRL+C is pressed command returns 0 that was
successful which is not correct behavior.
The easiest test case is "tftpboot 80000 uImage && echo yes"
and press CTRL+C. Then the second command is called which is incorrect.Error log:
zynq-uboot> tftpb 80000 uImage && echo yes
Gem.e000b000:7 is connected to Gem.e000b000. Reconnecting to
Gem.e000b000
Gem.e000b000 Waiting for PHY auto negotiation to complete....... done
Using Gem.e000b000 device
TFTP from server 192.168.0.102; our IP address is 192.168.0.101
Filename 'uImage'.
Load address: 0x80000
Loading: ################
Abort
yes
zynq-uboot>This patch adds -EINTR return value when CTRL+C is pressed.
Signed-off-by: Michal Simek
Reviewed-by: Tom Rini
Acked-by: Joe Hershberger
21 May, 2015
1 commit
-
Instead of checking for changes to the env each time we enter the
net_loop, use the env callbacks to update the values of the variables.
Don't update the variables when the source was programmatic, since the
variables were the source of the new value.Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass
19 Apr, 2015
9 commits
-
Finish eliminating CamelCase from net.c and other failures
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within common/cmd_net.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within netconsole.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within dns.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within cdp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within sntp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within rarp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within nfs.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within bootp.c and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass