27 Dec, 2018

1 commit

• 94ca26904   scripts/check-config.sh: Add usage() ... Browse Code »

  When arguments are not supplied the error message is misleading and
  doesn't tell what exactly has to be done.

  Fix this by adding usage() and call it if above circumstance occurs.

  Signed-off-by: Andy Shevchenko
  Reviewed-by: Simon Glass

  Andy Shevchenko

  2018-12-27 07:24:26 +0800  

23 Mar, 2018

1 commit

• f69dce508   scripts/check-config.sh: fix "command not found" error handling ... Browse Code »

  scripts/check-config.sh exits successfully and silently without doing
  any checks when the 'comm' command is not found.

  The problem triggers from the command around line 39:

  comm -23 ${suspects} ${ok} >${new_adhoc}

  This statement fails when 'comm' is not in $PATH, creating an empty
  ${new_adhoc} file. But the script continues and the following line,
  which is supposed to detect an error:

  if [ -s ${new_adhoc} ]; then

  will always be false since the file is empty, and the script will exit
  successfully as if everything were OK.

  The case where 'comm' in not in $PATH is not theoretical. It used to
  happen on yocto until a recent fix [0], and still happens on the
  current stable branch (rocko).

  Fix by setting the errexit flag to exit with error when a statement
  fails, so that at least the problem is noticed.

  For additional safety also set the nounset flag to detect expansion
  errors.

  [0] http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=fe0b4cb5b48580d4a3f3c0eb82bfa6f1b13801e4

  Signed-off-by: Luca Ceresoli
  Reviewed-by: Simon Glass

  Luca Ceresoli

  2018-03-23 04:32:30 +0800  

29 Jun, 2017

1 commit

• 1f54a47ca   scripts: config_whitelist: Handle lines with leading spaces/tabs ... Browse Code »

  Some Kconfig options are defined in a line with leading spaces/tabs.
  Update build-whitelist/check-config scripts to handle such cases.
  Generate a new config_whitelist.txt with new scripts.

  Signed-off-by: Bin Meng

  Bin Meng

  2017-06-29 22:01:10 +0800  

09 Feb, 2017

1 commit

• 1bdd942b6   kbuild: beautify the log of config whitelist check ... Browse Code »

  Use the kbuild style log.

  Prior to this commit:

  ./scripts/check-config.sh u-boot.cfg \
  ./scripts/config_whitelist.txt . 1>&2

  With this commit:

  CFGCHK u-boot.cfg

  Signed-off-by: Masahiro Yamada
  Reviewed-by: Simon Glass

  Masahiro Yamada

  2017-02-09 04:56:30 +0800  

07 Oct, 2016

1 commit

• 7b76daab4   check-config: fix wrong comment about how to build whitelist ... Browse Code »

  The command suggested in this comment block is wrong; it would not
  rip off CONFIG options that had already been converted to Kconfig.

  Instead, we should use the scripts/build-whitelist.sh tool.

  Signed-off-by: Masahiro Yamada
  Reviewed-by: Simon Glass

  Masahiro Yamada

  2016-10-07 22:26:32 +0800  

17 Sep, 2016

1 commit

• 371244cb1   Makefile: Give a build error if ad-hoc CONFIG options are added ... Browse Code »

  12

  New CONFIG options should be added via Kconfig. To help prevent new ad-hoc
  CONFIGs from being added, give a build error when these are detected.

  Signed-off-by: Simon Glass
  Acked-by: Stephen Warren
  Tested-by: Stephen Warren

  Simon Glass

  2016-09-17 05:27:24 +0800