21 Nov, 2014

1 commit

  • This function can fail if the device tree runs out of space. Rather than
    silently booting with an incomplete device tree, allow the failure to be
    detected.

    Unfortunately this involves changing a lot of places in the code. I have
    not changed behvaiour to return an error where one is not currently
    returned, to avoid unexpected breakage.

    Eventually it would be nice to allow boards to register functions to be
    called to update the device tree. This would avoid all the many functions
    to do this. However it's not clear yet if this should be done using driver
    model or with a linker list. This work is left for later.

    Signed-off-by: Simon Glass
    Acked-by: Anatolij Gustschin

    Simon Glass
     

25 Sep, 2014

1 commit

  • Since commit ddaf5c8f3030050fcd356a1e49e3ee8f8f52c6d4
    (patman: RunPipe() should not pipe stdout/stderr unless asked),
    Patman spits lots of "Invalid MAINTAINERS address: '-'"
    error messages for patches with global changes.
    It takes too long for Patman to process them.

    Anyway, "M: -" does not carry any important information.
    Rather, it is just like a place holder in case of assigning
    a new board maintainer. Let's comment out.

    This commit can be reproduced by the following command:

    find . -name MAINTAINERS | xargs sed -i -e '/^M:[[:blank:]]*-$/s/^/#/'

    Signed-off-by: Masahiro Yamada

    Masahiro Yamada
     

14 Sep, 2014

1 commit

  • Now the types of CONFIG_SYS_{ARCH, CPU, SOC, VENDOR, BOARD, CONFIG_NAME}
    are specified in arch/Kconfig.

    We can delete the ones in arch and board Kconfig files.

    This commit can be easily reproduced by the following command:

    find . -name Kconfig -a ! -path ./arch/Kconfig | xargs sed -i -e '
    /config[[:space:]]SYS_\(ARCH\|CPU\|SOC\|\VENDOR\|BOARD\|CONFIG_NAME\)/ {
    N
    s/\n[[:space:]]*string//
    }
    '

    Signed-off-by: Masahiro Yamada

    Masahiro Yamada
     

30 Jul, 2014

2 commits

  • We have switched to Kconfig and the boards.cfg file is going to
    be removed. We have to retrieve the board status and maintainers
    information from it.

    The MAINTAINERS format as in Linux Kernel would be nice
    because we can crib the scripts/get_maintainer.pl script.

    After some discussion, we chose to put a MAINTAINERS file under each
    board directory, not the top-level one because we want to collect
    relevant information for a board into a single place.

    TODO:
    Modify get_maintainer.pl to scan multiple MAINTAINERS files.

    Signed-off-by: Masahiro Yamada
    Suggested-by: Tom Rini
    Acked-by: Simon Glass

    Masahiro Yamada
     
  • This commit adds:
    - arch/${ARCH}/Kconfig
    provide a menu to select target boards
    - board/${VENDOR}/${BOARD}/Kconfig or board/${BOARD}/Kconfig
    set CONFIG macros to the appropriate values for each board
    - configs/${TARGET_BOARD}_defconfig
    default setting of each board

    (This commit was automatically generated by a conversion script
    based on boards.cfg)

    In Linux Kernel, defconfig files are located under
    arch/${ARCH}/configs/ directory.
    It works in Linux Kernel since ARCH is always given from the
    command line for cross compile.

    But in U-Boot, ARCH is not given from the command line.
    Which means we cannot know ARCH until the board configuration is done.
    That is why all the "*_defconfig" files should be gathered into a
    single directory ./configs/.

    Signed-off-by: Masahiro Yamada
    Acked-by: Simon Glass

    Masahiro Yamada
     

01 Nov, 2013

1 commit


15 Oct, 2013

1 commit


24 Jul, 2013

2 commits


23 Jul, 2013

1 commit


09 Feb, 2013

1 commit

  • The libfdt.h file is the definition file for libfdt. It is unnecessary
    to include other fdt header files (the necessary ones are pulled in
    by libfdt.h).

    Signed-off-by: Gerald Van Baren
    Acked-by: Simon Glass
    Acked-by: Stefan Roese

    Gerald Van Baren
     

16 Oct, 2011

1 commit

  • The top level Makefile does not do any recursion into subdirs when
    cleaning, so these clean/distclean targets in random arch/board dirs
    never get used. Punt them all.

    MAKEALL didn't report any errors related to this that I could see.

    Signed-off-by: Mike Frysinger

    Mike Frysinger
     

30 Apr, 2011

1 commit

  • Currently, some linker scripts are found by common code in config.mk.
    Some are found using CONFIG_SYS_LDSCRIPT, but the code for that is
    sometimes in arch config.mk and sometimes in board config.mk. Some
    are found using an arch-specific rule for looking in CPUDIR, etc.

    Further, the powerpc config.mk rule relied on CONFIG_NAND_SPL
    when it really wanted CONFIG_NAND_U_BOOT -- which covered up the fact
    that not all NAND_U_BOOT builds actually wanted CPUDIR/u-boot-nand.lds.

    Replace all of this -- except for a handful of boards that are actually
    selecting a linker script in a unique way -- with centralized ldscript
    finding.

    If board code specifies LDSCRIPT, that will be used.
    Otherwise, if CONFIG_SYS_LDSCRIPT is specified, that will be used.

    If neither of these are specified, then the central config.mk will
    check for the existence of the following, in order:

    $(TOPDIR)/board/$(BOARDDIR)/u-boot-nand.lds (only if CONFIG_NAND_U_BOOT)
    $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds (only if CONFIG_NAND_U_BOOT)
    $(TOPDIR)/board/$(BOARDDIR)/u-boot.lds
    $(TOPDIR)/$(CPUDIR)/u-boot.lds

    Some boards (sc3, cm5200, munices) provided their own u-boot.lds that
    were dead code, because they were overridden by a CPUDIR u-boot.lds under
    the old powerpc rules. These boards' own u-boot.lds have bitrotted and
    no longer work -- these lds files have been removed.

    Signed-off-by: Scott Wood
    Tested-by: Graeme Russ

    Scott Wood
     

28 Mar, 2011

1 commit


29 Nov, 2010

1 commit


18 Nov, 2010

1 commit

  • Before this commit, weak symbols were not overridden by non-weak symbols
    found in archive libraries when linking with recent versions of
    binutils. As stated in the System V ABI, "the link editor does not
    extract archive members to resolve undefined weak symbols".

    This commit changes all Makefiles to use partial linking (ld -r) instead
    of creating library archives, which forces all symbols to participate in
    linking, allowing non-weak symbols to override weak symbols as intended.
    This approach is also used by Linux, from which the gmake function
    cmd_link_o_target (defined in config.mk and used in all Makefiles) is
    inspired.

    The name of each former library archive is preserved except for
    extensions which change from ".a" to ".o". This commit updates
    references accordingly where needed, in particular in some linker
    scripts.

    This commit reveals board configurations that exclude some features but
    include source files that depend these disabled features in the build,
    resulting in undefined symbols. Known such cases include:
    - disabling CMD_NET but not CMD_NFS;
    - enabling CONFIG_OF_LIBFDT but not CONFIG_QE.

    Signed-off-by: Sebastien Carlier

    Sebastien Carlier
     

19 Oct, 2010

3 commits

  • After the recent cleanups, a number of config.mk files consist only of
    a "PLATFORM_CPPFLAGS += -I$(TOPDIR)/board" entry whih is not needed.
    Remove such entries. In most cases, that means that the whole
    config.mk file can be removed.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     
  • Clean up Makefile, and drop a lot of the config.mk files on the way.

    We now also automatically pick all boards that are listed in
    boards.cfg (and with all configurations), so we can drop the redundant
    entries from MAKEALL to avoid building these twice.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     
  • The change is currently needed to be able to remove the board
    configuration scripting from the top level Makefile and replace it by
    a simple, table driven script.

    Moving this configuration setting into the "CONFIG_*" name space is
    also desirable because it is needed if we ever should move forward to
    a Kconfig driven configuration system.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

22 Sep, 2010

1 commit

  • - Revives POST for blackfin arch;
    - Removes redundant code:
    arch/blackfin/lib/post.c
    arch/powerpc/cpu/ppc4xx/commproc.c
    arch/powerpc/cpu/mpc512x/common.c
    - fixes up the post_word_{load|store} usage.

    Signed-off-by: Michael Zaidman
    Acked-by: Detlev Zundel
    Tested-by: Anatolij Gustschin

    List of the maintainers of the affected by patch boards:
    Cc: Stephan Linz
    Cc: Denis Peter
    Cc: Matthias Fuchs
    Cc: Peter Tyser
    Cc: Stefan Roese
    Cc: Mike Frysinger
    Cc: Niklaus Giger
    Cc: Larry Johnson
    Cc: Feng Kan

    Michael Zaidman
     

05 Jul, 2010

1 commit

  • The hush shell dynamically allocates (and re-allocates) memory for the
    argument strings in the "char *argv[]" argument vector passed to
    commands. Any code that modifies these pointers will cause serious
    corruption of the malloc data structures and crash U-Boot, so make
    sure the compiler can check that no such modifications are being done
    by changing the code into "char * const argv[]".

    This modification is the result of debugging a strange crash caused
    after adding a new command, which used the following argument
    processing code which has been working perfectly fine in all Unix
    systems since version 6 - but not so in U-Boot:

    int main (int argc, char **argv)
    {
    while (--argc > 0 && **++argv == '-') {
    /* ====> */ while (*++*argv) {
    switch (**argv) {
    case 'd':
    debug++;
    break;
    ...
    default:
    usage ();
    }
    }
    }
    ...
    }

    The line marked "====>" will corrupt the malloc data structures and
    usually cause U-Boot to crash when the next command gets executed by
    the shell. With the modification, the compiler will prevent this with
    an
    error: increment of read-only location '*argv'

    N.B.: The code above can be trivially rewritten like this:

    while (--argc > 0 && **++argv == '-') {
    char *arg = *argv;
    while (*++arg) {
    switch (*arg) {
    ...

    Signed-off-by: Wolfgang Denk
    Acked-by: Mike Frysinger

    Wolfgang Denk
     

22 Apr, 2010

1 commit

  • As discussed on the list, move "arch/ppc" to "arch/powerpc" to
    better match the Linux directory structure.

    Please note that this patch also changes the "ppc" target in
    MAKEALL to "powerpc" to match this new infrastructure. But "ppc"
    is kept as an alias for now, to not break compatibility with
    scripts using this name.

    Signed-off-by: Stefan Roese
    Acked-by: Wolfgang Denk
    Acked-by: Detlev Zundel
    Acked-by: Kim Phillips
    Cc: Peter Tyser
    Cc: Anatolij Gustschin

    Stefan Roese
     

13 Apr, 2010

1 commit


09 Dec, 2009

1 commit


08 Dec, 2009

1 commit

  • This patch introduces a weak default function for post_hotkey_pressed(),
    returning 0, for boards without hotkey support. The long-running tests
    won't be started on those boards. This default function was implemented
    in many board directories. By implementing this weak default we can
    remove all those duplicate versions.

    Boards with hotkey support, can override this weak default function
    by defining one in their board specific code.

    Signed-off-by: Stefan Roese

    Stefan Roese
     

03 Oct, 2009

1 commit

  • The following changes allow U-Boot to fully relocate from flash to
    RAM:
    - Remove linker scripts' .fixup sections from the .text section
    - Add -mrelocatable to PLATFORM_RELFLAGS for all boards
    - Define CONFIG_RELOC_FIXUP_WORKS for all boards

    Previously, U-Boot would partially relocate, but statically initialized
    pointers needed to be manually relocated.

    Signed-off-by: Peter Tyser

    Peter Tyser
     

13 Jun, 2009

2 commits

  • Many of the help messages were not really helpful; for example, many
    commands that take no arguments would not print a correct synopsis
    line, but "No additional help available." which is not exactly wrong,
    but not helpful either.

    Commit ``Make "usage" messages more helpful.'' changed this
    partially. But it also became clear that lots of "Usage" and "Help"
    messages (fields "usage" and "help" in struct cmd_tbl_s respective)
    were actually redundant.

    This patch cleans this up - for example:

    Before:
    => help dtt
    dtt - Digital Thermometer and Thermostat

    Usage:
    dtt - Read temperature from digital thermometer and thermostat.

    After:
    => help dtt
    dtt - Read temperature from Digital Thermometer and Thermostat

    Usage:
    dtt

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     
  • Add "_test" to cm5200's function test command names to prevent
    overlap with common, global function names. Originally, the
    "do_i2c" function test command interfered with
    common/cmd_i2c.c's "do_i2c" when CONFIG_I2C_CMD_TREE was defined.

    The functions were also made static as they are not globally accessed.

    Signed-off-by: Peter Tyser

    Peter Tyser
     

21 Mar, 2009

1 commit

  • A recent gcc added a new unaligned rodata section called '.rodata.str1.1',
    which needs to be added the the linker script. Instead of just adding this
    one section, we use a wildcard ".rodata*" to get all rodata linker section
    gcc has now and might add in the future.

    However, '*(.rodata*)' by itself will result in sub-optimal section
    ordering. The sections will be sorted by object file, which causes extra
    padding between the unaligned rodata.str.1.1 of one object file and the
    aligned rodata of the next object file. This is easy to fix by using the
    SORT_BY_ALIGNMENT command.

    This patch has not be tested one most of the boards modified. Some boards
    have a linker script that looks something like this:

    *(.text)
    . = ALIGN(16);
    *(.rodata)
    *(.rodata.str1.4)
    *(.eh_frame)

    I change this to:

    *(.text)
    . = ALIGN(16);
    *(.eh_frame)
    *(SORT_BY_ALIGNMENT(SORT_BY_NAME(.rodata*)))

    This means the start of rodata will no longer be 16 bytes aligned.
    However, the boundary between text and rodata/eh_frame is still aligned to
    16 bytes, which is what I think the real purpose of the ALIGN call is.

    Signed-off-by: Trent Piepho

    Trent Piepho
     

28 Jan, 2009

1 commit

  • Remove command name from all command "usage" fields and update
    common/command.c to display "name - usage" instead of
    just "usage". Also remove newlines from command usage fields.

    Signed-off-by: Peter Tyser

    Peter Tyser
     

19 Nov, 2008

1 commit

  • Most of the bss initialization loop increments 4 bytes
    at a time. And the loop end is checked for an 'equal'
    condition. Make the bss end address aligned by 4, so
    that the loop will end as expected.

    Signed-off-by: Selvamuthukumar
    Signed-off-by: Wolfgang Denk

    Selvamuthukumar
     

19 Oct, 2008

1 commit


11 Jul, 2008

1 commit


10 Jul, 2008

1 commit


03 Jul, 2008

1 commit


12 Jun, 2008

1 commit

  • This patch changes the return type of initdram() from long int to phys_size_t.
    This is required for a couple of reasons: long int limits the amount of dram
    to 2GB, and u-boot in general is moving over to phys_size_t to represent the
    size of physical memory. phys_size_t is defined as an unsigned long on almost
    all current platforms.

    This patch *only* changes the return type of the initdram function (in
    include/common.h, as well as in each board's implementation of initdram). It
    does not actually modify the code inside the function on any of the platforms;
    platforms which wish to support more than 2GB of DRAM will need to modify
    their initdram() function code.

    Build tested with MAKEALL for ppc, arm, mips, mips-el. Booted on powerpc
    MPC8641HPCN.

    Signed-off-by: Becky Bruce

    Becky Bruce
     

21 May, 2008

1 commit

  • This commit gets rid of a huge amount of silly white-space issues.
    Especially, all sequences of SPACEs followed by TAB characters get
    removed (unless they appear in print statements).

    Also remove all embedded "vim:" and "vi:" statements which hide
    indentation problems.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

18 Apr, 2008

1 commit


23 Feb, 2008

1 commit


13 Jan, 2008

1 commit

  • With recent toolchain versions, some boards would not build because
    or errors like this one (here for ocotea board when building with
    ELDK 4.2 beta):
    ppc_4xx-ld: section .bootpg [fffff000 -> fffff23b] overlaps section .bss [fffee900 -> fffff8ab]

    For many boards, the .bss section is big enough that it wraps around
    at the end of the address space (0xFFFFFFFF), so the problem will not
    be visible unless you use a 64 bit tool chain for development. On
    some boards however, changes to the code size (due to different
    optimizations) we bail out with section overlaps like above.

    The fix is to add the NOLOAD attribute to the .bss and .sbss
    sections, telling the linker that .bss does not consume any space in
    the image.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk