30 Sep, 2018
1 commit
-
In some cases it is useful to add a group of files to the image and be
able to access them at run-time. Of course it is possible to generate
the binman config file with a set of blobs each with a filename. But for
convenience, add an entry type which can do this.Add required support (for adding nodes and string properties) into the
state module.Signed-off-by: Simon Glass
29 Sep, 2018
1 commit
-
When tools are needed but not present, at present we just get an error
which can be confusing for the user. Try to be helpful by reporting the
tool as missing and suggesting a possible remedy.Also update the Run() method to support this.
Signed-off-by: Simon Glass
08 Aug, 2018
1 commit
-
A recent rename of the function did not rename the test file. Fix this.
Fixes: 12308b128fa (lib: fdtdec: Rename routine fdtdec_setup_memory_size())
Signed-off-by: Simon Glass
02 Aug, 2018
3 commits
-
When this fails it is useful to see the current directory, since U-Boot's
build system will typically change into the output directory during the
build. Add this information to the error.Signed-off-by: Simon Glass
-
Add functions to read and write a file, looking through a list of search
paths to find it.Signed-off-by: Simon Glass
-
Tests use the 'test_result' feature to return a predetermined command
result for particular commands. The avoids needing to have the real
command available just to run a test. It works by calling the function
provided by the test, to get the value.However sometimes the test does need to run the real command. Allow it to
fall back to do this when the function does not return a result.Signed-off-by: Simon Glass
27 Jul, 2018
1 commit
-
Previously the first three words in a git-mailrc alias entry could only
be separated by spaces. git-send-email and Mutt both allow arbitrary
whitespace here.Signed-off-by: Adam Sampson
Reviewed-by: Simon Glass
19 Jul, 2018
1 commit
-
This patch renames the routine fdtdec_setup_memory_size()
to fdtdec_setup_mem_size_base() as it now fills the
mem base as well along with size.Signed-off-by: Siva Durga Prasad Paladugu
Signed-off-by: Michal Simek
Reviewed-by: Tom Rini
09 Jul, 2018
2 commits
-
This function is useful in various tests. Move it into the common test
utility module.Signed-off-by: Simon Glass
-
At present only binman has the logic for determining Python test coverage
but this is useful for other tools also. Move it out into a separate file
so it can be used by other tools.Signed-off-by: Simon Glass
23 Jun, 2018
3 commits
-
Some environments require providing the '--smtp-server' argument to
'git send-email'. Add support for this.Signed-off-by: Simon Glass
-
Add a test to exercise the check for a valid SPDX license.
Signed-off-by: Chris Packham
Reviewed-by: Simon Glass -
Many mailing-lists consider a long Cc list a sign of spam and will
either drop the message or mark it for moderation. Because patman
automatically invokes get_maintainer.pl the Cc list can expand
unexpectedly. Allow the user to specify a limit for the Cc list.This limit is applied after removing any known bouncing addresses. By
default no limit is applied.Signed-off-by: Chris Packham
Reviewed-by: Simon Glass
08 Jun, 2018
1 commit
-
The format of this line has changed. Update the patman test to suit.
Signed-off-by: Simon Glass
Tested-by: Alex Kiernan
07 May, 2018
1 commit
-
When U-Boot started using SPDX tags we were among the early adopters and
there weren't a lot of other examples to borrow from. So we picked the
area of the file that usually had a full license text and replaced it
with an appropriate SPDX-License-Identifier: entry. Since then, the
Linux Kernel has adopted SPDX tags and they place it as the very first
line in a file (except where shebangs are used, then it's second line)
and with slightly different comment styles than us.In part due to community overlap, in part due to better tag visibility
and in part for other minor reasons, switch over to that style.This commit changes all instances where we have a single declared
license in the tag as both the before and after are identical in tag
contents. There's also a few places where I found we did not have a tag
and have introduced one.Signed-off-by: Tom Rini
29 Jan, 2018
1 commit
-
All of these host tools are apparently written for Python2,
not Python3.Use 'python2' in the shebang line according to PEP 394
(https://www.python.org/dev/peps/pep-0394/).Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass
22 Jan, 2018
1 commit
-
get_maintainer.pl quotes names which it considers unsafe, i.e. anything
containing [^a-zA-Z0-9_ \-]. This confuses patman, it will duplicate
addresses which are also in Series-to/cc. Strip the quotes.Signed-off-by: Stefan Brüns
Reviewed-by: Simon Glass
23 Nov, 2017
1 commit
-
The checkpatch tool was updated but the patman tests were not. Fix this.
Signed-off-by: Simon Glass
14 Sep, 2017
1 commit
-
This section of the settings file may be missing. Handle that gracefully
rather than emitting an error.Also update patman to write this section when a new settings file is
created.Fixes: e11aa602 (patman: add support for omitting bouncing addresses)
Signed-off-by: Simon Glass
Reviewed-by: Chris Packham
Tested-by: Bin Meng
12 Sep, 2017
1 commit
-
Add support for reading a list of bouncing addresses from a in-tree file
(doc/bounces) and from the ~/.patman config file. These addresses are
stripped from the Cc list.Signed-off-by: Chris Packham
Reviewed-by: Simon Glass
Reviewed-by: Philipp Tomsich >
09 Jun, 2017
10 commits
-
The existing test (patman --test) only covers basic checkpatch output.
We have had some problems with unicode processing and could use test
coverage for the various tags patman supports.Add a new functional test which runs most of the patman flow on a few
test commits and checks that the results are correct.See the documentation in the test for a description of what it does.
Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
This is not a good variable name in Python because 'list' is a type. It
shows up highlighted in some editors. Rename it.Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
Allow the add_maintainers parameter to be a list of maintainers, thus
allowing us to simulate calling the script in tests without actually
needing it to work.Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
Add some unicode to the test patches to make sure that patman does the
right thing.Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
There is no need for this function to return the same object that was
passed in. Drop the return value.Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
Unicode characters may appear in input patches so we should not warn about
them. Drop this warning.Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
This is not a good variable name in Python because 'str' is a type. It
shows up highlighted in some editors. Rename it.Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
The communication filter reads data in blocks and converts each block to
unicode (if necessary) one at a time. In the unlikely event that a unicode
character in the input spans a block this will not work. We get an error
like:UnicodeDecodeError: 'utf8' codec can't decode bytes in position 1022-1023:
unexpected end of dataThere is no need to change the input to unicode, so the easiest fix is to
drop this feature.Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
Don't mess with the email address when outputting them. Just make sure
they are encoded with utf-8.Signed-off-by: Simon Glass
Tested-by: Philipp Tomsich -
This change encodes the CC list to UTF-8 to avoid failures on
maintainer-addresses that include non-ASCII characters (observed on
Debian 7.11 with Python 2.7.3).Without this, I get the following failure:
Traceback (most recent call last):
File "tools/patman/patman", line 159, in
options.add_maintainers)
File "[snip]/u-boot/tools/patman/series.py", line 234, in MakeCcFile
print(commit.patch, ', '.join(set(list)), file=fd)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 81: ordinal not in range(128)
from Heiko's email address:
[..., u'"Heiko St\xfcbner" ', ...]While with this change added this encodes to:
"=?UTF-8?q?Heiko=20St=C3=BCbner?= "Signed-off-by: Philipp Tomsich
Reviewed-by: Simon Glass
Signed-off-by: Simon Glass
Tested-by: Simon Glass
Tested-by: Philipp Tomsich
14 Apr, 2017
1 commit
-
os.read() returns a byte array in Python 3.5.2 and needs to be converted
into a string. Check if the returned value is an instance of bytes and
if it is decode it as a utf-8 string. If it is not a utf-8 encoded string
the decoding may fail with an exception.Prior to this fix the comparisions check data == "" would fail when data
was b'' and would cause an infinite memory leaking loop. joins would
also fail with an exception below but due to the infinite loop it never
made it that far.Signed-off-by: George McCollister
Acked-by: Simon Glass
08 Feb, 2017
2 commits
-
When gathering addresses for the Cc list patman would encounter a
UnicodeDecodeError due to non-ascii characters in the author name.
Address this by explicitly using utf-8 when building the Cc list.Signed-off-by: Chris Packham
Acked-by: Simon Glass -
It is convenient to be able to deal with checkpatch warnings in the same
way as build warnings. Tools such as emacs and kate can quickly locate
the source file and line automatically.To achieve this, adjust the format to match the C compiler, and output to
stderr.Signed-off-by: Simon Glass
09 Oct, 2016
7 commits
-
In python 3.x StringIO is no longer a module, and the class can instead
be found in the io module. Adjust the code in the doctest input to
account for both.Signed-off-by: Paul Burton
Acked-by: Simon Glass -
In python 3.x the iteritems() method has been removed from dictionaries,
and the items() method does effectively the same thing. On python 2.x
using items() is a little less efficient since it involves copying data,
but as speed isn't a concern in this code switch to using items() anyway
for simplicity.Signed-off-by: Paul Burton
Acked-by: Simon Glass -
In python 3.x module names used in import statements are case sensitive,
and the configparser module is named in all lower-case. Import it as such
in order to avoid errors when running with python 3.x.Signed-off-by: Paul Burton
Acked-by: Simon Glass -
Syntax for exception handling is a little more strict in python 3.x.
Convert all uses to a form accepted by both python 2.x & python 3.x.Signed-off-by: Paul Burton
Acked-by: Simon Glass -
In python 3.x, print must be used as a function call. Convert all print
statements to the function call style, importing from __future__ where
we print with no trailing newline or print to a file object.Signed-off-by: Paul Burton
Acked-by: Simon Glass -
In preparation for running on python 3.x, which will refuse to run
scripts which mix tabs & spaces for indentation, replace 2 tab
characters present in series.py with spaces.Signed-off-by: Paul Burton
Acked-by: Simon Glass -
Output which does not include a newline will not be displayed unless
flushed. Add a flush to ensure that it becomes visible.Signed-off-by: Simon Glass
