Eric Lee / smarc-uboot

24 Jul, 2013

1 commit

01 Mar, 2013

1 commit

07 Mar, 2012

1 commit

05 Aug, 2011

1 commit

26 Jul, 2011

1 commit

12 Jan, 2011

1 commit

29 Nov, 2010

2 commits

25 Jul, 2010

1 commit

  • 47e26b1bf   cmd_usage(): simplify return code handling ... Browse Code »

    Lots of code use this construct:

    cmd_usage(cmdtp);
    return 1;

    Change cmd_usage() let it return 1 - then we can replace all these
    ocurrances by

    return cmd_usage(cmdtp);

    This fixes a few places with incorrect return code handling, too.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

05 Jul, 2010

1 commit

  • 54841ab50   Make sure that argv[] argument pointers are not modified. ... Browse Code »
    1

    The hush shell dynamically allocates (and re-allocates) memory for the
    argument strings in the "char *argv[]" argument vector passed to
    commands. Any code that modifies these pointers will cause serious
    corruption of the malloc data structures and crash U-Boot, so make
    sure the compiler can check that no such modifications are being done
    by changing the code into "char * const argv[]".

    This modification is the result of debugging a strange crash caused
    after adding a new command, which used the following argument
    processing code which has been working perfectly fine in all Unix
    systems since version 6 - but not so in U-Boot:

    int main (int argc, char **argv)
    {
    while (--argc > 0 && **++argv == '-') {
    /* ====> */ while (*++*argv) {
    switch (**argv) {
    case 'd':
    debug++;
    break;
    ...
    default:
    usage ();
    }
    }
    }
    ...
    }

    The line marked "====>" will corrupt the malloc data structures and
    usually cause U-Boot to crash when the next command gets executed by
    the shell. With the modification, the compiler will prevent this with
    an
    error: increment of read-only location '*argv'

    N.B.: The code above can be trivially rewritten like this:

    while (--argc > 0 && **++argv == '-') {
    char *arg = *argv;
    while (*++arg) {
    switch (*arg) {
    ...

    Signed-off-by: Wolfgang Denk
    Acked-by: Mike Frysinger

    Wolfgang Denk
     

13 Jun, 2009

1 commit

  • a89c33db9   General help message cleanup ... Browse Code »

    Many of the help messages were not really helpful; for example, many
    commands that take no arguments would not print a correct synopsis
    line, but "No additional help available." which is not exactly wrong,
    but not helpful either.

    Commit ``Make "usage" messages more helpful.'' changed this
    partially. But it also became clear that lots of "Usage" and "Help"
    messages (fields "usage" and "help" in struct cmd_tbl_s respective)
    were actually redundant.

    This patch cleans this up - for example:

    Before:
    => help dtt
    dtt - Digital Thermometer and Thermostat

    Usage:
    dtt - Read temperature from digital thermometer and thermostat.

    After:
    => help dtt
    dtt - Read temperature from Digital Thermometer and Thermostat

    Usage:
    dtt

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

28 Jan, 2009

2 commits

19 Oct, 2008

1 commit

21 Nov, 2007

1 commit

09 Jul, 2007

1 commit

04 Jul, 2007

1 commit

07 Oct, 2003

1 commit

  • fbe4b5cbd   * Update TRAB auto update code ... Browse Code »

    * Make fatload set filesize environment variable
    fix potential buffer overlow problem

    * enable basic / medium / high-end configurations for PPChameleonEVB
    board; fix NAND code

    * enable TFTP client code to specify to the server the desired
    timeout value (see RFC-2349)

    wdenk
     

02 Jul, 2003

1 commit

28 Jun, 2003

1 commit

  • 8bde7f776   * Code cleanup: ... Browse Code »
    46

    - remove trailing white space, trailing empty lines, C++ comments, etc.
    - split cmd_boot.c (separate cmd_bdinfo.c and cmd_load.c)

    * Patches by Kenneth Johansson, 25 Jun 2003:
    - major rework of command structure
    (work done mostly by Michal Cendrowski and Joakim Kristiansen)

    wdenk
     

12 Mar, 2003

1 commit

  • 3bac35137   * Patch by Josef Wagner, 12 Mar 2003: ... Browse Code »

    - 16/32 MB and 50/80 MHz support with auto-detection for IP860
    - ETH05 and BEDBUG support for CU824
    - added support for MicroSys CPC45
    - new BOOTROM/FLASH0 and DOC base for PM826

    * Patch by Robert Schwebel, 12 Mar 2003:
    Fix the chpart command on innokom board

    * Name cleanup:
    mv include/asm-i386/ppcboot-i386.h include/asm-i386/u-boot-i386.h
    s/PPCBoot/U-Boot/ in some files
    s/pImage/uImage/ in some files

    * Patch by Detlev Zundel, 15 Jan 2003:
    Fix '' command line quoting

    * Patch by The LEOX team, 19 Jan 2003:
    - add support for the ELPT860 board
    - add support for Dallas ds164x RTC

    wdenk
     

18 Nov, 2002

1 commit