16 Oct, 2018
1 commit
-
Use a return type that can encompass the return value.
This fixes CoverityScan CID 184090.
Reported-by: Tom Rini
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf
24 Sep, 2018
6 commits
-
Create the handle of loaded images and the EFI_LOADED_IMAGE_PROTOCOL
inside efi_setup_loaded_image(). Do not use local variables.Currently we expect the loaded image handle to point to the loaded image
protocol. Additionally we have appended private fields to the protocol.With the patch the handle points to a loaded image object and the private
fields are added here. This matches how we handle the net and the gop
object.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
ascii2unicode() always ends the u16 string with '\0'.
Remove redundant assignment.Add description for efi_str_to_u16() and ascii2unicode().
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Currently we assign a lot of protocols to loaded images though
these protocols are not related to them. Instead they should be
installed on a separate handle. Via the device path it is the
parent to the devices like the network adapter.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
%s/efi_simple_input_interface/efi_simple_text_input_protocol/
We should be consistent in the naming of the EFI protocol interface
structures. The protocol is called EFI_SIMPLE_TEXT_INPUT_PROTOCOL.%s/ExtendedVerification/extended_verification/
Use consistent naming of function parameters. Do not use CamelCase.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
The patch implements the EFI_UNICODE_COLLATION_PROTOCOL.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Use CONFIG_IS_ENABLED(EFI_LOADER) to avoid explicitly checking CONFIG_SPL
too. This simplifies the conditional.Signed-off-by: Stephen Warren
Signed-off-by: Alexander Graf
20 Aug, 2018
1 commit
-
The crc32 of the runtime services table must be updated after detaching.
efi_update_table_header_crc32() must be __efi_runtime. So move it to
efi_runtime.cSigned-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf
25 Jul, 2018
5 commits
-
Remove unused function efi_get_time_init().
Initialization of the RTC has to be done in board bring up not in the EFI
subsystem.There is no RTC device in the UEFI spec. The RTC is only accessed through
the runtime services.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
The system table contains a link to the list of configurations tables.
These include the device tree, SMBIOS table, and the ACPI table.This array is currently statically linked. With the patch it is allocated
as EFI_RUNTIME_SERVICES_DATA. Due to the structure of the system table we
cannot work with a linked list here.Signed-off-by: Heinrich Schuchardt
Reviewed-by: Bin Meng
Signed-off-by: Alexander Graf -
For the boot and runtime services tables and for the system table the
crc32 has to be set in the header.Signed-off-by: Heinrich Schuchardt
Reviewed-by: Bin Meng
Signed-off-by: Alexander Graf -
The UEFI spec requires that the memory map key is checked in
ExitBootServices().Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Some times gcc may generate data that is then used within code that may
be part of an efi runtime section. That data could be jump tables,
constants or strings.In order to make sure we catch these, we need to ensure that gcc emits
them into a section that we can relocate together with all the other
efi runtime bits. This only works if the -ffunction-sections and
-fdata-sections flags are passed and the efi runtime functions are
in a section that starts with ".text".Up to now we had all efi runtime bits in sections that did not
interfere with the normal section naming scheme, but this forces
us to do so. Hence we need to move the efi_loader text/data/rodata
sections before the global *(.text*) catch-all section.With this patch in place, we should hopefully have an easier time
to extend the efi runtime functionality in the future.Signed-off-by: Alexander Graf
[agraf: Fix x86_64 breakage]
02 Jul, 2018
1 commit
-
ACPI tables can be passed via EFI configuration table to an EFI
application. This is only supported on x86 so far.Signed-off-by: Bin Meng
Reviewed-by: Simon Glass
03 Jun, 2018
2 commits
-
Clarify the operation of this code with some additional comments.
Signed-off-by: Simon Glass
Reviewed-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
The definitons of the variable services are adjusted:
- use efi_uintn_t instead of unsigned long
- use u16 * instead of s16 * for Unicode strings
- correct definition of QueryVariableInfo
- rename efi_get_next_variable to efi_get_next_variable_nameSigned-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf
29 May, 2018
1 commit
-
We were using our EFI_CACHELINE_SIZE define only in the runtime service
code, but left the image loader to use plain CONFIG_SYS_CACHELINE_SIZE.This patch moves EFI_CACHELINE_SIZE into efi_loader.h and converts
the image loader to use it.Signed-off-by: Alexander Graf
11 May, 2018
1 commit
-
As part of the main conversion a few files were missed. These files had
additional whitespace after the '*' and before the SPDX tag and my
previous regex was too strict. This time I did a grep for all SPDX tags
and then filtered out anything that matched the correct styles.Fixes: 83d290c56fab ("SPDX: Convert all of our single license tags to Linux Kernel style")
Reported-by: Heinrich Schuchardt
Signed-off-by: Tom Rini
24 Apr, 2018
3 commits
-
The missing services of the EFI_DEVICE_PATH_UTILITIES_PROTOCOL are
implemented.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Device paths may consist of multiple instances. Up to now we have only
considered the size of the first instance. For the services of the
EFI_DEVICE_PATH_UTILITIES_PROTOCOL in most cases the total length of the
device path is relevant.So let's rename efi_dp_size() to efi_dp_instance_size() and create a new
function efi_dp_size() that calculates the total device path length.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Implement the CreateDeviceNode service of the device path utility protocol.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf
05 Apr, 2018
3 commits
-
Introduce functions to print information about loaded images.
If we want to analyze an exception in an EFI image we need the offset
between the PC and the start of the loaded image.With efi_print_image_info() we can print the necessary information for a
single image, e.g.UEFI image [0xbffe6000:0xbffe631f] pc=0x138 '/\snp.efi'
efi_print_image_infos() provides output for all loaded images.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Implement the information type EFI_FILE_SYSTEM_INFO in the service
GetInfo() of the EFI_FILE_PROTOCOL.The volume label is not available in U-Boot. As a work-around use the
partition name instead.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
When converting an ASCII string to UTF-16 don't forget to copy the
trailing \0.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf
04 Apr, 2018
11 commits
-
If an event of a group event is signaled all other events of the same
group are signaled too.Function efi_signal_event is renamed to efi_queue_event.
A new function efi_signal_event is introduced that checks if an event
belongs to a group and than signals all events of the group.
Event group notifciation is implemented for ExitBootServices,
InstallConfigurationTable, and ResetSystem.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Event groups are used to signal multiple events at the same time.
They are identified by GUIDs. This patch provided the predefined
GUIDs of UEFI specification 2.7.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Lift the limit on the number of events by using a linked list.
This also allows to have events with type == 0.
This patch is based on Rob's patch
efi_loader: fix events
https://lists.denx.de/pipermail/u-boot/2017-October/309348.htmlSuggested-by: Rob Clark
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
The second argument of the bootefi command should always be usable to
specify a device tree. This was missing for bootefi selftest and
bootefi hello.Proper error handling is added.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
All EFI initialization functions should return a status code.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
efi_reset_system_init provides the architecture or board specific
initialization of the EFI subsystem. Errors should be caught and
signalled by a return code.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
efi_watchdog_register() should always return a status code and not
a boolean value.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Consistently return status codes form efi_net_register().
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
All initialization routines should return a status code instead of
a boolean.Signed-off-by: Heinrich Schuchardt
[agraf: Convert warnings to debug() prints]
Signed-off-by: Alexander Graf -
Errors may occur inside efi_smbios_register().
- Return a status code.
- Remove unused variables.
- Use constants where applicable.Suggested-by: Simon Glass
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Not complete, but enough for Shell.efi and SCT.efi. We'll implement the
rest as needed or once we have SCT running properly so there is a way to
validate the interface against the conformance test suite.Initial skeleton written by Leif, and then implementation by Rob.
Signed-off-by: Leif Lindholm
[Fill initial skeleton]
Signed-off-by: Rob Clark
[Rebase on v2018.03-rc1]
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf
10 Feb, 2018
2 commits
-
efi_disk_register should return as status code (efi_status_t).
Disks with zero blocks should be reported as 'not ready' without throwing
an error.This patch solves a problem running OpenBSD on system configured with
CONFIG_BLK=n (e.g. i.MX6).Reported-by: Jonathan Gray
Signed-off-by: Heinrich Schuchardt
Tested-by: Jonathan Gray
Signed-off-by: Alexander Graf -
Change the return type of efi_driver_init() to efi_status_t.
efi_driver_init() calls efi_add_driver() which returns an efi_status_t
value. efi_driver_init() should not subject this value to a conversion to
int losing high bits on 64bit systems.Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf
23 Jan, 2018
3 commits
-
This patch provides
* a uclass for EFI drivers
* a EFI driver for block devicesFor each EFI driver the uclass
* creates a handle
* adds the driver binding protocolThe uclass provides the bind, start, and stop entry points for the driver
binding protocol.In bind() and stop() it checks if the controller implements the protocol
supported by the EFI driver. In the start() function it calls the bind()
function of the EFI driver. In the stop() function it destroys the child
controllers.The EFI block driver binds to controllers implementing the block io
protocol.When the bind function of the EFI block driver is called it creates a
new U-Boot block device. It installs child handles for all partitions and
installs the simple file protocol on these.The read and write functions of the EFI block driver delegate calls to the
controller that it is bound to.A usage example is as following:
U-Boot loads the iPXE snp.efi executable. iPXE connects an iSCSI drive and
exposes a handle with the block IO protocol. It calls ConnectController.Now the EFI block driver installs the partitions with the simple file
protocol.iPXE uses the simple file protocol to load Grub or the Linux Kernel.
Signed-off-by: Heinrich Schuchardt
[agraf: add comment on calloc len]
Signed-off-by: Alexander Graf -
In ExitBootServices we need to signal events irrespective of the current
TPL level. A new parameter check_tpl is added to efi_signal_event().Function efi_console_timer_notify() gets some comments.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
On a block device and its partitions the same protocols can be
installed. To tell the apart we can use the type of the last
node of the device path which is not the end node.The patch provides a utility function to find this last node.
Signed-off-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf