21 Nov, 2018
3 commits
-
At present, stripped files don't have the right pathname which means that
blob compression cannot be used. Fix this.Signed-off-by: Simon Glass
-
This comma is not needed. Drop it.
Signed-off-by: Simon Glass
-
When the build fails due to something wrong in binman it is sometimes
useful to get a full backtrace showing the location of the failure. Add
a BINMAN_DEBUG environment variable to support this along with some
documentation.Signed-off-by: Simon Glass
23 Oct, 2018
1 commit
-
Unfortunately the test was not included in the original implementation.
Add one.Signed-off-by: Simon Glass
Signed-off-by: Simon Glass
22 Oct, 2018
1 commit
-
Some platforms use this instead of FSP to set up the platform, including
memory. Add support for this in binman. This is needed for
chromebook_samus, for example.Signed-off-by: Simon Glass
Reviewed-by: Bin Meng
09 Oct, 2018
1 commit
-
We now have 99 tests. Before adding any more, rename everything to three
digits. This helps to preserve the ordering of tests and makes it easier
to find things.Signed-off-by: Simon Glass
08 Oct, 2018
4 commits
-
At present the tests run one after the other using a single CPU. This is
not very efficient. Bring in the concurrencytest module and run the tests
concurrently, using one process for each CPU by default. A -P option
allows this to be overridden, which is necessary for code-coverage to
function correctly.This requires fixing a few tests which are currently not fully
independent.At some point we might consider doing this across all pytests in U-Boot.
There is a pytest version that supports specifying the number of processes
to use, but it did not work for me.Signed-off-by: Simon Glass
-
At present this test runs binman twice, which means that the temporary
files from the first run do not get cleaned up. Split this into two tests
to fix this problem.Signed-off-by: Simon Glass
-
At present 'make check' leaves some temporary directories around. Part of
this is because we call tools.PrepareOutputDir() twice in some cases,
without calling tools.FinaliseOutputDir() in between.Fix this.
Signed-off-by: Simon Glass
-
This module is often available in the sandbox_spl build created by
'make check'. Use this as a default path so that just typing 'binman -t'
(without setting PYTHONPATH) will generally run the tests.Signed-off-by: Simon Glass
01 Oct, 2018
1 commit
30 Sep, 2018
11 commits
-
When we get a problem like overlapping regions it is sometimes hard to
figure what what is going on. At present we don't write the map file in
this case. However the file does provide useful information.Catch any packing errors and write a map file (if enabled with -m) to aid
debugging.Signed-off-by: Simon Glass
-
For sandbox we want to put ELF files in the image since that is what we
need to execute. Add support for this.Signed-off-by: Simon Glass
-
Normally x86 platforms use the end-at-4gb option. This currently produces
an FMAP with positions which have a large offset. The use of end-at-4gb is
a useful convenience within binman, but we don't really want to export
a map with these offsets.Fix this by subtracting the 'skip at start' parameter.
Also put the code which convers names to fmap format, for clarity.
Signed-off-by: Simon Glass
-
At present sections have no record of their parent so it is not possible
to traverse up the tree to the root and figure out the position of a
section within the image.Change the constructor to record this information.
Signed-off-by: Simon Glass
-
When TPL is used on x86 we may want to program the microcode (at least for
the first CPU) early in boot. Add support for this by refactoring the
existing code to be more generic.Signed-off-by: Simon Glass
-
Sometimesi it us useful to be able to verify the content of entries with
a hash. Add an easy way to do this in binman. The hash information can be
retrieved from the device tree at run time.Signed-off-by: Simon Glass
-
Images and sections have the same attributes, since an image is mostly
just a top-level section. Update the docs to explain this.Signed-off-by: Simon Glass
-
It is useful to have entries which can grow automatically to fill
available space. Add support for this.Signed-off-by: Simon Glass
-
In some cases it is useful to add a group of files to the image and be
able to access them at run-time. Of course it is possible to generate
the binman config file with a set of blobs each with a filename. But for
convenience, add an entry type which can do this.Add required support (for adding nodes and string properties) into the
state module.Signed-off-by: Simon Glass
-
At present if there is only a zero-size entry in a section this is
reported as an error, e.g.:Offset 0x0 (0) is outside the section starting at 0x0 (0)
Adjust the logic in CheckEntries() to avoid this.
Signed-off-by: Simon Glass
-
Add support for compressing blob entries. This can help reduce image sizes
for many types of data. It requires that the firmware be able to
decompress the data at run-time.Signed-off-by: Simon Glass
29 Sep, 2018
14 commits
-
Binman currently supports updating the main device tree with things like
the position of each entry. Extend this support to SPL and TPL as well,
since they may need (a subset of) this information.Also adjust DTB output files to have a .out extension since this seems
clearer than having a .dtb extension with 'out' in the name somwhere.Also add a few missing comments and update the DT setup code to use
ReadFile and WriteFile().Signed-off-by: Simon Glass
-
We use a fake device tree in tests most of the time since tests don't
normally care about the actual data. For example, for U-Boot proper we use
U_BOOT_DTB_DATA which is just a four-character string. This makes testing
the image output against an expected value very easy.However in some cases, such as when the test wants to check that the DT
output containing particular nodes, we do actually need the real DT. Add
support for this, along with a command-line option to select 'test mode'.Signed-off-by: Simon Glass
-
We always have a device tree for U-Boot proper. But we may also have one
for SPL and TPL. Add a new Entry method to find out what DTs an entry
has, and use that list when updating DTs.Signed-off-by: Simon Glass
-
At present we have a few calls to device-tree functions in binman and plan
to add more as we add new entry types which need to report their results.It makes sense to put this code in a central place so that we can make
sure all device trees are updated. At present we only have U-Boot proper,
but plan to add SPL and TPL too.Signed-off-by: Simon Glass
-
Rather than reaching into this module from control, move the code that
needs this info into state.Signed-off-by: Simon Glass
-
At present the control module has state information in it, since it is the
primary user of this. But it is a bit odd to have entries and other
modules importing control to obtain this information.It seems better to have a dedicated state module, which control can use as
well. Create a new module using code from control and update other modules
to use it.Signed-off-by: Simon Glass
-
Various entry implementations provide a way to obtain the default filename
for an entry. But at present there is no base-class implementation for
this function. Add one so that the API is defined.Signed-off-by: Simon Glass
-
At present we require the caller to manually update the device tree using
individual calls to libfdt functions. This is not ideal. It would be
better if we could make changes using the Python structure and then call a
Sync() function to write them back.Add this feature to the Fdt class. Update binman and the tests to match.
Signed-off-by: Simon Glass
-
Sometimes it is useful to build only a subset of the images provided by
the binman configuration. Add a -i option for this. It can be given
multiple times to build several images. If the option is not given, all
images are built.Signed-off-by: Simon Glass
-
At present if there are two vblock entries an image their contents are
written to the same file in the output directory. This prevents checking
the contents of each separately.Fix this by adding part of the entry path to the filename, and add some
missing comments.Signed-off-by: Simon Glass
-
Sometimes we want to include TPL for x86 platforms, such as when we want
to select between different SPL images (e.g. for Chrome OS verified boot).
Add support for this.Signed-off-by: Simon Glass
-
When the value of a text entry is not provided an execption is generated
talking about a None type. This is confusing. Add a more explanatory error
and a test for this case.Signed-off-by: Simon Glass
-
The check for this should be for None, not 0. Fix it and add a test.
Signed-off-by: Simon Glass
-
This information should be in the entry it relates to, not in the main
README. Move it.Signed-off-by: Simon Glass
28 Sep, 2018
2 commits
-
This entry contains the PowerPC mpc85xx boot page and resetvec
sections.Signed-off-by: Jagdish Gediya
Reviewed-by: Simon Glass
Reviewed-by: Bin Meng
Reviewed-by: York Sun -
Currently binman calculates '_skip_at_start' based on 'end-at-4gb'
property and it is used for x86 images.For PowerPC mpc85xx based CPU, CONFIG_SYS_TEXT_BASE is the entry
offset of the first entry. It can be 0xeff40000 or 0xfff40000 for
nor flash boot, 0x201000 for sd boot etc, so "_skip_at_start"
should be set to CONFIG_SYS_TEXT_BASE.'end-at-4gb' property is not applicable where CONFIG_SYS_TEXT_BASE +
Image size != 4gb.Add new property 'skip-at-start' in Section class so that
'_skip_at_start' can be calculated either based on 'end-at-4gb'
or based on "skip-at-start".Add a test case to check that 'skip-at-start' and 'end-at-4gb'
property can't be used together.Signed-off-by: Jagdish Gediya
Reviewed-by: Bin Meng
Reviewed-by: Simon Glass
Reviewed-by: York Sun
18 Sep, 2018
1 commit
-
This fixes four small typos in the README file.
Signed-off-by: Michael Heimpold
Cc: Simon Glass
Reviewed-by: Bin Meng
Reviewed-by: Simon Glass
02 Aug, 2018
1 commit
-
At present this function takes a filename, but it is better to use an Fdt
object so that the caller can control this, perhaps obtainint the device
tree from a bytearray. Update the method accordingly and also fix a
confusing parameter name.Signed-off-by: Simon Glass