Eric Lee / smarc-uboot

02 Feb, 2019

5 commits

  • e3b4fc959   tools: dumpimage: Clarify help ... Browse Code »

    Help message isn't clear over the use of the "-T" option (it's to declare
    the type of image that the tool is operating on), which also is optional
    as it defaults to the default image type. It's also missing a description
    of the "-o" option, so add it.

    Signed-off-by: Martyn Welch

    Martyn Welch
     
  • 65a80b43b   tools: dumpimage: Add help option and make error paths consistent ... Browse Code »

    The utility dumpimage has error paths that display the usage and others
    that exit without displaying usage. Add an explicit help option to
    dumpimage to display the usage and remove it's use in error paths to make
    the error messages more obvious and errors paths more consistent.

    Signed-off-by: Martyn Welch

    Martyn Welch
     
  • 11e3c1fd3   tools: dumpimage: Simplify internal logic ... Browse Code »

    There are 3 supported modes of operation:

    1) Show version
    2) List image contents
    3) Extract image component

    Option (1) terminates early, so only options (2) and (3) remain. Remove
    redundant check for these modes.

    Signed-off-by: Martyn Welch

    Martyn Welch
     
  • 12b831879   tools: dumpimage: Simplify arguments ... Browse Code »
    15

    The dump image utility has very confusing syntax. If called to list image
    contents ("-l") it takes the image name as a positional argument. If the
    utility is called to extract something from the image, the image must be
    provided via the optional argument "-i" as well as the positional argument
    but the value passed in the positional argument will be completely
    ignored.

    Simplify dumpimage by always providing the image as the first positional
    argument. Assume we want to dump something from the image if we do not
    provide the "-l" option for now.

    Signed-off-by: Martyn Welch

    Martyn Welch
     
  • 57a608e96   tools: dumpimage: Provide more feedback on error ... Browse Code »

    The dumpimage utility errors out in a number of places without providing
    sufficient feedback to allow the user to easily determine what they have
    done wrong. Add addtional error messages to make the cause of the failure
    more obvious.

    Signed-off-by: Martyn Welch

    Martyn Welch
     

07 May, 2018

1 commit

  • 83d290c56   SPDX: Convert all of our single license tags to Linux Kernel style ... Browse Code »
    56

    When U-Boot started using SPDX tags we were among the early adopters and
    there weren't a lot of other examples to borrow from. So we picked the
    area of the file that usually had a full license text and replaced it
    with an appropriate SPDX-License-Identifier: entry. Since then, the
    Linux Kernel has adopted SPDX tags and they place it as the very first
    line in a file (except where shebangs are used, then it's second line)
    and with slightly different comment styles than us.

    In part due to community overlap, in part due to better tag visibility
    and in part for other minor reasons, switch over to that style.

    This commit changes all instances where we have a single declared
    license in the tag as both the before and after are identical in tag
    contents. There's also a few places where I found we did not have a tag
    and have introduced one.

    Signed-off-by: Tom Rini

    Tom Rini
     

30 Jan, 2015

4 commits

13 Dec, 2013

1 commit

  • a804b5ce2   Add dumpimage, a tool to extract data from U-Boot images ... Browse Code »

    Given a multi-file image created through the mkimage's -d option:

    $ mkimage -A x86 -O linux -T multi -n x86 -d vmlinuz:initrd.img:System.map \
    multi.img

    Image Name: x86
    Created: Thu Jul 25 10:29:13 2013
    Image Type: Intel x86 Linux Multi-File Image (gzip compressed)
    Data Size: 13722956 Bytes = 13401.32 kB = 13.09 MB
    Load Address: 00000000
    Entry Point: 00000000
    Contents:
    Image 0: 4040128 Bytes = 3945.44 kB = 3.85 MB
    Image 1: 7991719 Bytes = 7804.41 kB = 7.62 MB
    Image 2: 1691092 Bytes = 1651.46 kB = 1.61 MB

    It is possible to perform the innverse operation -- extracting any file from
    the image -- by using the dumpimage's -i option:

    $ dumpimage -i multi.img -p 2 System.map

    Although it's feasible to retrieve "data files" from image through scripting,
    the requirement to embed tools such 'dd', 'awk' and 'sed' for this sole purpose
    is cumbersome and unreliable -- once you must keep track of file sizes inside
    the image. Furthermore, extracting data files using "dumpimage" tool is faster
    than through scripting.

    Signed-off-by: Guilherme Maciel Ferreira
    Signed-off-by: Simon Glass

    Guilherme Maciel Ferreira