Eric Lee / smarc-uboot

10 Oct, 2013

2 commits

  • cc734f5ab   cmd_ubi: add write.part command, to write a volume in multiple parts ... Browse Code »

    This allows you to write data to an UBI volume when the amount of memory
    available to write that data from is less than the total size of the
    data. For example, you may split a root filesystem UBIFS image into
    parts, provide the total size of the image to the first write.part
    command and then use multiple write.part commands to write the
    subsequent parts of the volume. This results in a sequence of commands
    akin to:

    ext4load mmc 0:1 0x80000000 rootfs.ubifs.0
    ubi write.part 0x80000000 root 0x08000000 0x18000000
    ext4load mmc 0:1 0x80000000 rootfs.ubifs.1
    ubi write.part 0x80000000 root 0x08000000
    ext4load mmc 0:1 0x80000000 rootfs.ubifs.2
    ubi write.part 0x80000000 root 0x08000000

    This would write 384MiB of data to the UBI volume 'root' whilst only
    requiring 128MiB of said data to be held in memory at a time.

    Signed-off-by: Paul Burton
    Acked-by: Stefan Roese

    Paul Burton
     
  • dd7185f17   cmd_ubi: use int64_t volume size for 'ubi create' ... Browse Code »

    int64_t matches the bytes field in struct ubi_mkvol_req to which the
    size is assigned. With the prior signed 32 bit integer, volumes were
    restricted to being less than 2GiB in size.

    Signed-off-by: Paul Burton
    Acked-by: Stefan Roese

    Paul Burton
     

12 Apr, 2013

2 commits

07 Mar, 2012

1 commit

02 Oct, 2011

1 commit

21 Mar, 2011

1 commit

  • 7f5d8a4d8   UBI: Fix error code handling in ubi commands ... Browse Code »

    Some ubi commands returned negative error codes, resulting in
    the following error message on the prompt:

    "exit not allowed from main input shell."

    Negative error codes are not allowed.

    This patch now changes the UBI code to return positive error codes.
    Additionally "better" error codes are used, for example "ENOMEM" when
    no memory is available for the UBI volume creation any more.

    Also the output of some commands is enhanced:

    Before:

    => ubi read 100000 testvol 100000
    Volume testvol found at volume id 0
    read 1048576 bytes from volume 0 to 100000(buf address)
    => ubi write 100000 testvol 1000
    Volume testvol found at volume id 0

    After:

    => ubi read 100000 testvol 100000
    Read 1048576 bytes from volume testvol to 00100000
    => ubi write 100000 testvol 1000
    4096 bytes written to volume testvol

    Signed-off-by: Stefan Roese
    Cc: Wolfgang Denk

    Stefan Roese
     

04 Dec, 2010

1 commit

09 Aug, 2010

1 commit

25 Jul, 2010

1 commit

  • 47e26b1bf   cmd_usage(): simplify return code handling ... Browse Code »

    Lots of code use this construct:

    cmd_usage(cmdtp);
    return 1;

    Change cmd_usage() let it return 1 - then we can replace all these
    ocurrances by

    return cmd_usage(cmdtp);

    This fixes a few places with incorrect return code handling, too.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

05 Jul, 2010

1 commit

  • 54841ab50   Make sure that argv[] argument pointers are not modified. ... Browse Code »
    1

    The hush shell dynamically allocates (and re-allocates) memory for the
    argument strings in the "char *argv[]" argument vector passed to
    commands. Any code that modifies these pointers will cause serious
    corruption of the malloc data structures and crash U-Boot, so make
    sure the compiler can check that no such modifications are being done
    by changing the code into "char * const argv[]".

    This modification is the result of debugging a strange crash caused
    after adding a new command, which used the following argument
    processing code which has been working perfectly fine in all Unix
    systems since version 6 - but not so in U-Boot:

    int main (int argc, char **argv)
    {
    while (--argc > 0 && **++argv == '-') {
    /* ====> */ while (*++*argv) {
    switch (**argv) {
    case 'd':
    debug++;
    break;
    ...
    default:
    usage ();
    }
    }
    }
    ...
    }

    The line marked "====>" will corrupt the malloc data structures and
    usually cause U-Boot to crash when the next command gets executed by
    the shell. With the modification, the compiler will prevent this with
    an
    error: increment of read-only location '*argv'

    N.B.: The code above can be trivially rewritten like this:

    while (--argc > 0 && **++argv == '-') {
    char *arg = *argv;
    while (*++arg) {
    switch (*arg) {
    ...

    Signed-off-by: Wolfgang Denk
    Acked-by: Mike Frysinger

    Wolfgang Denk
     

09 Apr, 2010

1 commit

  • 3b653fdb3   cmd_ubi: Fix uninitialized variable warning ... Browse Code »

    gcc 3.4.6 previously reported the following error on many MIPS boards
    which utilize UBI:
    cmd_ubi.c:193: warning: 'vol' might be used uninitialized in this function

    The current code is structured such that 'vol' will never be used when
    it is NULL anyway, but gcc isn't smart enough to figure this out.

    Signed-off-by: Peter Tyser
    Signed-off-by: Stefan Roese

    Peter Tyser
     

21 Jul, 2009

1 commit

09 Jul, 2009

1 commit

  • 25c8f4005   Handle VID header offset in ubi part command ... Browse Code »

    The VID header offset is sometimes needed to initialize the UBI
    partition. This patch adds it (optionally) to the command line
    for the ubi part command.

    (Lines have been properly wrapped since last version)

    Signed-off-by: Simon Kagstrom
    Acked-by: Stefan Roese
    Signed-off-by: Stefan Roese

    Simon Kagstrom
     

13 Jun, 2009

1 commit

  • a89c33db9   General help message cleanup ... Browse Code »

    Many of the help messages were not really helpful; for example, many
    commands that take no arguments would not print a correct synopsis
    line, but "No additional help available." which is not exactly wrong,
    but not helpful either.

    Commit ``Make "usage" messages more helpful.'' changed this
    partially. But it also became clear that lots of "Usage" and "Help"
    messages (fields "usage" and "help" in struct cmd_tbl_s respective)
    were actually redundant.

    This patch cleans this up - for example:

    Before:
    => help dtt
    dtt - Digital Thermometer and Thermostat

    Usage:
    dtt - Read temperature from digital thermometer and thermostat.

    After:
    => help dtt
    dtt - Read temperature from Digital Thermometer and Thermostat

    Usage:
    dtt

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

20 May, 2009

1 commit

28 Apr, 2009

1 commit

  • 2d579e506   ubi: Remove flash selection parameter (nor|nand|onenand) from "ubi part" ... Browse Code »

    This patch removes the now unnecessary flash type parameter from the
    "ubi part" command. Currently the user has to define the type of flash
    he will be using UBI on. Example:

    => ubi part nor partition1

    With this patch this type parameter is not needed anymore. The user can
    now select the partition directly without the flash type paramter.
    Example:

    => ubi part partition1

    This breaks backward compatibility right now because of the change in the
    command syntax. But UBI support is still quite fresh and the advantage of
    this new command is syntax big enough for this change. Additionally the
    code is much cleaner now.

    Signed-off-by: Stefan Roese
    CC: Kyungmin Park

    Stefan Roese
     

05 Apr, 2009

1 commit

  • c203ef5db   UBI/cfi-mtd: Fix mtd name for multiple chips ... Browse Code »

    On platforms with multiple NOR chips, currently only the first one
    can be selected using the "ubi part" command. This patch fixes this
    problem by using different names for the NOR "mtd devices".

    It also changes the name of the NOR MTD device from "cfi-mtd" to
    "norX" (X indexing the device numer) to better match the mtdparts
    defaults.

    Signed-off-by: Stefan Roese
    Signed-off-by: Andreas Huber

    Andreas Huber
     

28 Jan, 2009

2 commits

16 Dec, 2008

1 commit

10 Dec, 2008

1 commit

09 Dec, 2008

2 commits

24 Nov, 2008

2 commits

20 Nov, 2008

1 commit

  • 694a0b3f1   UBI: Add UBI command support ... Browse Code »

    This patch adds these UBI commands:

    ubi part [nand|onenand] [part] - Show or set current partition
    ubi info [l[ayout]] -Display volume and UBI layout information
    ubi create[vol] volume [size] [type] - Create volume name with size
    ubi write[vol] address volume size - Write volume from address with size
    ubi read[vol] address volume [size] - Read volume to address with size
    ubi remove[vol] volume - Remove volume

    Signed-off-by: Kyungmin Park
    Signed-off-by: Stefan Roese

    Kyungmin Park