11 Sep, 2018
18 commits
-
FPGA changes for v2018.11
- add fpga tests to cover fpga commands
- fpga Kconfig cleanup
- fix cmd/fpga.c
- add support for missing fpga loadmk commands
- add fpga fragment to MAINTAINERS -
Convert last loads command to fpga subcommands.
Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Use standard return command failure macro.
Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
There are ways how to call fpga loadmk
1. Full command
fpga loadmk [dev] [address]2. Dev setup via variable
set fpga [dev]
fpga loadmk [address]3. Address setup via variable
set fpgadata [address]
fpga loadmk [dev]4. Dev and address setup via variables
set fpga [dev]
set fpgadata [address]
fpga loadmkBefore this patch only cases 1 and 3 are working but the part of code
was trying to support also cases 2 and 4.
This patch is adding support for cases 2 and 4 to have all of
combinations supported.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Convert loadmk command to fpga subcommands. Not all combinations are
working but they have never worked properly. This will be fixed later.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Convert loadfs command to fpga subcommands.
Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Separate dump, load, loadb, loadp and loadbp commands to separate
functions to make it clear how they are called and what parameters they
need.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Move fpga info to U_BOOT_CMD_MKENT subcommand.
Also use strtol instead of simple_strtoul. The reason is that if -1 is
passed (or fpga info without "fpga" variable) the list of all fpgas is
shown.
This functionality is in the fpga core but it couldn't be performed.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Create command wrapper to clean fpga subcommands.
The function logic is taken from cmd_dm.cSigned-off-by: Michal Simek
Reviewed-by: Simon Glass -
There is no reason to check parameters in separate switch. Check them
directly when they are read. Also there is no reason to check loadmk
case separately because fpga_data address must be non zero too.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Parameter checking is dead code because all the time there must be all
params assigned. If they are not assigned there is no 9th parameters
passed and checking before return CMD_RET_USAGE.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
There is no reason to check parameters in separate switch before main
one. This patch is simplifying error path and checking parameters right
after assignment.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Incorrect command is already handled and FPGA_NONE should be used only
one. In case of error CMD_RET_USAGE can be returned directly without any
addition logic around.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Move fpga_get_op() to top of file to remove local function declaration
and also remove useless retyping.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Clean fpga_get_op() error handling by moving checking/print to do_fpga.
Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
The patch applied in 2010
"cmd_fpga: cleanup help and check parameters"
(sha1: a790b5b2326be9d7c9ad9e3d9b51a8bfabc62d07"
was adding this checking+ if (dev == FPGA_INVALID_DEVICE) {
+ puts("FPGA device not specified\n");
+ op = FPGA_NONE;
+ }which simply broke one command flow which was
setenv fpga
fpga loadmk // legacy image
fpga loadmk : //fit imageAlso this sequence for FIT image is completely broken
setenv fpga
setenv fpgadata :
fpga loadmk
(Note: For legacy images this is working fine).even from code I don't think this has ever worked properly
for fit image (dev = FPGA_INVALID_DEVICE should be rejected
by fpga core). Fit image support was in 2008 added by:
"[new uImage] Add new uImage fromat support to fpga command"
(sha1: c28c4d193dbfb20b2dd3a5447640fd6de7fd0720)Just a summary of these facts that none found this for pretty long time
it shouldn't be a problem to remove this flow (without fpga dev)
completely to simplify the code.Signed-off-by: Michal Simek
Reviewed-by: Simon Glass -
Use Macro instead of hard code.
Signed-off-by: Kever Yang
Reviewed-by: Philipp Tomsich -
In int-ll64.h, we always use the following typedefs:
typedef unsigned int u32;
typedef unsigned long uintptr_t;
typedef unsigned long long u64;This does not need to match to the compiler's .
Do not include it.The use of PRI* makes the code super-ugly. You can simply use
"l" for printing uintptr_t, "ll" for u64, and no modifier for u32.Signed-off-by: Masahiro Yamada
27 Aug, 2018
1 commit
-
It is not preferred to put SUNXI-specific code in the common place.
Change it to 'imply' property of ARCH_SUNXI.
Signed-off-by: Masahiro Yamada
25 Aug, 2018
2 commits
-
Prevent cache warning messages when using the 'bootelf' command on an
Arm target. Round down each section start address and round up the
respective section end to the nearest cache line.Currently when using bootelf to load an image on Arm, several warnings
such as the following appear in the console:
CACHE: Misaligned operation at range [87800000, 8783c5e0]
CACHE: Misaligned operation at range [8783c5e0, 8784b3e0]Signed-off-by: Neil Stainton
[trini: Reword commit message to include the info after the --- which
included the Signed-off-by line, and change ' at ' to '@']
Signed-off-by: Tom Rini
22 Aug, 2018
1 commit
-
Patch queue for efi - 2018-08-21
A few fixes for 2018.09. Most noticable are:
- unbreak x86 target (-fdata-section fallout)
- fix undefined behavior in a few corner cases
- make Jetson TX1 boot again
- RTS fixes
- implement reset for simple output
21 Aug, 2018
5 commits
-
In some cases it can be useful to be able to bind a device to a driver from
the command line.
The obvious example is for versatile devices such as USB gadget.
Another use case is when the devices are not yet ready at startup and
require some setup before the drivers are bound (ex: FPGA which bitsream is
fetched from a mass storage or ethernet)usage example:
bind usb_dev_generic 0 usb_ether
unbind usb_dev_generic 0 usb_ether
or
unbind eth 1bind /ocp/omap_dwc3@48380000/usb@48390000 usb_ether
unbind /ocp/omap_dwc3@48380000/usb@48390000Signed-off-by: Jean-Jacques Hiblot
-
In case when user provides '-' as USB controller index, like this:
=> fastboot -
data abort occurs in strcmp() function in do_fastboot(), here:
if (!strcmp(argv[1], "udp"))
(tested on BeagleBone Black).
That's because argv[1] is NULL when user types in the '-', and null
pointer dereference occurs in strcmp() (which is ok according to C
standard specification). So we must validate user input to prevent such
behavior.While at it, check also the result of strtoul() function and handle
error cases properly.Signed-off-by: Sam Protsenko
Reviewed-by: Simon Glass
Reviewed-by: Lukasz Majewski -
Fix cppcheck complaint:
[cmd/efi.c:173]: (style) Clarify calculation precedence for '&' and '?'.Fixes: f1a0bafb5802 ("efi: Add a command to display the memory map")
Signed-off-by: Eugeniu Rosca
Reviewed-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
With this update, the memory attributes are in sync with Linux
kernel v4.18-rc4. They also match page 190 of UEFI 2.7 spec [1].[1] http://www.uefi.org/sites/default/files/resources/UEFI_Spec_2_7.pdf
Suggested-by: Heinrich Schuchardt
Signed-off-by: Eugeniu Rosca
Reviewed-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf -
Starting with commit 867a6ac86dd8 ("efi: Add start-up library code"),
sparse constantly complains about truncated constant value in efi.h:include/efi.h:176:35: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
This can get quite noisy, preventing real issues to be noticed:
$ make defconfig
*** Default configuration is based on 'sandbox_defconfig'
$ make C=2 -j12 2>&1 | grep truncates | wc -l
441After the patch is applied:
$ make C=2 -j12 2>&1 | grep truncates | wc -l
0
$ sparse --version
v0.5.2Following the suggestion of Heinrich Schuchardt, instead of only
fixing the root-cause, I replaced the whole enum of _SHIFT values
by ULL defines. This matches both the UEFI 2.7 spec and the Linux
kernel implementation.Some ELF size comparison before and after the patch (gcc 7.3.0):
efi-x86_payload64_defconfig:
text data bss dec hex filename
407174 29432 278676 715282 aea12 u-boot.old
407152 29464 278676 715292 aea1c u-boot.new
-22 +32 0 +10efi-x86_payload32_defconfig:
text data bss dec hex filename
447075 30308 280076 757459 b8ed3 u-boot.old
447053 30340 280076 757469 b8edd u-boot.new
-22 +32 0 +10Fixes: 867a6ac86dd8 ("efi: Add start-up library code")
Suggested-by: Heinrich Schuchardt
Signed-off-by: Eugeniu Rosca
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Heinrich Schuchardt
Signed-off-by: Alexander Graf
20 Aug, 2018
1 commit
-
dtimg command allows user to work with Android DTB/DTBO image format.
Such as, getting the address of desired DTB/DTBO file, printing the dump
of the image in U-Boot shell, etc.This command is needed to provide Android boot with new Android DT image
format further.Signed-off-by: Sam Protsenko
Reviewed-by: Tom Rini
18 Aug, 2018
1 commit
-
This converts the following to Kconfig:
CONFIG_MII
CONFIG_DRIVER_TI_EMACSigned-off-by: Adam Ford
Acked-by: Jagan Teki
Acked-by: Joe Hershberger
12 Aug, 2018
1 commit
11 Aug, 2018
2 commits
-
Add a command to debug the AXI bus.
Reviewed-by: Simon Glass
Signed-off-by: Mario Six -
This update adds PPC64 ELF V1 ABI support to bootelf for both the
program header and section header options. Elf64 support was already
present for the program header option, but it was not handling the
PPC64 ELF V1 ABI case. For the PPC64 ELF V1 ABI, the e_entry field of
the elf header must be treated as function descriptor pointer instead
of a function address. The first doubleword of the function descriptor
is the function's entry address.Signed-off-by: Rob Bracero
[trini: Fix whitespace issues]
Signed-off-by: Tom Rini
10 Aug, 2018
1 commit
-
sata_probe returns 1 for failure, so don't checkout for < 0
fixes: f19f1ecb6025 dm: sata: Support driver model with the 'sata' command
Signed-off-by: Troy Kisky
Reviewed-by: Simon Glass
31 Jul, 2018
1 commit
-
Patch queue for efi - 2018-07-25
Highlights this time:
- Many small fixes to improve spec compatibility (found by SCT)
- Almost enough to run with sandbox target
- GetTime() improvements
- Enable EFI_LOADER and HYP entry on ARMv7 with NONSEC=y
30 Jul, 2018
4 commits
-
The TPMv2 code requires the log functionality, so select it.
Signed-off-by: Tom Rini
-
CMD_DM is used for debug purpose and it shouldn't be enabled by default
via Kconfig. Unfortunately this is in the tree for quite a long time
that's why solution is to use imply DM for all targets which are
enabling DM.Signed-off-by: Michal Simek
Reviewed-by: Tom Rini
Reviewed-by: Joe Hershberger -
Fix Kconfig bool, default, select and imply options to be
alphabetically sorted.Signed-off-by: Michal Simek
Reviewed-by: Tom Rini -
Trivial Kconfig cleanup. Use tabs instead of spaces and every Kconfig
entry should be separated by newline.Signed-off-by: Michal Simek
Reviewed-by: Tom Rini
Reviewed-by: Joe Hershberger
28 Jul, 2018
1 commit
-
While there is probably no reason to do so in a real life situation, it
will allow to compile test both stacks with the same sandbox defconfig.As we cannot define two 'tpm' commands at the same time, the command for
TPM v1 is still called 'tpm' and the one for TPM v2 'tpm2'. While this
is the exact command name that must be written into eg. test files, any
user already using the TPM v2 stack can continue to do so by just writing
'tpm' because as long as TPM v1 support is not compiled, U-Boot prompt
will search for the closest command named after 'tpm'.The command set can also be changed at runtime (not supported yet, but
ready to be), but as one can compile only either one stack or the other,
there is still one spot in the code where conditionals are used: to
retrieve the v1 or v2 command set.Signed-off-by: Miquel Raynal
Reviewed-by: Simon Glass
[trini: In sandbox_tpm2_fill_buf() use NULL not \0 to ensure NULL
terminated string due to LLVM warning]
Signed-off-by: Tom Rini
27 Jul, 2018
1 commit