11 Oct, 2018
2 commits
-
Peter originally sent a fix, but it breaks a number of other things.
This addresses the original reported issue in a different way.That report was:
> U-Boot has 1 common buffer to send Ethernet frames, pointed to by
> net_tx_packet. When sending to an IP address without knowing the MAC
> address, U-Boot makes an ARP request (using the arp_tx_packet buffer)
> to find out the MAC address of the IP addressr. When a matching ARP
> reply is received, U-Boot continues sending the frame stored in the
> net_tx_packet buffer.
>
> However, in the mean time, if U-Boot needs to send out any network
> packets (e.g. replying ping packets or ARP requests for its own IP
> address etc.), it will use the net_tx_packet buffer to prepare the
> new packet. Thus this buffer is no longer the original packet meant
> to be transmitted after the ARP reply. The original packet will be
> lost.This instead uses the ARP tx buffer to send async replies in the case
where we are actively waiting for an ARP reply.Signed-off-by: Joe Hershberger
Reported-by: Tran Tien Dat
Reviewed-by: Simon Glass
Reviewed-by: Bin Meng
Tested-by: Bin Meng -
This single-sources the state of the ARP.
Signed-off-by: Joe Hershberger
Reviewed-by: Simon Glass
Reviewed-by: Bin Meng
14 Jun, 2018
1 commit
-
Make sure that TX packets are always cache-aligned.
Signed-off-by: Mario Six
Acked-by: Joe Hershberger
11 May, 2018
1 commit
-
As part of the main conversion a few files were missed. These files had
additional whitespace after the '*' and before the SPDX tag and my
previous regex was too strict. This time I did a grep for all SPDX tags
and then filtered out anything that matched the correct styles.Fixes: 83d290c56fab ("SPDX: Convert all of our single license tags to Linux Kernel style")
Reported-by: Heinrich Schuchardt
Signed-off-by: Tom Rini
16 Aug, 2017
1 commit
-
We are now using an env_ prefix for environment functions. Rename setenv()
for consistency. Also add function comments in common.h.Suggested-by: Wolfgang Denk
Signed-off-by: Simon Glass
12 May, 2017
1 commit
-
The value of variable pkt is never used.
The problem was indicated by clang scan-build.
Signed-off-by: Heinrich Schuchardt
29 Oct, 2015
2 commits
-
eth_rx() in the main reception loop may trigger sending a packet which
is already timed out (or will immediately) upon reception of an ARP reply.
As long as the ARP reply is pending, the timeout handler of a packet
should be postponed.
Happens on TFTP with bad network (e.g. WLAN).Signed-off-by: Stefan Brüns
Acked-by: Joe Hershberger -
net_start_again() will be called from net_loop() if state is NETLOOP_FAIL.
Signed-off-by: Stefan Brüns
Acked-by: Joe Hershberger
19 Apr, 2015
5 commits
-
Finish eliminating CamelCase from net.c and other failures
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Make a thorough pass through all variables and function names contained
within arp and remove CamelCase and improve naming.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
This patch cleans up the names of internal packet buffer names that are
used within the network stack and the functions that use them.Signed-off-by: Joe Hershberger
-
Use "_ethaddr" at the end of variables and drop CamelCase.
Make constant values actually 'const'.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
This patch is simply clean-up to make the IPv4 type that is used match
what Linux uses. It also attempts to move all variables that are IP
addresses use good naming instead of CamelCase. No functional change.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass
10 Oct, 2014
1 commit
-
A number of network related files were imported from the LiMon
project; these contain a somewhat unclear license statement:Copyright 1994 - 2000 Neil Russell.
(See License)I analyzed the source code of LiMon v1.4.2 which was used for this
import. It does not contain any "License" file, but the top level
directory contains a file "COPYING", which turns out to be GPL v2
of June 1991. So it is legitimate to conclude that the LiMon derived
files are also to be released under GPLv2. Mark them as such.Signed-off-by: Wolfgang Denk
05 Nov, 2012
1 commit
-
bootp.c:44:14: warning: symbol 'dhcp_state' was not declared. Should it be static?
bootp.c:45:15: warning: symbol 'dhcp_leasetime' was not declared. Should it be static?
bootp.c:46:10: warning: symbol 'NetDHCPServerIP' was not declared. Should it be static?
arp.c:30:17: warning: symbol 'NetArpWaitReplyIP' was not declared. Should it be static?
arp.c:37:16: warning: symbol 'NetArpTxPacket' was not declared. Should it be static?
arp.c:38:17: warning: symbol 'NetArpPacketBuf' was not declared. Should it be static?
atheros.c:33:19: warning: symbol 'AR8021_driver' was not declared. Should it be static?
net.c:183:7: warning: symbol 'PktBuf' was not declared. Should it be static?
net.c:159:21: warning: symbol 'net_state' was not declared. Should it be static?
ping.c:73:6: warning: symbol 'ping_start' was not declared. Should it be static?
ping.c:82:13: warning: symbol 'ping_receive' was not declared. Should it be static?
tftp.c:53:7: warning: symbol 'TftpRRQTimeoutMSecs' was not declared. Should it be static?
tftp.c:54:5: warning: symbol 'TftpRRQTimeoutCountMax' was not declared. Should it be static?
eth.c:125:19: warning: symbol 'eth_current' was not declared. Should it be static?Note: in the ping.c fix, commit a36b12f95a29647a06b5459198684fc142482020
"net: Move PING out of net.c" mistakenly carried the ifdef CMD_PING
clause from when it was necessary to avoid warnings when it was embedded
in net.c.Signed-off-by: Kim Phillips
10 Jul, 2012
1 commit
-
The clean up patch missed an &, so we end up passing an int rather than
a pointer to the sprintf function.arp.c: In function 'ArpReceive':
arp.c:197: warning: format '%p' expects type 'void *', but argument 3 has type 'int'Signed-off-by: Mike Frysinger
24 May, 2012
15 commits
-
Add several levels of DEBUG prints so that you can limit the noise to
the severety of your problem.DEBUG_LL_STATE = Link local state machine changes
DEBUG_DEV_PKT = Packets or info directed to the device
DEBUG_NET_PKT = Packets on info on the network at large
DEBUG_INT_STATE = Internal network state changesSigned-off-by: Joe Hershberger
-
Cisco's arp-proxy feature fails to ignore the link-local address range
This means that a link-local device on a network with this Cisco
equipment will reply to ARP requests for our device (in addition to
our reply).
If we happen to reply first, the requester's ARP table will be
populated with our MAC address, and one packet will be sent to us...
shortly following this, the requester will get an ARP reply from the
Cisco equipment telling the requester to send packets their way
instead of to our device from now on.
This work-around detects this link-local condition and will delay
replying to the ARP request for 5ms so that the first packet is sent
to the Cisco equipment and all following packets are sent to our
device.Signed-off-by: Joe Hershberger
-
Link-local support will need to send ARP packets, but needs more
fine-grained control over the contents. Split the implementation
into 2 parts so link-local can share the code.Signed-off-by: Joe Hershberger
-
Use the NetArpTxPacket for the ARP packet, not to hold what used to
be in NetTxPacket.
This saves a copy and makes the code easier to understand.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Don't force ARP clients to return the MAC address if they don't care
(such as ping)Signed-off-by: Joe Hershberger
Acked-by: Mike Frysinger -
When the network is VLAN or SNAP, net_update_ether() will preserve
the original Ethernet packet header and simply replace the src and
dest MACs and the protocolSigned-off-by: Joe Hershberger
Acked-by: Simon Glass -
Call a built-in dummy if none is registered... don't require
protocols to register a handler (eliminating dummies)
NetConsole now uses the ARP handler when waiting on arp
(instead of needing a #define hack in arp.c)
Clear handlers at the end of net loopSigned-off-by: Joe Hershberger
Acked-by: Simon Glass -
Use this entry-point consistently across the net/ code
Use a static inline function to preserve code sizeSigned-off-by: Joe Hershberger
Acked-by: Simon Glass -
Save the length when it is computed instead of forgetting it and
subtracting pointers to figure it out again.Signed-off-by: Joe Hershberger
Acked-by: Simon Glass
Acked-by: Mike Frysinger -
Use field names and sizes when accessing ARP packets
Signed-off-by: Joe Hershberger
-
Renamed for clarity
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass -
Remove typedef and lower-case letters
Signed-off-by: Joe Hershberger
-
Separate the Ethernet header from the 802 header.
Base the size constants on the structs.Signed-off-by: Joe Hershberger
-
Rename IP header related things to IP_UDP. The existing definition
of IP_t includes UDP header, so name it to accurately describe the
structure.Signed-off-by: Joe Hershberger
-
Separate this functionality out of the net.c behemoth
Signed-off-by: Joe Hershberger
Acked-by: Simon Glass
Acked-by: Mike Frysinger
06 Jun, 2003
1 commit
-
* Add support for TQM862L at 100/50 MHz
* Patch by Pantelis Antoniou, 02 Jun 2003:
major reconstruction of networking code;
add "ping" support (outgoing only!)
28 Sep, 2002
1 commit