11 Mar, 2018

6 commits

  • The README.mxc_hab is outdated and need improvements, add the following
    modifications:

    - Reorganize document and remove duplicate content
    - Add CST download link
    - Update CST package name
    - Align command lines with CST v2.3.3
    - Update U-Boot binary name
    - Remove CSF padding since is not documented in AN4581

    Signed-off-by: Breno Lima

    Breno Lima
     
  • Currently the High Assurance Boot procedure is documented in two
    places:

    - doc/README.imx6
    - doc/README.mxc_hab

    It is better to consolidate all HAB related information into
    README.mxc_hab file, so move the content from README.imx6 to
    README.mxc_hab.

    Signed-off-by: Breno Lima
    Reviewed-by: Fabio Estevam

    Breno Lima
     
  • commit cd2d46003ce1 ("arm: imx: hab: Add IVT header definitions") declares
    struct ivt_header as "__attribute__((packed))".

    commit ed286bc80e9d ("imx: hab: Check if CSF is valid before
    authenticating image") declares struct hab_hdr with __packed.

    This patch makes the __packed convention consistent.

    Signed-off-by: Bryan O'Donoghue
    Cc: Utkarsh Gupta
    Cc: Breno Lima
    Cc: Fabio Estevam
    Reviewed-by: Fabio Estevam

    Bryan O'Donoghue
     
  • commit ed286bc80e9d ("imx: hab: Check if CSF is valid before authenticating
    image") makes use of "__packed" as a prefix to the "struct hab_hdr"
    declaration.

    With my compiler "gcc version 7.2.1 20171011 (Linaro GCC 7.2-2017.11)" we
    get:

    ./arch/arm/include/asm/mach-imx/hab.h:42:25: error: expected ‘=’, ‘,’, ‘;’,
    ‘asm’ or ‘__attribute__’ before ‘{’ token
    struct __packed hab_hdr {

    Fix this problem by including

    Signed-off-by: Bryan O'Donoghue
    Cc: Utkarsh Gupta
    Cc: Breno Lima
    Cc: Fabio Estevam
    Reviewed-by: Fabio Estevam

    Bryan O'Donoghue
     
  • This patch fixes the wrongly included dtsi file which was
    breaking mainline support for Engicam i.CoreM6 DualLite/Solo RQS.

    Linux commit details for the same change as
    "ARM: dts: imx6dl: Include correct dtsi file for Engicam i.CoreM6
    DualLite/Solo RQS"
    (sha1: c0c6bb2322964bd264b4ddedaa5776f40c709f0c)

    Signed-off-by: Jagan Teki
    Reviewed-by: Fabio Estevam

    Jagan Teki
     
  • usdhc4 node need to update pinctrl, bus-width and non-removable
    properties, sync the same from Linux.

    Signed-off-by: Jagan Teki
    Reviewed-by: Fabio Estevam

    Jagan Teki
     

10 Mar, 2018

9 commits


09 Mar, 2018

7 commits

  • The following config symbols are only defined once and never referenced
    anywhere else:

    CONFIG_AT91SAM9263EK
    CONFIG_AT91SAM9RLEK
    CONFIG_BARIX_IPAM390
    CONFIG_BOARD_H2200
    CONFIG_EP9301
    CONFIG_KZM_A9_GT
    CONFIG_PICOSAM
    CONFIG_PLATINUM_PICON
    CONFIG_PLATINUM_TITANIUM
    CONFIG_PM9261
    CONFIG_PM9263
    CONFIG_PM9G45
    CONFIG_SIEMENS_DRACO
    CONFIG_SIEMENS_PXM2
    CONFIG_SIEMENS_RUT
    CONFIG_SMDKC100
    CONFIG_SMDKV310
    CONFIG_STM32F4DISCOVERY

    Most of them are config symbols named after the respective boards which
    seems to have been a standard practice at some point.

    Signed-off-by: Tuomas Tynkkynen

    Tuomas Tynkkynen
     
  • The following config symbols are only defined once and never referenced
    anywhere else:

    CONFIG_ARM926EJS
    CONFIG_CPUAT91
    CONFIG_EXYNOS5800
    CONFIG_SYS_CORTEX_R4

    Most of them are config symbols named after the respective SoCs which
    seems to have been a standard practice at some point.

    Signed-off-by: Tuomas Tynkkynen

    Tuomas Tynkkynen
     
  • The following config symbols are only defined once and never referenced
    anywhere else:

    CONFIG_DBAU1X00
    CONFIG_PB1X00

    Most of them are config symbols named after the respective boards which
    seems to have been a standard practice at some point.

    Signed-off-by: Tuomas Tynkkynen

    Tuomas Tynkkynen
     
  • The @gdsys.cc addresses are supposed to be used for mailing lists.
    Switch all occurrences of @gdsys.de mail addresses to their @gdsys.cc
    equivalent.

    Also, Dirk's address was wrong in one place; fix that as well.

    Signed-off-by: Mario Six

    Mario Six
     
  • CONFIG_SYS_CBSIZE determines the maximum length of the kernel command
    line, and the default value of 256 is too small for booting some Linux
    images in the wild.

    Signed-off-by: Tuomas Tynkkynen

    Tuomas Tynkkynen
     
  • Without the volatile attribute, compilers are entitled to optimize out
    the same asm(). In the case of __udelay() in syscounter.c, it calls
    `get_ticks()` twice, one for the starting time and the second in the
    loop to check the current time. When compilers inline `get_ticks()`
    they see the same `mrrc` instructions and optimize out the second one.
    This leads to infinite loop since we don't get updated value from the
    system counter.

    Here is a portion of the disassembly of __udelay:

    88: 428b cmp r3, r1
    8a: f8ce 20a4 str.w r2, [lr, #164] ; 0xa4
    8e: bf08 it eq
    90: 4282 cmpeq r2, r0
    92: f8ce 30a0 str.w r3, [lr, #160] ; 0xa0
    96: d3f7 bcc.n 88
    98: e8bd 8cf0 ldmia.w sp!, {r4, r5, r6, r7, sl, fp, pc}

    Note that final jump / loop at 96 to 88, we don't have any `mrrc`.

    With a volatile attribute, the above changes to this:

    8a: ec53 2f0e mrrc 15, 0, r2, r3, cr14
    8e: 42ab cmp r3, r5
    90: f8c1 20a4 str.w r2, [r1, #164] ; 0xa4
    94: bf08 it eq
    96: 42a2 cmpeq r2, r4
    98: f8c1 30a0 str.w r3, [r1, #160] ; 0xa0
    9c: d3f5 bcc.n 8a
    9e: e8bd 8cf0 ldmia.w sp!, {r4, r5, r6, r7, sl, fp, pc}
    a2: bf00 nop

    I'm advised[1] to put volatile on all asm(), so this commit also adds it
    to the asm() in timer_init().

    [1]: https://lists.denx.de/pipermail/u-boot/2018-March/322062.html

    Signed-off-by: Yasushi SHOJI
    Reviewed-by: Fabio Estevam

    Yasushi SHOJI
     
  • Sometimes imximage throws the following error:

    CFGS board/freescale/vf610twr/imximage.cfg.cfgtmp
    CFGS board/freescale/vf610twr/imximage.cfg.cfgtmp
    MKIMAGE u-boot-dtb.imx
    Error: No BOOT_FROM tag in board/freescale/vf610twr/imximage.cfg.cfgtmp
    arch/arm/mach-imx/Makefile:100: recipe for target 'u-boot-dtb.imx' failed

    Later on, when running mkimage for the u-boot.imx it will succeed in
    finding the IVT offset.

    Looks like some race condition happening during parallel build when
    processing mkimage for u-boot-dtb.imx and u-boot.imx.

    A proper fix still needs to be implemented, but as a workaround let's
    remove the error when the IVT offset is not found.

    It is useful to have such message, especially during bring-up phase,
    but the build error that it causes is severe, so better avoid the
    build error for now.

    The error checking can be re-implemented later when we have a proper
    fix.

    Reported-by: Breno Lima
    Reported-by: Thomas Petazzoni
    Signed-off-by: Fabio Estevam

    Fabio Estevam
     

06 Mar, 2018

2 commits


05 Mar, 2018

16 commits