14 Nov, 2019
2 commits
-
fixes: 8ab452d5877638a97e5bdd521d119403b70b45f5
When compiling list of cover letter cc addresses, using null as a
separater, then encoding to utf-8 results in lots of "\x00" as
separators. patman then doesnt understand that when it comes to
repoting the list to send-email.Fix this by not encoding to utf-8, as done for the other patch files.
Signed-off-by: Robert Beckett
Reviewed-by: Simon Glass -
s/Subprocress/Subprocess/
s/easiler/easier/
s/repositiory/repository/
s/rangem/range/
s/Retruns/Returns/Signed-off-by: Anatolij Gustschin
Reviewed-by: Simon Glass
05 Nov, 2019
3 commits
-
Update this tool to use Python 3 to meet the 2020 deadline.
Signed-off-by: Simon Glass
-
At present patman test fail in some environments which don't use utf-8
as the default file encoding. Add this explicitly.Signed-off-by: Simon Glass
-
At present all the 'command' methods return bytes. Most of the time we
actually want strings, so change this. We still need to keep the internal
representation as bytes since otherwise unicode strings might break over
a read() boundary (e.g. 4KB), causing errors. But we can convert the end
result to strings.Add a 'binary' parameter to cover the few cases where bytes are needed.
Signed-off-by: Simon Glass
28 Oct, 2019
1 commit
-
There is a contributor in Linux kernel with a comma in their name, which
confuses patman and results in invalid to- or cc- addresses on some
patches. To avoid this, let's use \0 as a separator when generating cc
file.Signed-off-by: Dmitry Torokhov
Reviewed-by: Simon Glass
15 Oct, 2019
4 commits
-
As per the centithread on ksummit-discuss [1], there are folks who
feel that if a Change-Id is present in a developer's local commit that
said Change-Id could be interesting to include in upstream posts.
Specifically if two commits are posted with the same Change-Id there's
a reasonable chance that they are either the same commit or a newer
version of the same commit. Specifically this is because that's how
gerrit has trained people to work.There is much angst about Change-Id in upstream Linux, but one thing
that seems safe and non-controversial is to include the Change-Id as
part of the string of crud that makes up a Message-Id.Let's give that a try.
In theory (if there is enough adoption) this could help a tool more
reliably find various versions of a commit. This actually might work
pretty well for U-Boot where (I believe) quite a number of developers
use patman, so there could be critical mass (assuming that enough of
these people also use a git hook that adds Change-Id to their
commits). I was able to find this git hook by searching for "gerrit
change id git hook" in my favorite search engine.In theory one could imagine something like this could be integrated
into other tools, possibly even git-send-email. Getting it into
patman seems like a sane first step, though.NOTE: this patch is being posted using a patman containing this patch,
so you should be able to see the Message-Id of this patch and see that
it contains my local Change-Id, which ends in 2b9 if you want to
check.[1] https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2019-August/006739.html
Signed-off-by: Douglas Anderson
-
Remove this file from git and instead build it using the Makefile.
Update tools.GetInputFilename() to support reading files from an absolute
path, so that we can read the Elf test files easily. Also make sure that
the temp directory is report in ELF tests as this was commented out.Signed-off-by: Simon Glass
-
At present tools are not expected to fail. If they do an exception is
raised but there is no detail about what went wrong. This makes it hard
to debug if something does actually go wrong.Fix this by outputting both stderr and stdout on failure.
Signed-off-by: Simon Glass
-
Since cros_subprocess use bytestrings now, this feature not needed. Drop
it.Signed-off-by: Simon Glass
29 Jul, 2019
5 commits
-
At present outdir remains set ever after the output directory has been
removed. Fix this to avoid trying to access it when it is not present.Signed-off-by: Simon Glass
-
At present binman cannot replace data within a CBFS since it does not
allow rewriting of the files in that CBFS. Implement this by using the
new WriteData() method to handle the case.Add a header to compressed data so that the amount of compressed data can
be determined without reference to the size of the containing entry. This
allows the entry to be larger that the contents, without causing errors in
decompression. This is necessary to cope with a compressed device tree
being updated in such a way that it shrinks after the entry size is
already set (an obscure case). It is not used with CBFS since it has its
own metadata for this. Increase the number of passes allowed to resolve
the position of entries, to handle this case.Add a test for this new logic.
Signed-off-by: Simon Glass
-
Use the new logging feature to log information about progress with
packing. This is useful to see how binman is figuring things out.Also update elf.py to use the same feature.
Signed-off-by: Simon Glass
-
Use the debug level constants instead of open-coding them in the file.
Signed-off-by: Simon Glass
-
At present tout writes directly to stdout. This is not necessary and it
prevents tests from redirecting output. Change it to use print() for the
non-progress output.Signed-off-by: Simon Glass
25 Jul, 2019
4 commits
-
Binman generally operates silently but in some cases it is useful to see
what Binman is actually doing at each step. Enable some logging output
with different logging levels selectable via the -v flag.Signed-off-by: Simon Glass
-
At present entry modules can only be accessed using Entry.Lookup() or
Entry.Create(). Most of the time this is fine, but sometimes a module
needs to provide constants or helper functions useful to other modules.
It is easier in this case to use 'import'.Add an __init__ file to permit this.
Signed-off-by: Simon Glass
-
This class is the new way to handle arguments in Python. Convert binman
over to use it. At the same time, introduce commands so that we can
separate out the different parts of binman functionality.Signed-off-by: Simon Glass
-
This tool has quite a few arguments and options, so put the functionality
in a function so that we call it from one place and hopefully get it
right.Signed-off-by: Simon Glass
24 Jul, 2019
3 commits
-
Add utility functions to compress and decompress using lz4 and lzma
algorithms. In the latter case these use the legacy lzma support favoured
by coreboot's CBFS.No tests are provided as these functions will be tested by the CBFS
tests in a separate patch.Signed-off-by: Simon Glass
-
Sometimes tools can be located by looking in other locations. Add a way to
direct the search.Signed-off-by: Simon Glass
-
If kwargs contains raise_on_error then this function generates an error
due to a duplicate argument. Fix this.Signed-off-by: Simon Glass
11 Jul, 2019
16 commits
-
We need slightly different commands to run code coverage with Python 3.
Update the RunTestCoverage() function to handle this.Signed-off-by: Simon Glass
-
While reading files in binary mode is the norm, sometimes we want to use
text mode. Add an optional parameter to handle this.Signed-off-by: Simon Glass
-
In Python 3 bytes and str are separate types. Use bytes to ensure that
the code functions correctly with Python 3.Signed-off-by: Simon Glass
-
The difference between the bytes and str types in Python 3 requires a
number of minor changes to this function. Update it to handle the input
data using the 'bytes' type. Create two useful helper functions which can
be used by other modules too.Signed-off-by: Simon Glass
-
Update the shebang to allow either Python 2 or Python 3.
Signed-off-by: Simon Glass
-
Use the new functions in the tools module to handle conversion.
Signed-off-by: Simon Glass
-
Change the code so that it works on both Python 2 and Python 3. This works
by using unicode instead of latin1 for the test input, and ensuring that
the output is converted to a string rather than a unicode object on
Python 2.Signed-off-by: Simon Glass
-
The unicode type does not exist in Python 3 and when displaying strings
they do not have the 'u' prefix. Adjusts the settings unit tests to deal
with this difference, by converting the comparison value to a string, thus
dropping the 'u'.Signed-off-by: Simon Glass
-
We use sets to produce the list of To and Cc lines for a series. This does
not result in stable ordering of the recipients. Sort each list to ensure
that the output is repeatable. This is necessary for tests.Signed-off-by: Simon Glass
-
Create helper functions in the tools module to deal with the differences
between unicode in Python 2 (where we use the 'unicode' type) and Python 3
(where we use the 'str' type).Signed-off-by: Simon Glass
-
With Python 3 this class has moved. Update the code to handle both cases.
Signed-off-by: Simon Glass
-
The method of multiplying a character by a number works well for creating
a repeated string in Python 2. But in Python 3 we need to use bytes()
instead, to avoid unicode problems, since 'bytes' is no-longer just an
alias of 'str'.Create a function to handle this detail and call it from the relevant
places in binman.Signed-off-by: Simon Glass
-
At present cros_subprocess and the tools library use a string to obtain
stdout from a program. This works fine on Python 2. With Python 3 we end
up with unicode errors in some cases. Fix this by providing a binary mode,
which returns the data as bytes() instead of a string.Signed-off-by: Simon Glass
-
Python 3 requires this, and Python 2 allows it. Convert the code over to
ensure compatibility with Python 3.Signed-off-by: Simon Glass
-
Update all print statements to be functions, as required by Python 3.
Signed-off-by: Simon Glass
-
At present this function uses lists and strings. This does not work so
well with Python 3, and testing against '' does not work for a bytearray.
Update the code to fix these issues.Signed-off-by: Simon Glass
08 Oct, 2018
2 commits
-
At present the tests run one after the other using a single CPU. This is
not very efficient. Bring in the concurrencytest module and run the tests
concurrently, using one process for each CPU by default. A -P option
allows this to be overridden, which is necessary for code-coverage to
function correctly.This requires fixing a few tests which are currently not fully
independent.At some point we might consider doing this across all pytests in U-Boot.
There is a pytest version that supports specifying the number of processes
to use, but it did not work for me.Signed-off-by: Simon Glass
-
At present calling Uninit() always called ClearProgress() which outputs
a \r character as well as spaces to remove any progress information on the
line. This can mess up the normal output of binman and other tools. Fix
this by outputing this only when progress information has actually been
previous written.Signed-off-by: Simon Glass