Eric Lee / smarc-uboot

15 Oct, 2013

1 commit

23 Aug, 2013

1 commit

  • 2b26201a2   env_nand.c: support falling back to redundant env when writing ... Browse Code »

    Without this patch, when the currently chosen environment to be written
    has bad blocks, saveenv fails completely. Instead, when there is
    redundant environment fall back to the other copy. Environment reading
    needs no adjustment, as the fallback logic for incomplete writes applies
    to this case as well.

    Signed-off-by: Phil Sutter

    Phil Sutter
     

24 Jul, 2013

1 commit

10 Apr, 2013

1 commit

  • c39d6a0ea   nand: Extend nand_(read|write)_skip_bad with *actual and limit parameters ... Browse Code »

    We make these two functions take a size_t pointer to how much space
    was used on NAND to read or write the buffer (when reads/writes happen)
    so that bad blocks can be accounted for. We also make them take an
    loff_t limit on how much data can be read or written. This means that
    we can now catch the case of when writing to a partition would exceed
    the partition size due to bad blocks. To do this we also need to make
    check_skip_len count not just complete blocks used but partial ones as
    well. All callers of nand_(read|write)_skip_bad are adjusted to call
    these with the most sensible limits available.

    The changes were started by Pantelis and finished by Tom.

    Signed-off-by: Pantelis Antoniou
    Signed-off-by: Tom Rini

    Tom Rini
     

06 Apr, 2013

1 commit

03 Apr, 2013

1 commit

23 Feb, 2013

2 commits

14 Dec, 2012

1 commit

  • be11235ab   env: Hide '.' variables in env print by default ... Browse Code »

    When printing all variables with env print, don't print variables that
    begin with '.'. If env print is called with a '-a' switch, then
    include variables that begin with '.' (just like the ls command).

    Variables printed explicitly will be printed even without the -a.

    Signed-off-by: Joe Hershberger

    Joe Hershberger
     

19 Sep, 2012

1 commit

  • 78b2de802   env_nand: fix incorrect size parameter to ALLOC_CACHE_ALIGN_BUFFER ... Browse Code »

    The third parameter to ALLOC_CACHE_ALIGN_BUFFER is not size (as named),
    but rather count (number of elements of the type to allocate). The
    current code ends up allocating one copy of env_t for each byte in its
    size, which quite possibly ends up overflowing RAM.

    This fixes a bug in commit 3801a15 "env_nand: align NAND buffers".

    Reported-by: Prabhakar Lad
    Signed-off-by: Stephen Warren
    Reported-by: Prabhakar Lad

    Stephen Warren
     

02 Sep, 2012

1 commit

05 Jan, 2012

1 commit

06 Dec, 2011

1 commit

22 Nov, 2011

3 commits

08 Nov, 2011

1 commit

  • 37f2fe747   env: allow to export only selected variables ... Browse Code »

    New syntax:
    env export [-t | -b | -c] [-s size] addr [var ...]

    With this change it is possible to provide a list of variables names
    that shall be exported. Whenno arguments are given, the whole
    environment gets exported.

    NOTE: The new handling of the "size" argument means a change to the
    user API.

    Signed-off-by: Wolfgang Denk

    Wolfgang Denk
     

25 May, 2011

1 commit

  • 3b250ffb4   env_nand: zero-initialize variable nand_erase_options ... Browse Code »

    Commit 30486322 (nand erase: .spread, .part, .chip subcommands)
    added a new field to struct nand_erase_options, but forgot to
    update common/env_nand.c.

    Depending on the stack state and bad block distribution, saveenv()
    can thus erase more than CONFIG_ENV_RANGE bytes which may corrupt
    the following NAND sectors/partitions.

    Signed-off-by: Daniel Hobi
    Signed-off-by: Scott Wood

    Daniel Hobi
     

09 Feb, 2011

1 commit

03 Feb, 2011

1 commit

18 Dec, 2010

1 commit

  • 2eb1573f0   hashtable: drop all non-reentrant versions ... Browse Code »

    The non-reentrant versions of the hashtable functions operate on a single
    shared hashtable. So if two different people try using these funcs for
    two different purposes, they'll cause problems for the other.

    Avoid this by converting all existing hashtable consumers over to the
    reentrant versions and then punting the non-reentrant ones.

    Signed-off-by: Mike Frysinger

    Mike Frysinger
     

07 Dec, 2010

1 commit

  • 068a208b4   env_nand: Use nand_read_skip_bad instead of nand_read ... Browse Code »

    The nand-read function returns an error code if correctable errors have occurred.
    This is not desirable, since the errors have been corrected!

    This patch switches to the nand_read_skip_bad function which does not
    return an error code if the errors are correctable.

    Signed-off-by: Steve Sakoman
    Acked-by: Scott Wood

    Steve Sakoman
     

20 Sep, 2010

1 commit

  • ea882baf9   New implementation for internal handling of environment variables. ... Browse Code »

    Motivation:

    * Old environment code used a pessimizing implementation:
    - variable lookup used linear search => slow
    - changed/added variables were added at the end, i. e. most
    frequently used variables had the slowest access times => slow
    - each setenv() would calculate the CRC32 checksum over the whole
    environment block => slow
    * "redundant" envrionment was locked down to two copies
    * No easy way to implement features like "reset to factory defaults",
    or to select one out of several pre-defined (previously saved) sets
    of environment settings ("profiles")
    * No easy way to import or export environment settings

    ======================================================================

    API Changes:

    - Variable names starting with '#' are no longer allowed

    I didn't find any such variable names being used; it is highly
    recommended to follow standard conventions and start variable names
    with an alphanumeric character

    - "printenv" will now print a backslash at the end of all but the last
    lines of a multi-line variable value.

    Multi-line variables have never been formally defined, allthough
    there is no reason not to use them. Now we define rules how to deal
    with them, allowing for import and export.

    - Function forceenv() and the related code in saveenv() was removed.
    At the moment this is causing build problems for the only user of
    this code (schmoogie - which has no entry in MAINTAINERS); may be
    fixed later by implementing the "env set -f" feature.

    Inconsistencies:

    - "printenv" will '\\'-escape the '\n' in multi-line variables, while
    "printenv var" will not do that.

    ======================================================================

    Advantages:

    - "printenv" output much better readable (sorted)
    - faster!
    - extendable (additional variable properties can be added)
    - new, powerful features like "factory reset" or easy switching
    between several different environment settings ("profiles")

    Disadvantages:

    - Image size grows by typically 5...7 KiB (might shrink a bit again on
    systems with redundant environment with a following patch series)

    ======================================================================

    Implemented:

    - env command with subcommands:

    - env print [arg ...]

    same as "printenv": print environment

    - env set [-f] name [arg ...]

    same as "setenv": set (and delete) environment variables

    ["-f" - force setting even for read-only variables - not
    implemented yet.]

    - end delete [-f] name

    not implemented yet

    ["-f" - force delete even for read-only variables]

    - env save

    same as "saveenv": save environment

    - env export [-t | -b | -c] addr [size]

    export internal representation (hash table) in formats usable for
    persistent storage or processing:

    -t: export as text format; if size is given, data will be
    padded with '\0' bytes; if not, one terminating '\0'
    will be added (which is included in the "filesize"
    setting so you can for exmple copy this to flash and
    keep the termination).
    -b: export as binary format (name=value pairs separated by
    '\0', list end marked by double "\0\0")
    -c: export as checksum protected environment format as
    used for example by "saveenv" command
    addr: memory address where environment gets stored
    size: size of output buffer

    With "-c" and size is NOT given, then the export command will
    format the data as currently used for the persistent storage,
    i. e. it will use CONFIG_ENV_SECT_SIZE as output block size and
    prepend a valid CRC32 checksum and, in case of resundant
    environment, a "current" redundancy flag. If size is given, this
    value will be used instead of CONFIG_ENV_SECT_SIZE; again, CRC32
    checksum and redundancy flag will be inserted.

    With "-b" and "-t", always only the real data (including a
    terminating '\0' byte) will be written; here the optional size
    argument will be used to make sure not to overflow the user
    provided buffer; the command will abort if the size is not
    sufficient. Any remainign space will be '\0' padded.

    On successful return, the variable "filesize" will be set.
    Note that filesize includes the trailing/terminating '\0'
    byte(s).

    Usage szenario: create a text snapshot/backup of the current
    settings:

    => env export -t 100000
    => era ${backup_addr} +${filesize}
    => cp.b 100000 ${backup_addr} ${filesize}

    Re-import this snapshot, deleting all other settings:

    => env import -d -t ${backup_addr}

    - env import [-d] [-t | -b | -c] addr [size]

    import external format (text or binary) into hash table,
    optionally deleting existing values:

    -d: delete existing environment before importing;
    otherwise overwrite / append to existion definitions
    -t: assume text format; either "size" must be given or the
    text data must be '\0' terminated
    -b: assume binary format ('\0' separated, "\0\0" terminated)
    -c: assume checksum protected environment format
    addr: memory address to read from
    size: length of input data; if missing, proper '\0'
    termination is mandatory

    - env default -f

    reset default environment: drop all environment settings and load
    default environment

    - env ask name [message] [size]

    same as "askenv": ask for environment variable

    - env edit name

    same as "editenv": edit environment variable

    - env run

    same as "run": run commands in an environment variable

    ======================================================================

    TODO:

    - drop default env as implemented now; provide a text file based
    initialization instead (eventually using several text files to
    incrementally build it from common blocks) and a tool to convert it
    into a binary blob / object file.

    - It would be nice if we could add wildcard support for environment
    variables; this is needed for variable name auto-completion,
    but it would also be nice to be able to say "printenv ip*" or
    "printenv *addr*"

    - Some boards don't link any more due to the grown code size:
    DU405, canyonlands, sequoia, socrates.

    => cc: Matthias Fuchs ,
    Stefan Roese ,
    Heiko Schocher

    - Dropping forceenv() causes build problems on schmoogie

    => cc: Sergey Kubushyn

    - Build tested on PPC and ARM only; runtime tested with NOR and NAND
    flash only => needs testing!!

    Signed-off-by: Wolfgang Denk
    Cc: Matthias Fuchs ,
    Cc: Stefan Roese ,
    Cc: Heiko Schocher
    Cc: Sergey Kubushyn

    Wolfgang Denk
     

14 Aug, 2010

1 commit

  • 962ad59e2   env_nand: return error when no device is found ... Browse Code »

    Currently, if there is an error probing the NAND chip and the env is based
    in NAND, the readenv() function will use a NULL function pointer and thus
    jump to address 0.

    Here I just check for a non-zero value of blocksize as that shouldn't be
    zero when a valid device is found, but perhaps there is a better way for
    someone familiar with the NAND internals to suggest.

    Signed-off-by: Mike Frysinger
    Tested-by: Ben Gardiner

    Mike Frysinger
     

13 Jul, 2010

2 commits

  • 53504a278   NAND: formatting cleanups from env.oob support ... Browse Code »

    Change if (ok) {
    bunch of stuff
    } else {
    error
    }

    to

    if (error) {
    get out
    }

    proceed with bunch of stuff

    Plus a few whitespace cleanups.

    Signed-off-by: Scott Wood

    Scott Wood
     
  • c9f7351b5   NAND: environment offset in OOB (CONFIG_ENV_OFFSET_OOB) ... Browse Code »

    This is a re-submission of the patch by Harald Welte
    with minor modifications for rebase and changes
    as suggested by Scott Wood [1] [2].

    This patch enables the environment partition to have a run-time dynamic
    location (offset) in the NAND flash. The reason for this is simply that
    all NAND flashes have factory-default bad blocks, and a fixed compile
    time offset would mean that sometimes the environment partition would
    live inside factory bad blocks. Since the number of factory default
    blocks can be quite high (easily 1.3MBytes in current standard
    components), it is not economic to keep that many spare blocks inside
    the environment partition.

    With this patch and CONFIG_ENV_OFFSET_OOB enabled, the location of the
    environment partition is stored in the out-of-band (OOB) data of the
    first block in flash. Since the first block is where most systems boot
    from, the vendors guarantee that the first block is not a factory
    default block.

    This patch introduces the 'nand env.oob' command, which can be called
    from the u-boot command line. 'nand env.oob get' reads the address of
    the environment partition from the OOB data, 'nand env.oob set
    {offset,partition-name}' allows the setting of the marker by specifying
    a numeric offset or a partition name.

    [1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/43916
    [2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/79195

    Signed-off-by: Ben Gardiner
    Acked-by: Harald Welte

    Ben Gardiner
     

05 Jul, 2010

1 commit

28 Jan, 2010

1 commit

10 Aug, 2009

1 commit

  • 18304f767   env: kill off default_environment_size ... Browse Code »

    The only environment type that uses this variable is spi flash, and that is
    only because it is reimplementing the common set_default_env() function.
    So fix the spi flash code and kill off the default_environment_size in the
    process.

    Signed-off-by: Mike Frysinger

    Mike Frysinger
     

17 Jul, 2009

1 commit

  • be33b046b   Remove legacy NAND and disk on chip code. ... Browse Code »
    43

    Legacy NAND had been scheduled for removal. Any boards that use this
    were already not building in the previous release due to an #error.

    The disk on chip code in common/cmd_doc.c relies on legacy NAND,
    and it has also been removed. There is newer disk on chip code
    in drivers/mtd/nand; someone with access to hardware and sufficient
    time and motivation can try to get that working, but for now disk
    on chip is not supported.

    Signed-off-by: Scott Wood

    Scott Wood
     

08 Jul, 2009

2 commits

18 Feb, 2009

1 commit

07 Feb, 2009

1 commit

11 Sep, 2008

3 commits

13 Aug, 2008

1 commit

10 Jul, 2008

2 commits